From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02576C04A68 for ; Thu, 28 Jul 2022 14:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbiG1OOm (ORCPT ); Thu, 28 Jul 2022 10:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbiG1OOj (ORCPT ); Thu, 28 Jul 2022 10:14:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C39814000; Thu, 28 Jul 2022 07:14:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2815E60A10; Thu, 28 Jul 2022 14:14:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 024C9C43140; Thu, 28 Jul 2022 14:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659017677; bh=G6gX1hF4PLXi0gkv94nAzv1BT0g1WX1G8vkIVNw1/Zw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nie8FLHMj48h43cconZqNLxRLLC4QUUDF6PjNzfFUzfsIV3o+Tt5O65dY2HF/QI+C JGTWYljiv+52htx6/Xpyap6cxsW5py1VG7v4Zgn7veZCJvyIZ6DAV0BPdVd40x7IX5 qvSek5C2u4yGXJ+KDN3ykRUrW1P3djkHDWhZe6po= Date: Thu, 28 Jul 2022 16:14:34 +0200 From: Greg KH To: Benjamin Tissoires Cc: Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , Kumar Kartikeya Dwivedi , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Jonathan Corbet , Tero Kristo , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH bpf-next v7 12/24] HID: Kconfig: split HID support and hid-core compilation Message-ID: References: <20220721153625.1282007-1-benjamin.tissoires@redhat.com> <20220721153625.1282007-13-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721153625.1282007-13-benjamin.tissoires@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 05:36:13PM +0200, Benjamin Tissoires wrote: > Currently, we step into drivers/hid/ based on the value of > CONFIG_HID. > > However, that value is a tristate, meaning that it can be a module. > > As per the documentation, if we jump into the subdirectory by > following an obj-m, we can not compile anything inside that > subdirectory in vmlinux. It is considered as a bug. > > To make things more friendly to HID-BPF, split HID (the HID core > parameter) from HID_SUPPORT (do we want any kind of HID support in the > system?), and make this new config a boolean. > > Signed-off-by: Benjamin Tissoires > > --- Reviewed-by: Greg Kroah-Hartman