All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniil Lunev <dlunev@chromium.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
	Can Guo <cang@codeaurora.org>,
	Daejun Park <daejun7.park@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Sohaib Mohamed <sohaib.amhmd@gmail.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ufs: core: print UFSHCD capabilities in controller's sysfs node
Date: Fri, 29 Jul 2022 10:12:07 +0200	[thread overview]
Message-ID: <YuOWV5uLVV2JYP1c@kroah.com> (raw)
In-Reply-To: <20220729120216.v3.2.Ibf9efc9be50783eeee55befa2270b7d38552354c@changeid>

On Fri, Jul 29, 2022 at 12:05:08PM +1000, Daniil Lunev wrote:
> Allows userspace to check if Clock Scaling, Write Booster and Inline
> Crypto Engine functionality can be enabled.
> 
> Signed-off-by: Daniil Lunev <dlunev@chromium.org>
> 
> ---
> 
> Changes in v3:
> * Expose each capability individually.
> * Update documentation to represent new scheme.
> 
> Changes in v2:
> * Add documentation entry for the new sysfs node.
> 
>  Documentation/ABI/testing/sysfs-driver-ufs | 39 ++++++++++++++++++++
>  drivers/ufs/core/ufs-sysfs.c               | 41 ++++++++++++++++++++++
>  2 files changed, 80 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
> index 6b248abb1bd71..805d76f7d7aef 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -1591,6 +1591,45 @@ Description:	This entry shows the status of HPB.
>  
>  		The file is read only.
>  
> +What:		/sys/bus/platform/drivers/ufshcd/*/capabilities/clock_scaling

This shouldn't be linked to as a driver file, it's a device file.  So no
need for this line.

> +What:		/sys/bus/platform/devices/*.ufs/capabilities/clock_scaling

Since when are all ufs devices platform devices?  Do we not have UFS
controllers on other types of busses?

thanks,

greg k-h

  parent reply	other threads:[~2022-07-29  8:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  2:05 [PATCH v3 0/2] Expose UFSHCD capabilities in sysfs Daniil Lunev
2022-07-29  2:05 ` Daniil Lunev
2022-07-29  2:05 ` [PATCH v3 1/2] ufs: add function to check CRYPTO capability Daniil Lunev
2022-07-29  2:05   ` Daniil Lunev
2022-07-29  8:10   ` Greg Kroah-Hartman
2022-07-29  8:10     ` Greg Kroah-Hartman
2022-07-29  8:37     ` Daniil Lunev
2022-07-29  8:37       ` Daniil Lunev
2022-07-29  2:05 ` [PATCH v3 2/2] ufs: core: print UFSHCD capabilities in controller's sysfs node Daniil Lunev
2022-07-29  4:02   ` Eric Biggers
2022-07-29  8:12   ` Greg Kroah-Hartman [this message]
2022-07-29  8:29     ` Daniil Lunev
2022-07-29  8:32       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuOWV5uLVV2JYP1c@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=dlunev@chromium.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=sohaib.amhmd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.