From: Helge Deller <deller@gmx.de>
To: Khalid Masum <khalid.masum.92@gmail.com>,
syzbot <syzbot+14b0e8f3fd1612e35350@syzkaller.appspotmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH] tty: vt: selection: Add check for valid tiocl_selection values
Date: Sat, 30 Jul 2022 20:49:35 +0200 [thread overview]
Message-ID: <YuV9PybMPgc83Jis@p100> (raw)
In-Reply-To: <eb4a26aa-da30-ceee-7d27-c1e902dd4218@gmx.de>
The line and column numbers for the selection need to start at 1.
Add the checks to prevent invalid input.
Signed-off-by: Helge Deller <deller@gmx.de>
Reported-by: syzbot+14b0e8f3fd1612e35350@syzkaller.appspotmail.com
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index f7755e73696e..58692a9b4097 100644
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -326,6 +326,9 @@ static int vc_selection(struct vc_data *vc, struct tiocl_selection *v,
return 0;
}
+ if (!v->xs || !v->ys || !v->xe || !v->ye)
+ return -EINVAL;
+
v->xs = min_t(u16, v->xs - 1, vc->vc_cols - 1);
v->ys = min_t(u16, v->ys - 1, vc->vc_rows - 1);
v->xe = min_t(u16, v->xe - 1, vc->vc_cols - 1);
next prev parent reply other threads:[~2022-07-30 18:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:18 [syzbot] KASAN: vmalloc-out-of-bounds Write in imageblit (2) syzbot
2022-01-20 22:58 ` syzbot
2022-01-21 1:48 ` syzbot
2022-07-29 6:51 ` Khalid Masum
2022-07-30 17:25 ` Helge Deller
2022-07-30 18:49 ` Helge Deller [this message]
2022-08-04 5:47 ` [PATCH] tty: vt: selection: Add check for valid tiocl_selection values Jiri Slaby
2022-08-04 7:15 ` Helge Deller
2022-08-04 8:44 ` Helge Deller
2022-08-04 9:22 ` Jiri Slaby
2022-08-05 11:13 ` Adam Borowski
2022-08-05 11:13 ` Adam Borowski
2022-07-30 18:50 ` [PATCH] vt: Clear selection before changing the font Helge Deller
2022-07-31 11:32 ` Khalid Masum
2022-07-31 10:03 ` [syzbot] KASAN: vmalloc-out-of-bounds Write in imageblit (2) Khalid Masum
2022-07-31 10:54 ` Helge Deller
2022-07-31 10:54 ` Helge Deller
2022-07-31 11:23 ` Khalid Masum
2022-07-31 11:23 ` Khalid Masum
2022-07-31 13:55 ` Khalid Masum
2022-07-31 15:39 ` Helge Deller
2022-08-01 4:09 ` Khalid Masum
2022-07-30 8:12 ` Khalid Masum
2022-07-30 10:55 ` syzbot
2022-08-01 10:43 ` Dan Carpenter
2022-08-01 14:06 ` Khalid Masum
2022-07-30 11:45 ` Khalid Masum
2022-07-30 15:39 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuV9PybMPgc83Jis@p100 \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=khalid.masum.92@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+14b0e8f3fd1612e35350@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.