From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B13B2C00140 for ; Tue, 2 Aug 2022 15:09:20 +0000 (UTC) Received: from localhost ([::1]:55280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oItWJ-0001Mf-Dd for qemu-devel@archiver.kernel.org; Tue, 02 Aug 2022 11:09:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oItTe-0008UV-Lx for qemu-devel@nongnu.org; Tue, 02 Aug 2022 11:06:34 -0400 Received: from dfw.source.kernel.org ([139.178.84.217]:59746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oItTc-0003al-QB for qemu-devel@nongnu.org; Tue, 02 Aug 2022 11:06:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D3BF61313; Tue, 2 Aug 2022 15:06:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2ECC433C1; Tue, 2 Aug 2022 15:06:29 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="eOWAAy47" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1659452787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OGtDjw+jGhIv3vWIthbB73kE3mAfIKFTpr2M7t5UtDQ=; b=eOWAAy476UebdL0OBHYg+JkoUo5k+bTl/8ji8tG6TEJumkmO4iQcVAoMv0ym4+NEikDuTW dwiouhTN89AahM6EtApwDuuEUxMydALBT6t6gUgecIHMle52ukbJw8i/LzlL/XEl8tM5A2 2swVTn+ZZd7PriQ6xFC2ttxytJDyjiI= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 6f2dcaf9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 2 Aug 2022 15:06:27 +0000 (UTC) Date: Tue, 2 Aug 2022 17:06:19 +0200 From: "Jason A. Donenfeld" To: Xiaoyao Li Cc: Paolo Bonzini , qemu-devel@nongnu.org, Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=83=C2=A9?= , Laurent Vivier , "Michael S . Tsirkin" Subject: Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry Message-ID: References: <20220721163621.761513-1-pbonzini@redhat.com> <20220721163621.761513-10-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=139.178.84.217; envelope-from=SRS0=YGwI=YG=zx2c4.com=Jason@kernel.org; helo=dfw.source.kernel.org X-Spam_score_int: -67 X-Spam_score: -6.8 X-Spam_bar: ------ X-Spam_report: (-6.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Xiaoyao, On Tue, Aug 02, 2022 at 10:53:07PM +0800, Xiaoyao Li wrote: > yes, with >= 7.1, pcmc->legacy_no_rng_seed = false by default, and RNG > seed is used. This is intended behavior. Being on by default is basically the whole point of it. Otherwise it's useless. > > > Either way, this shouldn't cause boot failures. > > It does fail booting OVMF with #PF. Below diff can fix the #PF for me. Huh, interesting. Sounds like maybe there's a bug I need to fix. Can you send me some repro instructions, and I'll look into it right away. Jason