From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A38C19F2C for ; Tue, 2 Aug 2022 11:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236765AbiHBLHv (ORCPT ); Tue, 2 Aug 2022 07:07:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231732AbiHBLHt (ORCPT ); Tue, 2 Aug 2022 07:07:49 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB0F3F33F for ; Tue, 2 Aug 2022 04:07:48 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id rq15so19264499ejc.10 for ; Tue, 02 Aug 2022 04:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HhBjbo8A8eWeFC5DIsw7GV25tztk2PipnKxnLI7M/pc=; b=IZO632N+8fJgZ63cyIvrli96zxrVST1ZyxOO8uBBjR7RIEMfaWr20NZlDFLUDxhhCX TDHj2F4kY+WNO+je4RnJkMQ0dzAZ/xosI0+XAfs+WzvCxsfdFOAdhRgo8UzUKUXdgKVg odRGlOFdwz3kFg+ziaFThsZLfgJ+ao3Iq+X8wExis8bP1MhvZrtLr1/2swsb8DIINGqJ fRksmk0gBuAkSGJWtRQ785h7GYoedhPHcJgcvHUBPq/JGrLZHA76fqmdp8ltcqDqLq0b Ria0Do+5yx7Lg212wl4xvex/Wa3Ox6r2E/JIP4tdxU19UfV7xJz/gCQAz1VaSyvQV6fJ +tLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=HhBjbo8A8eWeFC5DIsw7GV25tztk2PipnKxnLI7M/pc=; b=YySopo7CtN10RcwjHETfLhVPS86k+4bY+DNSpAkYg9PAv0oJh0uUIw4J8s5XwHXNeR 2FAjkIRvJaqinmz6PXTyr8aGF/G/klDCtTS3+Ighcd/nsjFzhD/NJgK9W2atgp6Sgm7v nfQXbuxZnbYJLAcIJlZ/XIQMqWzghQFECkCR38TBHNHGweAJrm0uN0ApkYcAcVyjAZCb MYBW9wHWJYCtlr4jE9efQTPpLSJDASOBaz6uIOjfRv7tofKKt27DItuzmGaFAjRiQ+mO uVy7Be1LOR/O/js1ZFjvuqG4qLQZ6lz0BeS2DdwtDoQyOnovKyQ7h8ck8v/jKOCBRwbV jlcg== X-Gm-Message-State: AJIora/Si1WrDErpw4yRJMrP48fHyrRxvbIcMkxLY1TJrWmaMRMnECGC HE7SSZxJVitaHjKlXjHBgvs= X-Google-Smtp-Source: AGRyM1uIexBXkZ/W8ypkBhJxXAeE7iOOu9zuACRy8RUXHAcGJJt+UJ5KxTBjnCDBBrNIWr41YAr2KQ== X-Received: by 2002:a17:907:9801:b0:72f:1a8d:8dbe with SMTP id ji1-20020a170907980100b0072f1a8d8dbemr15444298ejc.537.1659438467494; Tue, 02 Aug 2022 04:07:47 -0700 (PDT) Received: from gmail.com (84-236-113-167.pool.digikabel.hu. [84.236.113.167]) by smtp.gmail.com with ESMTPSA id ck28-20020a0564021c1c00b0043df40e4cfdsm808114edb.35.2022.08.02.04.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 04:07:46 -0700 (PDT) Sender: Ingo Molnar Date: Tue, 2 Aug 2022 13:07:44 +0200 From: Ingo Molnar To: Siddh Raman Pant Cc: x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , linux-kernel , linux-kernel-mentees Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check Message-ID: References: <20220731160913.632092-1-code@siddh.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220731160913.632092-1-code@siddh.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Siddh Raman Pant wrote: > GCC warning log: > =========================================================================== > > arch/x86/mm/numa.c: In function ‘cpumask_of_node’: > arch/x86/mm/numa.c:916:39: warning: the comparison will always evaluate as ‘false’ for the address of ‘node_to_cpumask_map’ will never be NULL [-Waddress] > 916 | if (node_to_cpumask_map[node] == NULL) { > | ^~ Your fix makes sense I suppose, but I'm wondering how testing didn't trigger this warning. Off-stack isn't a rare config option: kepler:~/tip> make allmodconfig # # No change to .config # kepler:~/tip> grep CPUMASK_OFFSTACK .config CONFIG_CPUMASK_OFFSTACK=y kepler:~/tip> What am I missing? > Fixes: c032ef60d1aa ("cpumask: convert node_to_cpumask_map[] to cpumask_var_t") > Fixes: de2d9445f162 ("x86: Unify node_to_cpumask_map handling between 32 and 64bit") These are ancient commits from 2009 & 2011. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCACFC00140 for ; Tue, 2 Aug 2022 11:07:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3DE5B405B9; Tue, 2 Aug 2022 11:07:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3DE5B405B9 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=IZO632N+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3oggU365kzTZ; Tue, 2 Aug 2022 11:07:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4290D40142; Tue, 2 Aug 2022 11:07:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4290D40142 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0D555C0033; Tue, 2 Aug 2022 11:07:51 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 65CCBC002D for ; Tue, 2 Aug 2022 11:07:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2B63540872 for ; Tue, 2 Aug 2022 11:07:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2B63540872 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=IZO632N+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPm0uV2d9l1d for ; Tue, 2 Aug 2022 11:07:49 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 42A0840871 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 42A0840871 for ; Tue, 2 Aug 2022 11:07:49 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id gk3so13124339ejb.8 for ; Tue, 02 Aug 2022 04:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HhBjbo8A8eWeFC5DIsw7GV25tztk2PipnKxnLI7M/pc=; b=IZO632N+8fJgZ63cyIvrli96zxrVST1ZyxOO8uBBjR7RIEMfaWr20NZlDFLUDxhhCX TDHj2F4kY+WNO+je4RnJkMQ0dzAZ/xosI0+XAfs+WzvCxsfdFOAdhRgo8UzUKUXdgKVg odRGlOFdwz3kFg+ziaFThsZLfgJ+ao3Iq+X8wExis8bP1MhvZrtLr1/2swsb8DIINGqJ fRksmk0gBuAkSGJWtRQ785h7GYoedhPHcJgcvHUBPq/JGrLZHA76fqmdp8ltcqDqLq0b Ria0Do+5yx7Lg212wl4xvex/Wa3Ox6r2E/JIP4tdxU19UfV7xJz/gCQAz1VaSyvQV6fJ +tLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=HhBjbo8A8eWeFC5DIsw7GV25tztk2PipnKxnLI7M/pc=; b=ns2wRV3D61ZY2mFnVFkGLO7AVlppCMj/pRrpYbNwKplt1pCn7oX0KshHcX6MgeI/Cf QCdFS9QIxbqx7OsS6Y2+sqTw21dIywRbaxGA4P4Kd2F5kywPoNPnA2XSmFoC4Wib8y/8 V8UBxXtU46BPo7bxRkWnw4y9UinmAoeE7m8DTUazeIiEHmB/EpCbvCBulT3QQYDjpCyr 1/xmvIjhzImbzTQbP5tVhPTdlSx9YKe+syFQ2H8aL9U1F1LE7Wd85cFhR62uR5ukwe7g GPU0/7J1fbCIOM60Zc2k8zFxNVQWjcJPkMAr4chNvfc6CEWT+vfe511jxhElxvoxLJYf CUkw== X-Gm-Message-State: AJIora+DsWnifaoYZgK2EdowELmZ3NpNna4Ts428VcyBiQ4q5NMv74ra WGiu02jaylZHpZqEneS8r10= X-Google-Smtp-Source: AGRyM1uIexBXkZ/W8ypkBhJxXAeE7iOOu9zuACRy8RUXHAcGJJt+UJ5KxTBjnCDBBrNIWr41YAr2KQ== X-Received: by 2002:a17:907:9801:b0:72f:1a8d:8dbe with SMTP id ji1-20020a170907980100b0072f1a8d8dbemr15444298ejc.537.1659438467494; Tue, 02 Aug 2022 04:07:47 -0700 (PDT) Received: from gmail.com (84-236-113-167.pool.digikabel.hu. [84.236.113.167]) by smtp.gmail.com with ESMTPSA id ck28-20020a0564021c1c00b0043df40e4cfdsm808114edb.35.2022.08.02.04.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 04:07:46 -0700 (PDT) Date: Tue, 2 Aug 2022 13:07:44 +0200 From: Ingo Molnar To: Siddh Raman Pant Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check Message-ID: References: <20220731160913.632092-1-code@siddh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220731160913.632092-1-code@siddh.me> Cc: Dave Hansen , Peter Zijlstra , x86@kernel.org, linux-kernel , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner , linux-kernel-mentees X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" CiogU2lkZGggUmFtYW4gUGFudCA8Y29kZUBzaWRkaC5tZT4gd3JvdGU6Cgo+IEdDQyB3YXJuaW5n IGxvZzoKPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiAKPiBhcmNoL3g4Ni9tbS9udW1hLmM6IEluIGZ1 bmN0aW9uIOKAmGNwdW1hc2tfb2Zfbm9kZeKAmToKPiBhcmNoL3g4Ni9tbS9udW1hLmM6OTE2OjM5 OiB3YXJuaW5nOiB0aGUgY29tcGFyaXNvbiB3aWxsIGFsd2F5cyBldmFsdWF0ZSBhcyDigJhmYWxz ZeKAmSBmb3IgdGhlIGFkZHJlc3Mgb2Yg4oCYbm9kZV90b19jcHVtYXNrX21hcOKAmSB3aWxsIG5l dmVyIGJlIE5VTEwgWy1XYWRkcmVzc10KPiAgIDkxNiB8ICAgICAgICAgaWYgKG5vZGVfdG9fY3B1 bWFza19tYXBbbm9kZV0gPT0gTlVMTCkgewo+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBefgoKWW91ciBmaXggbWFrZXMgc2Vuc2UgSSBzdXBwb3NlLCBidXQg SSdtIHdvbmRlcmluZyBob3cgdGVzdGluZyBkaWRuJ3QgCnRyaWdnZXIgdGhpcyB3YXJuaW5nLgoK T2ZmLXN0YWNrIGlzbid0IGEgcmFyZSBjb25maWcgb3B0aW9uOgoKICBrZXBsZXI6fi90aXA+IG1h a2UgYWxsbW9kY29uZmlnCiAgIwogICMgTm8gY2hhbmdlIHRvIC5jb25maWcKICAjCiAga2VwbGVy On4vdGlwPiBncmVwIENQVU1BU0tfT0ZGU1RBQ0sgLmNvbmZpZwogIENPTkZJR19DUFVNQVNLX09G RlNUQUNLPXkKICBrZXBsZXI6fi90aXA+IAoKV2hhdCBhbSBJIG1pc3Npbmc/Cgo+IEZpeGVzOiBj MDMyZWY2MGQxYWEgKCJjcHVtYXNrOiBjb252ZXJ0IG5vZGVfdG9fY3B1bWFza19tYXBbXSB0byBj cHVtYXNrX3Zhcl90IikKPiBGaXhlczogZGUyZDk0NDVmMTYyICgieDg2OiBVbmlmeSBub2RlX3Rv X2NwdW1hc2tfbWFwIGhhbmRsaW5nIGJldHdlZW4gMzIgYW5kIDY0Yml0IikKClRoZXNlIGFyZSBh bmNpZW50IGNvbW1pdHMgZnJvbSAyMDA5ICYgMjAxMS4KClRoYW5rcywKCglJbmdvCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWtlcm5lbC1tZW50 ZWVzIG1haWxpbmcgbGlzdApMaW51eC1rZXJuZWwtbWVudGVlc0BsaXN0cy5saW51eGZvdW5kYXRp b24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWtlcm5lbC1tZW50ZWVzCg==