From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Łukasz Bartosik" <lb@semihalf.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
linux-usb@vger.kernel.org, upstream@semihalf.com
Subject: Re: [PATCH v2] thunderbolt: fix PCI device class after powering up
Date: Tue, 2 Aug 2022 16:07:24 +0300 [thread overview]
Message-ID: <YukhjOo4CteuM8q9@lahna> (raw)
In-Reply-To: <CAK8ByeL4AJoXndO02Os0UPYZRiMeLmBjB-00VaEe-8KJF0tWzQ@mail.gmail.com>
On Tue, Aug 02, 2022 at 02:27:30PM +0200, Łukasz Bartosik wrote:
> >
> > Hi,
> >
> > On Fri, Jul 29, 2022 at 11:40:22AM +0200, Łukasz Bartosik wrote:
> > > A thunderbolt
> > > lspci -d 8086:9a1b -vmmknn
> > > Slot: 00:0d.2
> > > Class: System peripheral [0880]
> > > Vendor: Intel Corporation [8086]
> > > Device: Tiger Lake-LP Thunderbolt 4 NHI #0 [9a1b]
> > >
> > > presents itself with PCI class 0x088000 after Chromebook boots.
> > > lspci -s 00:0d.2 -xxx
> > > 00:0d.2 System peripheral: Intel Corporation Tiger Lake-LP Thunderbolt 4
> > > NHI #0 (rev 01)
> > > 00: 86 80 1b 9a 00 00 10 00 01 00 80 08 00 00 00 00
> > > ...
> > >
> > > However after thunderbolt is powered up in nhi_probe()
> > > its class changes to 0x0c0340
> > > lspci -s 00:0d.2 -xxx
> > > 00:0d.2 System peripheral: Intel Corporation Tiger Lake-LP Thunderbolt 4
> > > NHI #0 (rev 01)
> > > 00: 86 80 1b 9a 06 04 10 00 01 40 03 0c 00 00 00 00
> > > ...
> > >
> > > which leaves pci_dev structure with old class value
> > > cat /sys/bus/pci/devices/0000:00:0d.2/class
> > > 0x088000
> >
> > This is completely unexpected. Which Chromebook this is and have you
> > tried to upgrade it to the latest?
> >
>
> This happens on a Tiger Lake based reference Chromebook platform.
> The issue also happens on the latest ChromeOS image available for that platform.
Is this something available for purchase? I'm asking because I have Acer
Tiger Lake based Chromebook (740 spin or something) here and the TBT
controller class is "USB controller" all the time, and this is what is
expected. It should not change the class at any point.
next prev parent reply other threads:[~2022-08-02 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 9:40 [PATCH v2] thunderbolt: fix PCI device class after powering up Łukasz Bartosik
2022-08-01 10:24 ` Mika Westerberg
2022-08-02 12:27 ` Łukasz Bartosik
2022-08-02 13:07 ` Mika Westerberg [this message]
2022-08-02 15:06 ` Łukasz Bartosik
2022-08-03 8:29 ` Mika Westerberg
2022-08-03 9:30 ` Łukasz Bartosik
2022-08-03 9:46 ` Mika Westerberg
2022-08-03 10:41 ` Łukasz Bartosik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YukhjOo4CteuM8q9@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lb@semihalf.com \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.