From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C810AC19F28 for ; Wed, 3 Aug 2022 17:09:26 +0000 (UTC) Received: from localhost ([::1]:44266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJHs5-0006fk-RE for qemu-devel@archiver.kernel.org; Wed, 03 Aug 2022 13:09:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJHqr-0005rL-Do for qemu-devel@nongnu.org; Wed, 03 Aug 2022 13:08:09 -0400 Received: from ams.source.kernel.org ([145.40.68.75]:46918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJHqj-0002Ng-AY for qemu-devel@nongnu.org; Wed, 03 Aug 2022 13:08:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6648EB82312; Wed, 3 Aug 2022 17:07:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA9CEC433C1; Wed, 3 Aug 2022 17:07:56 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="pBziU+8f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1659546475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7scd4vgV8gdI290+pt8Rdim0/nL3yZULyxhxmNrQ1B4=; b=pBziU+8f3Q6qse1ql4lYcUtD3VY7BtK7gpOlRdpvBLMeMTcH+R9BRB0fNh07Bll2hRLLVB uZGVwhgVPIhj9pjVckEqRLB3dFEMyPG+3AL/BnZFpe8G5Ph9vp9CmbMxB8zxLvV5UwtE1+ R0YTCFvC1d8f3fi3OKHGVb7tJfv3tpU= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id fcb12e7d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 3 Aug 2022 17:07:55 +0000 (UTC) Date: Wed, 3 Aug 2022 19:07:52 +0200 From: "Jason A. Donenfeld" To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Xiaoyao Li , Paolo Bonzini , QEMU Developers , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=83=C2=A9?= , Laurent Vivier , "Michael S . Tsirkin" Subject: Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry Message-ID: References: <20220721163621.761513-1-pbonzini@redhat.com> <20220721163621.761513-10-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=145.40.68.75; envelope-from=SRS0=hVua=YH=zx2c4.com=Jason@kernel.org; helo=ams.source.kernel.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote: > On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: > > Thanks for the info. Very helpful. Looking into it now. > > So interestingly, this is not a new issue. If you pass any type of setup > data, OVMF appears to be doing something unusual and passing 0xffffffff > for all the entries, rather than the actual data. The reason this isn't > new is: try passing `-dtb any/dtb/at/all/from/anywhere` and you get the > same page fault, on all QEMU versions. The thing that passes the DTB is > the thing that passes the RNG seed. Same mechanism, same bug. > > I'm looking into it... Fixed with: https://lore.kernel.org/all/20220803170235.1312978-1-Jason@zx2c4.com/ Feel free to join into the discussion there. I CC'd you. Jason