From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.ayax.eu (mx01.ayax.eu [188.137.98.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D466AB1 for ; Thu, 4 Aug 2022 22:23:30 +0000 (UTC) Received: from [192.168.192.146] (port=40640 helo=nx64de-df6d00) by mx01.ayax.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJjFK-0001KU-Aw; Fri, 05 Aug 2022 00:23:14 +0200 Date: Fri, 5 Aug 2022 00:23:12 +0200 From: Grzegorz Szymaszek To: Philipp Hortmann Cc: Larry Finger , Greg KH , Phillip Potter , Grzegorz Szymaszek , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 1/3] staging: r8188eu: set firmware path in a macro Message-ID: Mail-Followup-To: Grzegorz Szymaszek , Philipp Hortmann , Larry Finger , Greg KH , Phillip Potter , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: <6c83e05e5dbccff5630ccfed9e40bf84c889b647.1659565180.git.gszymaszek@short.pl> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wdK8tUR/DAUq3A6F" Content-Disposition: inline In-Reply-To: --wdK8tUR/DAUq3A6F Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 04, 2022 at 10:11:58PM +0200, Philipp Hortmann wrote: > On 8/4/22 00:28, Grzegorz Szymaszek wrote: > > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/stagin= g/r8188eu/os_dep/os_intfs.c > > -%<- > > -MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin"); > > +MODULE_FIRMWARE(FW_RTL8188EU); >=20 >=20 > It failed to apply your patch as the following line: > MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin"); > is not in the repo. Inserted line in my repo to apply patch. I=E2=80=99m sorry, I didn=E2=80=99t add the base tree reference. Right now,= git format-patch generates the following: base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f The prerequisite patch is available at . > Why is the coverletter missing? I didn=E2=80=99t think it would be necessary, since the patches are quite simple and there are just three of them. Again, I=E2=80=99m sorry, I don=E2= =80=99t want to make it harder for anyone to review my patches. Hopefully I will learn more of the kernel development practises without wasting too much time of patch reviewers. Should I send an improved (with the base tree reference and with a short cover letter) patch series? > Tested all three patches. Thanks! --wdK8tUR/DAUq3A6F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEZT55kPBhnB69hD4ZeE9lGUIcpz4FAmLsRtAACgkQeE9lGUIc pz4Peg//URhtbr9bi8fDPTiZ+Y5t5NcBgTyII86gtqFjvtQRDGXzq3MU3ErjxvzO D1NJtIBiF0QPVTlruIqdlN8dM2bY2VD6uKEW/ytZa0mnVVFLjfOjpMyfavXWq8DS aVUF/RCTUhEvhYjabVnXy81hEo3SoSEkSkg3cNyINQDCHy33csELlVEuX/lIHcHx B33aXdqEJboZfNJ23KIjmiXc/TJbHdxquDS1mjYJYSN5OOsM22eHDx0i4je+CX9N u7owII2TN3XLwqUTRINHXVVIZpJKdlCPtFdL9wFWM4bvlaTCNpGozDFk9Rka540J 7g8j/2scF6XuZRxQP+23CPEZieDGXEfD9KT+pDLTO3lD1GRIgQapBRVg41f0ZD97 DOARmeMQ91prmqqtm1eirs3BbruieZ0zTy4PGp3NzYg47wFpxpcMnydvubUADGb5 2Paqm5lmbKNBILPn0jEBJiDPMpT9a9qUGT3V3hNBZXbi3j344HD1Y6R2IVAX8/Kx CUtJ+f4O6A5dXekrgJSKgahO77yG50fA9KsffO/7Z0VnRVZVgsq+DF6oF4/mXCyG nar7bcfFBL2dSw2kdDNTjGwXCj91WE9sbi71qLruLv9DVWZV/sTKpza6AT9qJgc1 rQ8kCVdapDVtNW1jfJJnhhyi6YQkUXGQgzzPrtLxwHRad0mQMyY= =XvEL -----END PGP SIGNATURE----- --wdK8tUR/DAUq3A6F--