From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A903C00140 for ; Fri, 5 Aug 2022 07:16:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240195AbiHEHQb (ORCPT ); Fri, 5 Aug 2022 03:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230441AbiHEHQX (ORCPT ); Fri, 5 Aug 2022 03:16:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9E0F35 for ; Fri, 5 Aug 2022 00:16:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A35DEB827E6 for ; Fri, 5 Aug 2022 07:16:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03770C433C1; Fri, 5 Aug 2022 07:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659683779; bh=pVVmulI7yI4CK6aTV3QyaslBwmz+G2X9eavrx06cU6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jZENF4PlyknV8Xq4eLRWpsaLD7k9DL03M0OnEm0ZgeJCG2e+C6c2FmQkRpGxfhaKN QcI4O9H6v/VteiJjXbPcgf8ZUteF1Qv0r6/R5Y8iJ+y+IxUacyCYxpM4L6pEdheJyU 9xq0FzrcSo8SvSLiEMdcNqpkII2iIX6Y+A6H0vW7mZ9EB/s2rTNECqbaGxsat4r4uF nk2wbd0UxQjqcD+TsL7Jswa/J7rucfCM4L5MNzCtvnB9E/RnyLU1p9FISFrhhF7S9F GiICqKj0QHURF7momLdJtgg3inVCOKbmN7GNhVNHhBWnCAv/sg/ef4t4RuDkLU7Msf m6lC29AsLlR5Q== Date: Fri, 5 Aug 2022 00:16:17 -0700 From: Eric Biggers To: Siddh Raman Pant Cc: Jonathan Corbet , David Howells , Randy Dunlap , Mauro Carvalho Chehab , Christophe JAILLET , Eric Dumazet , linux-kernel , linux-kernel-mentees Subject: Re: [PATCH 0/3] kernel/watch_queue: Clean up some code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2022 at 07:00:21PM +0530, Siddh Raman Pant wrote: > There is a dangling reference to pipe in a watch_queue after clearing it. > Thus, NULL that pointer while clearing. This can be thought of as a v4 of > the patches I had sent earlier. > > This change renders wqueue->defunct superfluous, as the latter is only used > to check if watch_queue is cleared. With this change, the pipe is NULL'd > while clearing, so we can just check if the pipe is NULL. > > Extending comment for watch_queue->pipe in the definition of watch_queue > made the comment conventionally too long (it was already past 80 chars), > so I have changed the struct annotations to be doxygen-styled, so that > I can extend the comment mentioning that the pipe is NULL when watch_queue > is cleared. > > Siddh Raman Pant (3): > kernel/watch_queue: Remove dangling pipe reference while clearing > watch_queue > kernel/watch_queue: Improve struct annotation formatting > kernel/watch_queue: Remove wqueue->defunct and use pipe for clear > check > > include/linux/watch_queue.h | 95 +++++++++++++++++++++++++++---------- > kernel/watch_queue.c | 11 ++--- > 2 files changed, 75 insertions(+), 31 deletions(-) I think patches 1 and 3 should be merged together. Also, please use a consistent version number for all patches in the series. You have a version 1, version 2, and version 4 patch all in the same series, which is very confusing. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A392C00140 for ; Fri, 5 Aug 2022 07:16:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E9C0C40D24; Fri, 5 Aug 2022 07:16:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E9C0C40D24 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jZENF4Pl X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjiVS_IMbcBo; Fri, 5 Aug 2022 07:16:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id ED95E40CC5; Fri, 5 Aug 2022 07:16:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org ED95E40CC5 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C6F6CC0033; Fri, 5 Aug 2022 07:16:25 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4D93CC002D for ; Fri, 5 Aug 2022 07:16:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 151286F936 for ; Fri, 5 Aug 2022 07:16:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 151286F936 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jZENF4Pl X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W_BVYip5WLL4 for ; Fri, 5 Aug 2022 07:16:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3405060E08 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3405060E08 for ; Fri, 5 Aug 2022 07:16:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82D21B8275D; Fri, 5 Aug 2022 07:16:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03770C433C1; Fri, 5 Aug 2022 07:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659683779; bh=pVVmulI7yI4CK6aTV3QyaslBwmz+G2X9eavrx06cU6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jZENF4PlyknV8Xq4eLRWpsaLD7k9DL03M0OnEm0ZgeJCG2e+C6c2FmQkRpGxfhaKN QcI4O9H6v/VteiJjXbPcgf8ZUteF1Qv0r6/R5Y8iJ+y+IxUacyCYxpM4L6pEdheJyU 9xq0FzrcSo8SvSLiEMdcNqpkII2iIX6Y+A6H0vW7mZ9EB/s2rTNECqbaGxsat4r4uF nk2wbd0UxQjqcD+TsL7Jswa/J7rucfCM4L5MNzCtvnB9E/RnyLU1p9FISFrhhF7S9F GiICqKj0QHURF7momLdJtgg3inVCOKbmN7GNhVNHhBWnCAv/sg/ef4t4RuDkLU7Msf m6lC29AsLlR5Q== Date: Fri, 5 Aug 2022 00:16:17 -0700 From: Eric Biggers To: Siddh Raman Pant Subject: Re: [PATCH 0/3] kernel/watch_queue: Clean up some code Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Jonathan Corbet , Randy Dunlap , linux-kernel , David Howells , Eric Dumazet , Christophe JAILLET , Mauro Carvalho Chehab , linux-kernel-mentees X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Aug 04, 2022 at 07:00:21PM +0530, Siddh Raman Pant wrote: > There is a dangling reference to pipe in a watch_queue after clearing it. > Thus, NULL that pointer while clearing. This can be thought of as a v4 of > the patches I had sent earlier. > > This change renders wqueue->defunct superfluous, as the latter is only used > to check if watch_queue is cleared. With this change, the pipe is NULL'd > while clearing, so we can just check if the pipe is NULL. > > Extending comment for watch_queue->pipe in the definition of watch_queue > made the comment conventionally too long (it was already past 80 chars), > so I have changed the struct annotations to be doxygen-styled, so that > I can extend the comment mentioning that the pipe is NULL when watch_queue > is cleared. > > Siddh Raman Pant (3): > kernel/watch_queue: Remove dangling pipe reference while clearing > watch_queue > kernel/watch_queue: Improve struct annotation formatting > kernel/watch_queue: Remove wqueue->defunct and use pipe for clear > check > > include/linux/watch_queue.h | 95 +++++++++++++++++++++++++++---------- > kernel/watch_queue.c | 11 ++--- > 2 files changed, 75 insertions(+), 31 deletions(-) I think patches 1 and 3 should be merged together. Also, please use a consistent version number for all patches in the series. You have a version 1, version 2, and version 4 patch all in the same series, which is very confusing. - Eric _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees