All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ashok Raj <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Ashok Raj" <ashok_raj@linux.intel.com>,
	"X86 ML" <x86@kernel.org>, "Andrew Cooper" <amc96@srcf.net>,
	LKML <linux-kernel@vger.kernel.org>,
	"Ștefan Talpalaru" <stefantalpalaru@yahoo.com>,
	"Ashok Raj" <ashok.raj@intel.com>
Subject: Re: [PATCH] x86/microcode/AMD: Attempt applying on every logical thread
Date: Wed, 17 Aug 2022 20:58:07 +0000	[thread overview]
Message-ID: <Yv1WXxcIXSQ7nMji@araj-dh-work> (raw)
In-Reply-To: <Yv0vu6OqCptK6gc+@zn.tnic>

Hi Boris,

On Wed, Aug 17, 2022 at 08:13:15PM +0200, Borislav Petkov wrote:
> > Do we have a more scalable way to support it today?
> 
> You're not reading my mails. Lemme repeat: microcode loading is a

I do read them, but probably I'm not seeing your perspective. It's
unintentional. 

> dangerous business, especially the late thing. I'm certainly not going
> to expose that to people if there's no merit. The only merit for loading
> the same revision is for testing purposes.

For this specific patch in question, its not for testing though.. Its
required for functional purposes?

> 
> If you're about to test stuff, you can just as well patch the microcode
> loader to do what you want it to, like I just did.

I guess after this patch is merged, you would need no special patches out
of tree. True? I'm sorry if I missed something that is obvious.

apply_mirocode_amd() has no revid checks, and __apply_microcode_amd() has
no revid checks.. 

In effect you can test applying the same microcode over and over again
without having any special patches. 

I thought you could enforce revid only on the primary, and siblings you
can re-apply. 

Will that will satisfy the real need?


Cheers,
Ashok

  reply	other threads:[~2022-08-17 20:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 12:00 [PATCH] x86/microcode/AMD: Attempt applying on every logical thread Borislav Petkov
2022-08-16  9:00 ` Ashok Raj
2022-08-16 12:41   ` Borislav Petkov
2022-08-16 16:51     ` Ashok Raj
2022-08-17 12:12     ` Ashok Raj
2022-08-17 14:23       ` Borislav Petkov
2022-08-17 15:29         ` Ashok Raj
2022-08-17 18:13           ` Borislav Petkov
2022-08-17 20:58             ` Ashok Raj [this message]
2022-08-17 21:56               ` Borislav Petkov
2022-08-18  9:58                 ` Ashok Raj
2022-11-05  3:45                   ` Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv1WXxcIXSQ7nMji@araj-dh-work \
    --to=ashok.raj@intel.com \
    --cc=amc96@srcf.net \
    --cc=ashok_raj@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefantalpalaru@yahoo.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.