From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43430C00140 for ; Fri, 19 Aug 2022 00:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242182AbiHSA2p (ORCPT ); Thu, 18 Aug 2022 20:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiHSA2l (ORCPT ); Thu, 18 Aug 2022 20:28:41 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8A1245993; Thu, 18 Aug 2022 17:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=N9AdnJXVSulV2NDRxSIoMMHkLPmTPUvpjuo4a+Kkp2k=; b=QUwTKFZAPfeDoz5e+6ueTCA8QG j4lLTVjmhipCbrtjz+8lLoowceemkqhSYjEe+hh5YdHCEZrFSoKfL215fPBIrHPJuTOssKXKfnPuD YFRSHPHSNPWbhMu0QVcYf32XVZbdIdK4AvqxKlI3Y9B4MEjJJAQPQWRZI1RGpM2ErMhQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oOpsI-00DrM4-55; Fri, 19 Aug 2022 02:28:34 +0200 Date: Fri, 19 Aug 2022 02:28:34 +0200 From: Andrew Lunn To: Michael Walle Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Jason Cooper , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Message-ID: References: <20220816001026.830127-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816001026.830127-1-michael@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 02:10:24AM +0200, Michael Walle wrote: > Commit 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl > settings") unknowingly broke the serial output on this board. Before > this commit, the pinmux was still configured by the bootloader and the > kernel didn't reconfigured it again. This was an oversight by the > initial board support where the pinmux for the serial line was never > configured by the kernel. But with this commit, the serial line will be > reconfigured to the wrong pins. This is especially confusing, because > the output still works, but the input doesn't. Presumingly, the input is > reconfigured to MPP10, but the output is connected to both MPP11 and > MPP5. > > Override the pinmux in the board device tree. > > Fixes: 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl settings") > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25520C00140 for ; Fri, 19 Aug 2022 00:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fMn2T8aZ3RX+cFFe7GVum4B63nY5ZEUF+iHnAmxZ+Ls=; b=06PrJEsvBO2f91 /V1P0EaO93y//Lg7Xnhii92//isN2qxojejdE2IjkRNP+aKKK+zE9B6Xcyag8DznkCAlVwCMyk0Kw 9qinVp11Uj4p9FwYM37ZnBK7rGDCe+F9EuJCNCviIn2D/9RD/CV4krXIlFPZObRNR/4VOmQd/GD4N cTEgW754Uc42Ou4XYAmJRjf80ma3LGxI/rH2G5BKAYGBPGgX/xQVAK+zCrGSIlYah1cExoyPAQU99 gAtCASFopM22w2tr++Hl95H0MgyRdBFhWNMBSeBkSfQj1V85VazEeruqtnaPYMo4LwnOs+lTzQMws H+lVbdOcxEspiMM4uhoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOpsQ-00C4QI-3J; Fri, 19 Aug 2022 00:28:42 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOpsN-00C4Oa-9g for linux-arm-kernel@lists.infradead.org; Fri, 19 Aug 2022 00:28:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=N9AdnJXVSulV2NDRxSIoMMHkLPmTPUvpjuo4a+Kkp2k=; b=QUwTKFZAPfeDoz5e+6ueTCA8QG j4lLTVjmhipCbrtjz+8lLoowceemkqhSYjEe+hh5YdHCEZrFSoKfL215fPBIrHPJuTOssKXKfnPuD YFRSHPHSNPWbhMu0QVcYf32XVZbdIdK4AvqxKlI3Y9B4MEjJJAQPQWRZI1RGpM2ErMhQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oOpsI-00DrM4-55; Fri, 19 Aug 2022 02:28:34 +0200 Date: Fri, 19 Aug 2022 02:28:34 +0200 From: Andrew Lunn To: Michael Walle Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Jason Cooper , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Message-ID: References: <20220816001026.830127-1-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220816001026.830127-1-michael@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_172839_365954_28DBA1A7 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 16, 2022 at 02:10:24AM +0200, Michael Walle wrote: > Commit 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl > settings") unknowingly broke the serial output on this board. Before > this commit, the pinmux was still configured by the bootloader and the > kernel didn't reconfigured it again. This was an oversight by the > initial board support where the pinmux for the serial line was never > configured by the kernel. But with this commit, the serial line will be > reconfigured to the wrong pins. This is especially confusing, because > the output still works, but the input doesn't. Presumingly, the input is > reconfigured to MPP10, but the output is connected to both MPP11 and > MPP5. > > Override the pinmux in the board device tree. > > Fixes: 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl settings") > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel