From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C009C25B0C for ; Mon, 8 Aug 2022 20:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244406AbiHHUdt (ORCPT ); Mon, 8 Aug 2022 16:33:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244396AbiHHUdj (ORCPT ); Mon, 8 Aug 2022 16:33:39 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA28A1ADAA; Mon, 8 Aug 2022 13:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=y0imL6IC5NO5SCS0xTAMm+Oe4ZYghZ7bwK/Q7XSJbXI=; b=Fr HtMXtf2E/4vJLxwYWM9ljPVsn3HGJvIw4tKnkc7dpn8WJmPorNyHDu1qLyVtw2WpwYffB9REN5jVF 96RF+kOZmDOUlCj2zYXO955eAIkZmKNkQnrea4RKfCZOL1kA84I9CHDqEThAzUzgaE7Vk+fojn8in hTBXObYkC8NCvA4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oL9RK-00ClRp-84; Mon, 08 Aug 2022 22:33:30 +0200 Date: Mon, 8 Aug 2022 22:33:30 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: References: <20220713125644.3117-1-pali@kernel.org> <20220808202456.lpwvhq22edb56ptf@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220808202456.lpwvhq22edb56ptf@pali> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Rohár wrote: > PING? It is too late for the merge window. > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > index 5ce55bdbb995..02ae1e153288 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > @@ -13,7 +13,7 @@ > > > > / { > > model = "Marvell Armada 3720 SoC"; > > - compatible = "marvell,armada3720", "marvell,armada3710"; > > + compatible = "marvell,armada3720", "marvell,armada3700"; Does it make sense to have a compatible here? The board .dts should provide it. And if the board does not provide it, we probably want the board to not boot because it does not have a compatible. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0856C25B08 for ; Mon, 8 Aug 2022 20:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bBeCKeJfeQUaEiUzGLnOdGmzzezuYXr9efnodEJoNJ8=; b=pdN/bEXNxrVvyq h8lWR+iV7qgNIpU6NAOhYNsstKUczwc7I/49N3lZ3XKZPJo9UTu+nKmFvdy93e6eXuPBlPuFFDHgS xPZKmhkAQh7OUTeme3UWtPJGxvL1iJvbxuQ9yzVwRA1qn3PU3W9nma7nz7hCNi4CGVa5MXYL9Vx8n +wuupno8WETf1U8ppOjbUFCqUzg66wT07fswLOveJz1Q9Znqwj3BzLAmGTyLyD7Pf+yUxleWBi+Wv SubCHO5yGxFDk7j2KsTAnFDnVcC1KZolz+n+vJaZXo1J/ZorkdpO2SMzAo2cJaAekCEdYu4cJf7ic NY5PhYvog8ahW5InskoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL9RS-00Fwg7-Mm; Mon, 08 Aug 2022 20:33:38 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL9RP-00Fwdn-GR for linux-arm-kernel@lists.infradead.org; Mon, 08 Aug 2022 20:33:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=y0imL6IC5NO5SCS0xTAMm+Oe4ZYghZ7bwK/Q7XSJbXI=; b=Fr HtMXtf2E/4vJLxwYWM9ljPVsn3HGJvIw4tKnkc7dpn8WJmPorNyHDu1qLyVtw2WpwYffB9REN5jVF 96RF+kOZmDOUlCj2zYXO955eAIkZmKNkQnrea4RKfCZOL1kA84I9CHDqEThAzUzgaE7Vk+fojn8in hTBXObYkC8NCvA4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oL9RK-00ClRp-84; Mon, 08 Aug 2022 22:33:30 +0200 Date: Mon, 8 Aug 2022 22:33:30 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: References: <20220713125644.3117-1-pali@kernel.org> <20220808202456.lpwvhq22edb56ptf@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220808202456.lpwvhq22edb56ptf@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220808_133335_589080_B58FB629 X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Roh=E1r wrote: > PING? It is too late for the merge window. > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/= boot/dts/marvell/armada-372x.dtsi > > index 5ce55bdbb995..02ae1e153288 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > @@ -13,7 +13,7 @@ > > = > > / { > > model =3D "Marvell Armada 3720 SoC"; > > - compatible =3D "marvell,armada3720", "marvell,armada3710"; > > + compatible =3D "marvell,armada3720", "marvell,armada3700"; Does it make sense to have a compatible here? The board .dts should provide it. And if the board does not provide it, we probably want the board to not boot because it does not have a compatible. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel