From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A63AC25B08 for ; Tue, 9 Aug 2022 19:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mThQHJRc7Mt8VyzKy3wnifGdxOlZvw3jqsExrC+5Nyg=; b=lg1Mw8nsRva32J kDhRnDFDmiIjspRKQIThNlnk4e5tErHHaX33ayuVzDjhHsScPEltmmHgRwE8dMdN501GckMPRYb4z FIUzFf9/Z5Upm3wjcKRfmdPabGdK1xA1agLLeMROS/WSg/o0t+II8KzLIClKfO05f+7FYg0T5eo8q FEpgHklXZj56Fhi223rbssBYJgrhZNE6TiSxz7Tq1lzeZliyg0ZRBjcRdt2ZPCbHe601BenIUfxw7 2XzQT8rmreYnr3AeSzZTXJSTpALIe9s6oOnzq7d2CVgfUMKtWA8H2WNGLqWgnBTw9S5ndWkg0EZcg bTHeUyRlabPpDoCPeb5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLV6W-005wV7-Nm; Tue, 09 Aug 2022 19:41:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLV6U-005wUE-IC for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Aug 2022 19:41:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xhGt2j49zfW+gyglDqEfT0kukIVZDiWGzC4RxG78mkA=; b=gKX78ofPHjYnmltbtL6k95CzV2 yr+634nbxiLa+OXBwtlWYlR0HauF1amIzfA+2Lh7Cw6zeFcrboEZgh2FlEFtn/8heNGJsEMM4HLgG FR89++i1RYUjDp9KmQKz685G4FMQ3BS5/BPQImw1SHuFjy6yCu+LpYOUMIirewKT3Fkx8hBISVVBC gqIGsJnus2SnHPgRy0cluIgTRwaA1aTOdWYc574Hl2aYWu0nOCYyPK+NcNNnRgGkVKooNxHFxh3zD tIxZj1hfzrUbLQFrcdSQYEuPAiBwq4yRf/w6phyKcw2SEifznwclG96dkGv1g+a1ccyyEtTrbeBB8 w/PV45WQ==; Received: from [187.19.239.32] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLV6T-00Fn07-1G; Tue, 09 Aug 2022 19:41:25 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D7F5F4035A; Tue, 9 Aug 2022 16:41:21 -0300 (-03) Date: Tue, 9 Aug 2022 16:41:21 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v4 00/17] Compress the pmu_event tables Message-ID: References: <20220804221816.1802790-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Aug 09, 2022 at 04:40:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Aug 04, 2022 at 03:17:59PM -0700, Ian Rogers escreveu: > > jevents.py creates a number of large arrays from the json events. The > > arrays contain pointers to strings that need relocating. The > > relocations have file size, run time and memory costs. These changes > > refactor the pmu_events API so that the storage of the pmu_event > > struct isn't exposed. The format is then changed to an offset within a > > combined big string, with adjacent pmu_event struct variables being > > next to each other in the string separated by \0 - meaning only the > > first variable of the struct needs its offset recording. > > > > Some related fixes are contained with the patches. The architecture > > jevents.py creates tables for can now be set by the JEVENTS_ARCH make > > variable, with a new 'all' that generates the events and metrics for > > all architectures. > > > > An example of the improvement to the file size on x86 is: > > no jevents - the same 19,788,464bytes > > x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes > > all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes > > default build options plus NO_LIBBFD=1. > > Applied the first four patches, waiting for the review comments to be Sorry, three. > discussed. > > - Arnaldo > > > I originally suggested fixing this problem in: > > https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ > > > > v4. Fixed an issue with the empty-pmu-events.c spotted by John Garry > > . > > v3. Fix an ARM build issue with a missed weak symbol. Perform some > > pytype clean up. > > v2. Split the substring folding optimization to its own patch and > > comment tweaks as suggested by Namhyung Kim > > . Recompute the file size savings with the > > latest json events and metrics. > > > > Ian Rogers (17): > > perf jevents: Clean up pytype warnings > > perf jevents: Simplify generation of C-string > > perf jevents: Add JEVENTS_ARCH make option > > perf jevent: Add an 'all' architecture argument > > perf jevents: Remove the type/version variables > > perf jevents: Provide path to json file on error > > perf jevents: Sort json files entries > > perf pmu-events: Hide pmu_sys_event_tables > > perf pmu-events: Avoid passing pmu_events_map > > perf pmu-events: Hide pmu_events_map > > perf test: Use full metric resolution > > perf pmu-events: Move test events/metrics to json > > perf pmu-events: Don't assume pmu_event is an array > > perf pmu-events: Hide the pmu_events > > perf metrics: Copy entire pmu_event in find metric > > perf jevents: Compress the pmu_events_table > > perf jevents: Fold strings optimization > > > > tools/perf/arch/arm64/util/pmu.c | 4 +- > > tools/perf/pmu-events/Build | 6 +- > > .../arch/test/test_soc/cpu/metrics.json | 64 +++ > > tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- > > tools/perf/pmu-events/jevents.py | 495 ++++++++++++++---- > > tools/perf/pmu-events/pmu-events.h | 40 +- > > tools/perf/tests/expand-cgroup.c | 25 +- > > tools/perf/tests/parse-metric.c | 77 +-- > > tools/perf/tests/pmu-events.c | 466 +++++++---------- > > tools/perf/util/metricgroup.c | 275 ++++++---- > > tools/perf/util/metricgroup.h | 5 +- > > tools/perf/util/pmu.c | 139 ++--- > > tools/perf/util/pmu.h | 8 +- > > tools/perf/util/s390-sample-raw.c | 50 +- > > 14 files changed, 1140 insertions(+), 718 deletions(-) > > create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json > > > > -- > > 2.37.1.559.g78731f0fdb-goog > > -- > > - Arnaldo -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E11BC19F2D for ; Tue, 9 Aug 2022 19:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344296AbiHITm3 (ORCPT ); Tue, 9 Aug 2022 15:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345523AbiHITl2 (ORCPT ); Tue, 9 Aug 2022 15:41:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED3B926123; Tue, 9 Aug 2022 12:41:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99681B81722; Tue, 9 Aug 2022 19:41:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B0F9C433C1; Tue, 9 Aug 2022 19:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660074084; bh=GHYGwrxzX+i9fEuX4r7SaLl3zG9nc0dhpl+lCqTUIKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S2/1o8+OywaH2dMTTfAGd+oCnMXOno/Fg4UZfgTohZPG/wHG03XDiDlNa4rgwcGoO GGQSVdqFc4gCM6mVVpQfv9j5DR5vnPNx1pwRSc/gBN1gJevRVEzNtiJdskhNuixRhm +NsubomEGrZT/tYP/9TNUJaRCLS183NjRJTnQjJvDNilE8EXYtX+NIgnNMyazj8cYg raIkuYOqZtFpgFTODF6ElHhZTyWHpzSURhCI5361dj1R7eA6rJsdEEyd9n2LdglZaj JTFUjNiSuXFSqPRvww0VlKKljDc10Qtq3jqkz8VLi9jcEJtG+bnZh9dIBKpzU2FuAN YBpGTUI53kbQA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D7F5F4035A; Tue, 9 Aug 2022 16:41:21 -0300 (-03) Date: Tue, 9 Aug 2022 16:41:21 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v4 00/17] Compress the pmu_event tables Message-ID: References: <20220804221816.1802790-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 09, 2022 at 04:40:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Aug 04, 2022 at 03:17:59PM -0700, Ian Rogers escreveu: > > jevents.py creates a number of large arrays from the json events. The > > arrays contain pointers to strings that need relocating. The > > relocations have file size, run time and memory costs. These changes > > refactor the pmu_events API so that the storage of the pmu_event > > struct isn't exposed. The format is then changed to an offset within a > > combined big string, with adjacent pmu_event struct variables being > > next to each other in the string separated by \0 - meaning only the > > first variable of the struct needs its offset recording. > > > > Some related fixes are contained with the patches. The architecture > > jevents.py creates tables for can now be set by the JEVENTS_ARCH make > > variable, with a new 'all' that generates the events and metrics for > > all architectures. > > > > An example of the improvement to the file size on x86 is: > > no jevents - the same 19,788,464bytes > > x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes > > all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes > > default build options plus NO_LIBBFD=1. > > Applied the first four patches, waiting for the review comments to be Sorry, three. > discussed. > > - Arnaldo > > > I originally suggested fixing this problem in: > > https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ > > > > v4. Fixed an issue with the empty-pmu-events.c spotted by John Garry > > . > > v3. Fix an ARM build issue with a missed weak symbol. Perform some > > pytype clean up. > > v2. Split the substring folding optimization to its own patch and > > comment tweaks as suggested by Namhyung Kim > > . Recompute the file size savings with the > > latest json events and metrics. > > > > Ian Rogers (17): > > perf jevents: Clean up pytype warnings > > perf jevents: Simplify generation of C-string > > perf jevents: Add JEVENTS_ARCH make option > > perf jevent: Add an 'all' architecture argument > > perf jevents: Remove the type/version variables > > perf jevents: Provide path to json file on error > > perf jevents: Sort json files entries > > perf pmu-events: Hide pmu_sys_event_tables > > perf pmu-events: Avoid passing pmu_events_map > > perf pmu-events: Hide pmu_events_map > > perf test: Use full metric resolution > > perf pmu-events: Move test events/metrics to json > > perf pmu-events: Don't assume pmu_event is an array > > perf pmu-events: Hide the pmu_events > > perf metrics: Copy entire pmu_event in find metric > > perf jevents: Compress the pmu_events_table > > perf jevents: Fold strings optimization > > > > tools/perf/arch/arm64/util/pmu.c | 4 +- > > tools/perf/pmu-events/Build | 6 +- > > .../arch/test/test_soc/cpu/metrics.json | 64 +++ > > tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- > > tools/perf/pmu-events/jevents.py | 495 ++++++++++++++---- > > tools/perf/pmu-events/pmu-events.h | 40 +- > > tools/perf/tests/expand-cgroup.c | 25 +- > > tools/perf/tests/parse-metric.c | 77 +-- > > tools/perf/tests/pmu-events.c | 466 +++++++---------- > > tools/perf/util/metricgroup.c | 275 ++++++---- > > tools/perf/util/metricgroup.h | 5 +- > > tools/perf/util/pmu.c | 139 ++--- > > tools/perf/util/pmu.h | 8 +- > > tools/perf/util/s390-sample-raw.c | 50 +- > > 14 files changed, 1140 insertions(+), 718 deletions(-) > > create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json > > > > -- > > 2.37.1.559.g78731f0fdb-goog > > -- > > - Arnaldo -- - Arnaldo