From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6665AC19F2D for ; Tue, 9 Aug 2022 16:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244987AbiHIQUr (ORCPT ); Tue, 9 Aug 2022 12:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245016AbiHIQUh (ORCPT ); Tue, 9 Aug 2022 12:20:37 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A1920F68 for ; Tue, 9 Aug 2022 09:20:30 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id m7so9059627qkk.6 for ; Tue, 09 Aug 2022 09:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=PG/NzpP7dxYgSbT1VGhdPEfvsq4XeuSudB3XVxm5vho=; b=UWFcTHBG5hnvXz+bOhhIMs+36qXUs7LS+bm8wscLrUKvkhW1PkrqNEt32SN2Ch60WF 45OX0C7T/Y90O6bR2Zck7kKcRKlCcOkgGVzLxYzDIzlMam5/9vHVAZJ5lY0IqoikggDC l6VQInX5RJyUjG5en0AgacfSSw/Rk33TfBuyFsDlJytpV4hvFFxhTKyoRwWRne3gTaME z0+/6y5mfgFBof4NsOgQGkXMqGfmPgB4+qLmK37PVJ6429s5c58JSUsZjp7umaYRteAq vDQoE7TsoLnx7Ne9/uVXyooRLvvPCqsigtYXXv7GIh1oYg2KvI6GyumvSHY+URTg8WJ0 YkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=PG/NzpP7dxYgSbT1VGhdPEfvsq4XeuSudB3XVxm5vho=; b=bUCZSvZud4L2BP0rvvWJt1DbsMayBiGGiFl4rSLL4hj8bWofvXuarmQu+bTJ+nStvO C9tWW9xr2O67r2R06OYdkRZxweogiv3ZxsN/pXn+u9TkWLft8RhwQeAXDg/pdDmLVJko /Yudzt9TlE7nn/GdcU0M/Ux5VyLqlvBXZBRdu7Slq9e43CJcM3JE4a/U3nyQMKCL1wM0 r237yIrE4vHX/XyBXJsLLDiIus2d9auSyPVgPs/AkulGMvrT+/BA8oOCAmHNegBtrJrr 40p5BwFGqW4vkhbi3SeZ1StUxzoScXAtMR/jZD5V+I1mSwAsucVdqzRTRlwPiviOG6tA fZOw== X-Gm-Message-State: ACgBeo1ujmy+uW/ZzvvkNJqaN3JYx62+OxXhGqFFiW1uzOjyXe3Tfruf I3eRiwITlJ+6vvhxA8Nvoqsbag== X-Google-Smtp-Source: AA6agR6XqzWz63ok/9lDp5yv2YzmPFN9jxiX+xJ5eurZ4xCN2N8OROoNYGECiJqBxHp+LSIjMnnimw== X-Received: by 2002:a05:620a:2947:b0:6b9:6fa7:abd1 with SMTP id n7-20020a05620a294700b006b96fa7abd1mr4589260qkp.202.1660062029646; Tue, 09 Aug 2022 09:20:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id h126-20020a375384000000b006b5cb0c512asm11261863qkb.101.2022.08.09.09.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 09:20:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oLRy0-0067SD-2f; Tue, 09 Aug 2022 13:20:28 -0300 Date: Tue, 9 Aug 2022 13:20:28 -0300 From: Jason Gunthorpe To: Christophe JAILLET Cc: Diana Craciun , Alex Williamson , Cornelia Huck , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] vfio/fsl-mc: Fix a typo in a comment Message-ID: References: <2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 06, 2022 at 09:56:13PM +0200, Christophe JAILLET wrote: > L and S are swapped/ > s/VFIO_FLS_MC/VFIO_FSL_MC/ > > Signed-off-by: Christophe JAILLET > --- > All the dev_ logging functions in the file have the "VFIO_FSL_MC: " > prefix. > As they are dev_ function, the driver should already be displayed. > > So, does it make sense or could they be all removed? > --- > drivers/vfio/fsl-mc/vfio_fsl_mc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > index 3feff729f3ce..66d01db1d240 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > @@ -110,7 +110,7 @@ static void vfio_fsl_mc_close_device(struct vfio_device *core_vdev) > > if (WARN_ON(ret)) > dev_warn(&mc_cont->dev, > - "VFIO_FLS_MC: reset device has failed (%d)\n", ret); > + "VFIO_FSL_MC: reset device has failed (%d)\n", ret); WARN_ON already prints, this is better written as WARN(ret, "VFIO_FSL_MC: reset device has failed (%d)\n", ret); Jason