Re: [PATCH v2] driver core: Fix bus_type.match() error handling

From: Isaac Manjarres <isaacmanjarres@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Saravana Kannan <saravanak@google.com>,
	stable@kernel.org, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] driver core: Fix bus_type.match() error handling
Date: Mon, 15 Aug 2022 22:17:23 -0700	[thread overview]
Message-ID: <YvsoYzIhOtX9DOi2@google.com> (raw)
In-Reply-To: <20220816042507.GB1108868@roeck-us.net>

On Mon, Aug 15, 2022 at 09:25:07PM -0700, Guenter Roeck wrote:
> > v1 -> v2:
> > - Fixed the logic in __driver_attach() to allow a driver to continue
> >   attempting to match and bind with devices in case of any error, not
> >   just probe deferral.
> > 
> > Guenter,
> > 
> > Can you please give test this patch to make sure it still works for you?
> > 
> 
> Not as well as v1. I still see the clk crash with versatileab, and imx25-pdk
> emulations now stall during boot when trying to boot from usb.
> 
> Guenter
Thanks for trying the patch out. This patch isn't meant to fix the clk
crash that you mentioned on another thread. I had made the following patch for
that: https://lore.kernel.org/lkml/YvqTvuqSll30Rv2k@google.com/. Have
you been able to give that a shot yet? If not can you please test with the
patch in this e-mail and that patch?

Please make sure you do not include this patch as it is known to cause
deadlocks: https://lore.kernel.org/lkml/YvXhJRlHN9OAIA5l@google.com/.

Did you test imx25-pdk emulations with just v1 of this patch previously?

Thanks,
Isaac