From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9188C25B0E for ; Tue, 16 Aug 2022 15:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FHrJsrHytMJe0AdVE7BUkQ52RUnaGGX+7Zxy771x+n4=; b=1Ssr7Qstsd5c0x oO616nvcrT6uSBi6VA3179LdbhjADCfRVqhRpnoWif+SOqnfTX78RlmbWUHCXu7Zd8HGS8a/I71he PpXQod2wTsNrstGUWoyPjK8qZP99YJ41ek8kffX+tC2X13PTUFjMEOZx3k5ICZQT1zqeShGqjBoFd YDpXajiNMP5kMRtzD7Af4iX2VwndihGhAVIU8xDj1PqR8YTxIhlNhGpdVyYcFru4ZcCEU7nrPhtpo hfuk47er4QPbV/6YxtJ9GRFriDb6EWP1eJ3ww1B7/f8QBLUnjlkZVCuYK/QnhdydUWON1LIH4TZSx LNo4rKQOC7DqBX6gHZjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNysU-004BwB-V6; Tue, 16 Aug 2022 15:53:15 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNysQ-004BuE-SI for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 15:53:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7FC89B8188C; Tue, 16 Aug 2022 15:53:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C1ABC433D6; Tue, 16 Aug 2022 15:53:06 +0000 (UTC) Date: Tue, 16 Aug 2022 16:53:02 +0100 From: Catalin Marinas To: Marco Elver Cc: Will Deacon , Yee Lee =?utf-8?B?KOadjuW7uuiqvCk=?= , "akpm@linux-foundation.org" , Max Schulze , "linux-arm-kernel@lists.infradead.org" , "naush@raspberrypi.com" , "glider@google.com" , "dvyukov@google.com" , "kasan-dev@googlegroups.com" Subject: Re: kmemleak: Cannot insert 0xffffff806e24f000 into the object search tree (overlaps existing) [RPi CM4] Message-ID: References: <20220815124705.GA9950@willie-the-truck> <20220816142628.GA11512@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_085311_098970_F583C049 X-CRM114-Status: GOOD ( 22.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 16, 2022 at 05:46:43PM +0200, Marco Elver wrote: > On Tue, 16 Aug 2022 at 17:32, Catalin Marinas wrote: > [...] > > > Right, looks like the kfence fix didn't need to be in 5.19. In any > > > case, this patch I just sent: > > > > > > https://lore.kernel.org/all/20220816142529.1919543-1-elver@google.com/ > > > > > > fixes the issue for 5.19 as well, because memblock has always used > > > kmemleak's kmemleak_*_phys() API and technically we should free it > > > through phys as well. > > > > > > As far as I can tell, that's also the right thing to do in 6.0-rc1 > > > with 0c24e061196c2, because we have the slab post-alloc hooks that > > > want to register kfence objects via kmemleak. Unless of course somehow > > > both "ignore" and "free" works, but "ignore" just sounds wrong in this > > > case. Any thoughts? [...] > > In general, if an object is allocated and never freed, > > kmemleak_ignore*() is more appropriate, so I'm more inclined to only > > send your kmemleak_free_part_phys() fix to 5.19.x rather than mainline. > > So it sounds like we should just ask stable to revert 07313a2b29ed > then, if the patch switching to kmemleak_free_part_phys() should not > go to 6.0. Is that the most reasonable option? If so, I'll go ahead > and send stable the email to do so. Yes, I think the revert is probably better. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel