Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Aug 30, 2022 at 07:57:15AM +0000, Murthy, Arun R wrote:
> > > > > > > Intel Gen do support Async Flip is supported on linear buffers.
> > > > > > > Since we didn't had a use case, it was not enabled. Now that
> > > > > > > as part of hybrid graphics for unsupported hardware pixel
> > > > > > > formats, its being converted to linear memory and then flipped,
> > hence enabling!
> > > > > > > This patch enables support for async on linear buffer.
> > > > > > >
> > > > > > > v2: added use case
> > > > > > > v3: enabled async on linear for pre Gen 12 as well
> > > > > >
> > > > > > I didn't think it went all the way back to gen9?
> > > > > >
> > > > > It's the same as other buffers. I have just added support for
> > > > > linear buffer in
> > > > the present async flip path, so the platforms on which the async
> > > > flip is supported will support linear buffer as well.
> > > >
> > > > I know what the patch does. But I don't think bspec agrees with it.
> > > >
> > > I initially had this async on linear buffer support from Gen12 onwards. Will
> > add that check back.
> > 
> > We're just going in circles here. What I've asked repeatedly is actual
> > justification for whatever gen check or no gen check there is. Ie. please
> > *read* the bspec and include the appropriate information in the patch.
> > Otherwise there is no point in me even looking at these patches anymore.
> > 
> Per the BSpec async on Linear is not supported on Pre Gen 12.

Where in bspec does it say that?

> 
> > >
> > > > >
> > > > > > Also we still don't seem to have any tests for this stuff...
> > > > >
> > > > > There is an IGT patch in queue, once this patch is merged, the IGT
> > > > > patch will
> > > > be floated.
> > > >
> > > > Do the igt stuff first. Then you can at least get some CI results for this
> > stuff.
> > > >
> > > IGT has be floated. https://patchwork.freedesktop.org/series/107871/
> > >
> 
> Thanks and Regards,
> Arun R Murthy
> --------------------

-- 
Ville Syrjälä
Intel