From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546B8C00140 for ; Sun, 21 Aug 2022 08:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiHUIxi (ORCPT ); Sun, 21 Aug 2022 04:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbiHUIxh (ORCPT ); Sun, 21 Aug 2022 04:53:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AAB51C104; Sun, 21 Aug 2022 01:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZG4Es9fzRMT5wrH3Tq+h9KlclsxiCzHKQ6STwuA6oEY=; b=NPTUpR2TGbEGKev6MERMWxooFG ZiJJjPsPAHnqBUcO2CFAj6Vu6hAc3j5M6DeVz3k2hJd7xxalHutHctTFyvYAhRSiMuYQzdMYaAa9k WBNgoPSU6TF4upc7I+yWqXWo+afkfRMrrsiTEmeBXwGm9kKSvw1mY2HuqMGQj1ybZWFBcviB7t/Jx CNZtj16845VF1Evf0T8Auz57FsdmXm7IQcRaeQn96X3j+ZSDhD8Nyc4APtWOwsUqG0QARrCSLeVgb xIMkJ0036ubpmdQL4mSj6MNnxsleHp2IQ98hONYLivxszc2hcm0EoaksqSX32ZF8ehDAQbYS5mLFa jLqkzAsg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPgi5-008Q9X-HL; Sun, 21 Aug 2022 08:53:33 +0000 Date: Sun, 21 Aug 2022 01:53:33 -0700 From: Christoph Hellwig To: Eric Biggers Cc: Jaegeuk Kim , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-api@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Keith Busch Subject: Re: [PATCH v4 6/9] f2fs: don't allow DIO reads but not DIO writes Message-ID: References: <20220722071228.146690-1-ebiggers@kernel.org> <20220722071228.146690-7-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Mon, Aug 15, 2022 at 05:55:45PM -0700, Eric Biggers wrote: > So if the zoned device feature becomes widely adopted, then STATX_DIOALIGN will > be useless on all Android devices? That sounds undesirable. Are you sure that We just need to fix f2fs to support direct I/O on zone devices. There is not good reason not to support it, in fact the way how zoned devices requires appends with the Zone Append semantics makes direct I/O way safer than how f2fs does direct I/O currently on non-zoned devices. Until then just supporting direct I/O reads on zoned devices for f2fs seems like a really bad choice given that it will lead to nasty cache incoherency. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 325DDC00140 for ; Sun, 21 Aug 2022 08:53:53 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oPgiL-00081L-Ve; Sun, 21 Aug 2022 08:53:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oPgiK-00081B-8Y for linux-f2fs-devel@lists.sourceforge.net; Sun, 21 Aug 2022 08:53:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZG4Es9fzRMT5wrH3Tq+h9KlclsxiCzHKQ6STwuA6oEY=; b=DvYGYYdIGxbd8OuixTfg2L1co3 PkqHJeUFc1x4lzcNq0x2+0fRWsb/TYocxOhAHVkXOsON251NA7nBGxbyyzSqcgElVPADFbUev2z4/ 3oMmTcmz4N+8T72pd/n1JUN2tQwxOthoph4N82eRapiw5YJYZ2gNO7KtnbWzgnrVJ4HQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZG4Es9fzRMT5wrH3Tq+h9KlclsxiCzHKQ6STwuA6oEY=; b=P2ZFvlWLOTnrevaaYQLZi2SpTn MMi4RN08UimJjMSsml7925OSyrzw5zDev/e7XwZIda8pe+p/38+iiB4EXzOBTZWjubpbTqC2i5cpq DnrYBjH9kBhldYiSxUi+eqKkh4B/1TCwP4e0GL+1nEtbdRl72FEXadit0VVeJ41es3lg=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oPgiI-00Bhu8-54 for linux-f2fs-devel@lists.sourceforge.net; Sun, 21 Aug 2022 08:53:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZG4Es9fzRMT5wrH3Tq+h9KlclsxiCzHKQ6STwuA6oEY=; b=NPTUpR2TGbEGKev6MERMWxooFG ZiJJjPsPAHnqBUcO2CFAj6Vu6hAc3j5M6DeVz3k2hJd7xxalHutHctTFyvYAhRSiMuYQzdMYaAa9k WBNgoPSU6TF4upc7I+yWqXWo+afkfRMrrsiTEmeBXwGm9kKSvw1mY2HuqMGQj1ybZWFBcviB7t/Jx CNZtj16845VF1Evf0T8Auz57FsdmXm7IQcRaeQn96X3j+ZSDhD8Nyc4APtWOwsUqG0QARrCSLeVgb xIMkJ0036ubpmdQL4mSj6MNnxsleHp2IQ98hONYLivxszc2hcm0EoaksqSX32ZF8ehDAQbYS5mLFa jLqkzAsg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPgi5-008Q9X-HL; Sun, 21 Aug 2022 08:53:33 +0000 Date: Sun, 21 Aug 2022 01:53:33 -0700 From: Christoph Hellwig To: Eric Biggers Message-ID: References: <20220722071228.146690-1-ebiggers@kernel.org> <20220722071228.146690-7-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1oPgiI-00Bhu8-54 Subject: Re: [f2fs-dev] [PATCH v4 6/9] f2fs: don't allow DIO reads but not DIO writes X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Keith Busch , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Aug 15, 2022 at 05:55:45PM -0700, Eric Biggers wrote: > So if the zoned device feature becomes widely adopted, then STATX_DIOALIGN will > be useless on all Android devices? That sounds undesirable. Are you sure that We just need to fix f2fs to support direct I/O on zone devices. There is not good reason not to support it, in fact the way how zoned devices requires appends with the Zone Append semantics makes direct I/O way safer than how f2fs does direct I/O currently on non-zoned devices. Until then just supporting direct I/O reads on zoned devices for f2fs seems like a really bad choice given that it will lead to nasty cache incoherency. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel