Re: FAILED: patch "[PATCH] pinctrl: amd: Don't save/restore interrupt status and wake" failed to apply to 5.10-stable tree

From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Natikar, Basavaraj" <Basavaraj.Natikar@amd.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Subject: Re: FAILED: patch "[PATCH] pinctrl: amd: Don't save/restore interrupt status and wake" failed to apply to 5.10-stable tree
Date: Wed, 24 Aug 2022 14:14:24 +0200	[thread overview]
Message-ID: <YwYWIKtSpT+XUYQ7@kroah.com> (raw)
In-Reply-To: <6ce41d24-5eed-5ffc-d4ee-3dd702833347@amd.com>

On Wed, Aug 24, 2022 at 07:05:25AM -0500, Mario Limonciello wrote:
> On 8/24/22 01:54, gregkh@linuxfoundation.org wrote:
> > On Tue, Aug 23, 2022 at 08:36:20PM +0000, Limonciello, Mario wrote:
> > > [Public]
> > > 
> > > > -----Original Message-----
> > > > From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>
> > > > Sent: Monday, August 22, 2022 03:42
> > > > To: Natikar, Basavaraj <Basavaraj.Natikar@amd.com>;
> > > > linus.walleij@linaro.org; Limonciello, Mario <Mario.Limonciello@amd.com>
> > > > Cc: stable@vger.kernel.org
> > > > Subject: FAILED: patch "[PATCH] pinctrl: amd: Don't save/restore interrupt
> > > > status and wake" failed to apply to 5.10-stable tree
> > > > 
> > > > 
> > > > The patch below does not apply to the 5.10-stable tree.
> > > > If someone wants it applied there, or to any other stable or longterm
> > > > tree, then please email the backport, including the original git commit
> > > > id to <stable@vger.kernel.org>.
> > > 
> > > I had a look at this and the other ones that failed to apply.  I tried to apply this commit
> > > ( commit b8c824a869f220c6b46df724f85794349bafbf23 ) to all of them and then built it.
> > > 
> > > 5.10.y: success
> > 
> > $ patch -p1 < ../pinctrl-amd-don-t-save-restore-interrupt-status-and-wake-status-bits.patch
> > patching file drivers/pinctrl/pinctrl-amd.c
> > Hunk #1 succeeded at 833 (offset -85 lines).
> > Hunk #2 FAILED at 927.
> > Hunk #3 FAILED at 937.
> > Hunk #4 succeeded at 842 (offset -103 lines).
> > 2 out of 4 hunks FAILED -- saving rejects to file drivers/pinctrl/pinctrl-amd.c.rej
> > 
> > Doesn't work for me, how did you apply it?
> 
> I checked out the different branches mentioned and did "git cherry-pick -x
> b8c824a869f220c6b46df724f85794349bafbf23" followed by building.

That's great, can you send me that patch?  We don't use git for the
stable queue as it does not work at all for our development workflow.
We export the commits as patches and then apply them using quilt.  git
must be doing some "magic fuzzing" here that patch can not detect.

thanks,

greg k-h