From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22AF7C00140 for ; Wed, 24 Aug 2022 15:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237421AbiHXP4Y (ORCPT ); Wed, 24 Aug 2022 11:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238135AbiHXP4S (ORCPT ); Wed, 24 Aug 2022 11:56:18 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F53E79EEB for ; Wed, 24 Aug 2022 08:56:17 -0700 (PDT) Received: from zn.tnic (p200300ea971b9859329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:9859:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D758F1EC056A; Wed, 24 Aug 2022 17:56:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1661356571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=597nyabWH/euYfInu4TMyRneXI4eRxz/mWO4MBAwbZ8=; b=fE79Ej2xuWRrdBwqklqQS5kNxmPtqQgtbTrRQLfv5+kxBWWYRidPpdEGY2YnmAiC68DQ+2 ya/Qvw3mPXX1ha8+f6y6knjGI3pV19lmrdLauNA6NiZftztNnNfDp8+3A2NYy6gygyY+JP KWpTdAjoeZ2ystCgn+CQ8QkDCqiZSwo= Date: Wed, 24 Aug 2022 17:56:11 +0200 From: Borislav Petkov To: Sathyanarayanan Kuppuswamy Cc: Dave Hansen , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver Message-ID: References: <20220728034420.648314-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220728034420.648314-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20abfa00-b70c-f151-9ee4-5668f09f4ace@intel.com> <08c5b818-a030-4c97-80f7-52ee42dc1f79@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <08c5b818-a030-4c97-80f7-52ee42dc1f79@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2022 at 03:41:00PM -0700, Sathyanarayanan Kuppuswamy wrote: > In addition to above, I think there is a possibility to add IOCTL to get > storage keys from the ACPI SVKL table. Storage Volume Key Table (SVKL) is > used by the VBIOS to share keys required to access encrypted drives. Although > we don't have a clear requirement, I suspect that we might add IOCTL for it. So this all sounds like a single tdx-guest driver to me which services a bunch of ioctls... not separate drivers. Hmm? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette