From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6CAC04AA5 for ; Thu, 25 Aug 2022 00:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbiHYAQs (ORCPT ); Wed, 24 Aug 2022 20:16:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbiHYAQo (ORCPT ); Wed, 24 Aug 2022 20:16:44 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A767675CE7 for ; Wed, 24 Aug 2022 17:16:43 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id o14-20020a17090a0a0e00b001fabfd3369cso3142821pjo.5 for ; Wed, 24 Aug 2022 17:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=MHdzy+Y3IGKPhJ5wgSVwr2qbqw/cZ1nEjeINOhlIR1Y=; b=KI61vBSlvf0smginpmDqNipT7pvmL+34ub49oTYJ8vAL/m7HAL8OPVtMe9VxqC/xp4 l/IWhbjvmdx0Lm/EQu26nOyM9Wxc2nilf2Qo+vharJdIEAzf58p//MvSK7coJYr9Y807 4RD4y98tNErVdj0CMfP1jhzkb4raK8goULt9dLMWBTxnpkwSxZfFpFnwSK4JMvRCu1EW OE0wgvpyfodk4KEE6NhI0M8YDX90sEJd/330ZMxLe4Z0Y65Jm3tjfkFAreI8hJlYHDnt BAeo+9v5/bW4OAcUYlwe5JeU1ZWdxa0kV7LOAyoKPXVjeq+RmJh8hSPApyxx0lLRpMs+ /7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=MHdzy+Y3IGKPhJ5wgSVwr2qbqw/cZ1nEjeINOhlIR1Y=; b=lY5FQkId/8YuwZUATtYmVoa21XUOHSUQnKW2hCKlZmYFPS6i9Uen3DhSGGvvYOnHRr DUpef7oH5BwFUO4wsVEgqzsrDy85vOqF7zAWjgDh4VPIhA3bKk6FQJ9EmOPM8Ab1iiNb VTbXQ9nDbi+EC4MJEZ5bpDwBN0HQ3Cf6x0Q58PCPNsJPQPiImtZUwumfiy5vzeg+QsSJ mAq4P9yBF9nWHq/h8RarZoHiLsvPKGX+5XJn6sc9FePGP7/imS/q9yFx6Buc0AocB5bg v3iyI6IwrQsFXiYkORPxB2kqFbkBgwKBA3xmZewu0Xeb5ymXyyc300vDtZTNagdM7Ecz f2tQ== X-Gm-Message-State: ACgBeo2lsTovCYhZjFD70pudg/TaHyww+2UKLrEumMWg5GgmN1XDSV61 NKTNivH0zl7msPhHiuA8p5nriw== X-Google-Smtp-Source: AA6agR69d6gIuxI19ypQK8juYAOBDvyZVYJGbVKFz011vcOsLImHYI5Fbe6AvKvRavE2ED/FcyHI6g== X-Received: by 2002:a17:90b:1c0c:b0:1f5:494a:304b with SMTP id oc12-20020a17090b1c0c00b001f5494a304bmr1647000pjb.157.1661386602993; Wed, 24 Aug 2022 17:16:42 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l12-20020a170903244c00b0015e8d4eb1d5sm13390904pls.31.2022.08.24.17.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 17:16:42 -0700 (PDT) Date: Thu, 25 Aug 2022 00:16:38 +0000 From: Sean Christopherson To: Mingwei Zhang Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton Subject: Re: [PATCH 4/5] selftests: KVM: Add support for posted interrupt handling in L2 Message-ID: References: <20220802230718.1891356-1-mizhang@google.com> <20220802230718.1891356-5-mizhang@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220802230718.1891356-5-mizhang@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022, Mingwei Zhang wrote: > Add support for posted interrupt handling in L2. This is done by adding > needed data structures in vmx_pages and APIs to allow an L2 receive posted > interrupts > > Cc: Jim Mattson > Signed-off-by: Mingwei Zhang > --- > tools/testing/selftests/kvm/include/x86_64/vmx.h | 10 ++++++++++ > tools/testing/selftests/kvm/lib/x86_64/vmx.c | 16 ++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/vmx.h b/tools/testing/selftests/kvm/include/x86_64/vmx.h > index 7d8c980317f7..3449ae8ab282 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/vmx.h > +++ b/tools/testing/selftests/kvm/include/x86_64/vmx.h > @@ -579,6 +579,14 @@ struct vmx_pages { > void *apic_access_hva; > uint64_t apic_access_gpa; > void *apic_access; > + > + void *virtual_apic_hva; > + uint64_t virtual_apic_gpa; > + void *virtual_apic; > + > + void *posted_intr_desc_hva; > + uint64_t posted_intr_desc_gpa; > + void *posted_intr_desc; > }; > > union vmx_basic { > @@ -622,5 +630,7 @@ void nested_identity_map_1g(struct vmx_pages *vmx, struct kvm_vm *vm, > void prepare_eptp(struct vmx_pages *vmx, struct kvm_vm *vm, > uint32_t eptp_memslot); > void prepare_virtualize_apic_accesses(struct vmx_pages *vmx, struct kvm_vm *vm); > +void prepare_virtual_apic(struct vmx_pages *vmx, struct kvm_vm *vm); > +void prepare_posted_intr_desc(struct vmx_pages *vmx, struct kvm_vm *vm); > > #endif /* SELFTEST_KVM_VMX_H */ > diff --git a/tools/testing/selftests/kvm/lib/x86_64/vmx.c b/tools/testing/selftests/kvm/lib/x86_64/vmx.c > index 80a568c439b8..7d65bee37b9f 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/vmx.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/vmx.c > @@ -556,3 +556,19 @@ void prepare_virtualize_apic_accesses(struct vmx_pages *vmx, struct kvm_vm *vm) > vmx->apic_access_hva = addr_gva2hva(vm, (uintptr_t)vmx->apic_access); > vmx->apic_access_gpa = addr_gva2gpa(vm, (uintptr_t)vmx->apic_access); > } > + > +void prepare_virtual_apic(struct vmx_pages *vmx, struct kvm_vm *vm) > +{ > + vmx->virtual_apic = (void *)vm_vaddr_alloc_page(vm); > + vmx->virtual_apic_hva = addr_gva2hva(vm, (uintptr_t)vmx->virtual_apic); > + vmx->virtual_apic_gpa = addr_gva2gpa(vm, (uintptr_t)vmx->virtual_apic); > +} > + > +void prepare_posted_intr_desc(struct vmx_pages *vmx, struct kvm_vm *vm) > +{ > + vmx->posted_intr_desc = (void *)vm_vaddr_alloc_page(vm); > + vmx->posted_intr_desc_hva = > + addr_gva2hva(vm, (uintptr_t)vmx->posted_intr_desc); > + vmx->posted_intr_desc_gpa = > + addr_gva2gpa(vm, (uintptr_t)vmx->posted_intr_desc); Let these poke out, or capture the field in a local var. Actually, posted_intr_desc is a void *, is casting even necessary? > +} > -- > 2.37.1.455.g008518b4e5-goog >