From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D98ECAAA3 for ; Fri, 26 Aug 2022 02:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244899AbiHZCwz (ORCPT ); Thu, 25 Aug 2022 22:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiHZCwz (ORCPT ); Thu, 25 Aug 2022 22:52:55 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4440FCCE3B for ; Thu, 25 Aug 2022 19:52:52 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oRPSf-00FHsU-1c; Fri, 26 Aug 2022 12:52:46 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Aug 2022 10:52:44 +0800 Date: Fri, 26 Aug 2022 10:52:44 +0800 From: Herbert Xu To: "Elliott, Robert (Servers)" Cc: "tim.c.chen@linux.intel.com" , Taehee Yoo , "davem@davemloft.net" , "linux-crypto@vger.kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "Kani, Toshi" , "Wright, Randy (HPE Servers Linux)" Subject: Re: [PATCH] crypto: x86/sha512 - load based on CPU features Message-ID: References: <20220813230431.2666-1-elliott@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 26, 2022 at 02:40:58AM +0000, Elliott, Robert (Servers) wrote: > > Suggestion: please revert the sha512-x86 patch for a while. This problem would have existed anyway if the module was built into the kernel. > Do these functions need to break up their processing into smaller chunks > (e.g., a few Megabytes), calling kernel_fpu_end() periodically to > allow the scheduler to take over the CPUs if needed? If so, what > chunk size would be appropriate? Yes these should be limited to 4K each. It appears that all the sha* helpers in arch/x86/crypto have the same problem. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt