Re: [PATCH 8/9] crypto: qat - expose deflate through acomp api for QAT GEN2

From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
	Vlad Dronov <vdronov@redhat.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Adam Guerin <adam.guerin@intel.com>
Subject: Re: [PATCH 8/9] crypto: qat - expose deflate through acomp api for QAT GEN2
Date: Fri, 26 Aug 2022 18:28:48 +0800	[thread overview]
Message-ID: <YwigYBNM7O/J6gO1@gondor.apana.org.au> (raw)
In-Reply-To: <20220818180120.63452-9-giovanni.cabiddu@intel.com>

On Thu, Aug 18, 2022 at 07:01:19PM +0100, Giovanni Cabiddu wrote:
>
> +	/* Handle acomp requests that require the allocation of a destination
> +	 * buffer. The size of the destination buffer is double the source
> +	 * buffer to fit the decompressed output or an expansion on the
> +	 * data for compression.
> +	 */
> +	if (!areq->dst) {
> +		dlen = 2 * slen;
> +		areq->dst = sgl_alloc(dlen, f, NULL);
> +		if (!areq->dst)
> +			return -ENOMEM;
> +	}

So what happens if the decompressed result is more than twice as
long as the source?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt