From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Johan Hovold <johan@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
ira.weiny@intel.com, Hillf Danton <hdanton@sina.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2] Input: iforce - wake up after clearing IFORCE_XMIT_RUNNING flag
Date: Sat, 27 Aug 2022 20:54:41 -0700 [thread overview]
Message-ID: <YwrnAWUCY8S1ZOZZ@google.com> (raw)
In-Reply-To: <887021c3-4f13-40ce-c8b9-aa6e09faa3a7@I-love.SAKURA.ne.jp>
On Wed, Jul 27, 2022 at 07:00:00AM +0900, Tetsuo Handa wrote:
> syzbot is reporting hung task at __input_unregister_device() [1], for
> iforce_close() waiting at wait_event_interruptible() with dev->mutex held
> is blocking input_disconnect_device() from __input_unregister_device().
>
> It seems that the cause is simply that commit c2b27ef672992a20 ("Input:
> iforce - wait for command completion when closing the device") forgot to
> call wake_up() after clear_bit().
>
> Fix this problem by introducing a helper that calls clear_bit() followed
> by wake_up_all().
>
> Link: https://syzkaller.appspot.com/bug?extid=deb6abc36aad4008f407 [1]
> Reported-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
> Fixes: c2b27ef672992a20 ("Input: iforce - wait for command completion when closing the device")
> Tested-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Co-developed-by: Hillf Danton <hdanton@sina.com>
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-08-28 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 5:35 [PATCH] Input: iforce - wake up after clearing IFORCE_XMIT_RUNNING flag Tetsuo Handa
2022-07-26 22:00 ` [PATCH v2] " Tetsuo Handa
2022-08-16 9:50 ` Tetsuo Handa
2022-08-27 6:17 ` Tetsuo Handa
2022-08-28 3:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwrnAWUCY8S1ZOZZ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=hdanton@sina.com \
--cc=ira.weiny@intel.com \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.