From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45B392F2A for ; Mon, 12 Sep 2022 14:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RU+T8Uf+o61IUFzmgdPBOFc/XVJr6YEIpQ2GfXFvfZE=; b=m1KUt9sAvVB7sHf1vzTt1mT4e2 h04cE1UEKlSmAStNvek3cKsp/cksRAe7OlnfLU/KBzeKXpEl+28yw8zRK3Qmaj8SVfRnGQg0uqYdX oP/1cnH/CDHJGeuKekncuFh+Ne0WilgZHz3jXqc3uPS5Lo23ucDg5kHNtRNm8+06oHduJYOq7F2IM nGa8o9LV4IvdvHUTZZklRqmjhChimalG8qBuQ72UbUJzF3tLqWw1yz08EkiVLZ/YF7o2zd5vK8Vt/ mcDs1Gq83wt2k1yia5ma00l6ujj6VmMA411gFu3jAegFcJ65QzUFvlrEOiNT0oGfvihtoXieSBzNN ZkB8KkIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34264) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oXjzr-0001kf-60; Mon, 12 Sep 2022 15:01:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oXjzm-00089o-Fm; Mon, 12 Sep 2022 15:01:06 +0100 Date: Mon, 12 Sep 2022 15:01:06 +0100 From: "Russell King (Oracle)" To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Alyssa Rosenzweig , "asahi@lists.linux.dev" , "brcm80211-dev-list.pdl@broadcom.com" , "David S. Miller" , "devicetree@vger.kernel.org" , Eric Dumazet , Hector Martin , Jakub Kicinski , Kalle Valo , Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , Paolo Abeni , Rafa__ Mi__ecki , Rob Herring , "SHA-cyfmac-dev-list@infineon.com" , Sven Peter , van Spriel Subject: Re: [PATCH wireless-next v2 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Message-ID: References: <20220912115911.e7dlm2xugfq57mei@bang-olufsen.dk> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) On Mon, Sep 12, 2022 at 01:04:58PM +0100, Russell King (Oracle) wrote: > On Mon, Sep 12, 2022 at 11:59:17AM +0000, Alvin Šipraga wrote: > > On Mon, Sep 12, 2022 at 10:52:41AM +0100, Russell King wrote: > > > From: Hector Martin > > > > > > This binding is currently used for SDIO devices, but these chips are > > > also used as PCIe devices on DT platforms and may be represented in the > > > DT. Re-use the existing binding and add chip compatibles used by Apple > > > T2 and M1 platforms (the T2 ones are not known to be used in DT > > > platforms, but we might as well document them). > > > > > > Then, add properties required for firmware selection and calibration on > > > M1 machines. > > > > > > Reviewed-by: Linus Walleij > > > Signed-off-by: Hector Martin > > > Reviewed-by: Mark Kettenis > > > Reviewed-by: Rob Herring > > > Signed-off-by: Russell King (Oracle) > > > --- > > > .../net/wireless/brcm,bcm4329-fmac.yaml | 39 +++++++++++++++++-- > > > 1 file changed, 35 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > index 53b4153d9bfc..fec1cc9b9a08 100644 > > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > > @@ -4,7 +4,7 @@ > > > $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# > > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > -title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices > > > > > > maintainers: > > > - Arend van Spriel > > > @@ -41,11 +41,17 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > - cypress,cyw4373-fmac > > > - cypress,cyw43012-fmac > > > - const: brcm,bcm4329-fmac > > > - - const: brcm,bcm4329-fmac > > > + - enum: > > > + - brcm,bcm4329-fmac > > > + - pci14e4,43dc # BCM4355 > > > + - pci14e4,4464 # BCM4364 > > > + - pci14e4,4488 # BCM4377 > > > + - pci14e4,4425 # BCM4378 > > > + - pci14e4,4433 # BCM4387 > > > > > > reg: > > > - description: SDIO function number for the device, for most cases > > > - this will be 1. > > > + description: SDIO function number for the device (for most cases > > > + this will be 1) or PCI device identifier. > > > > > > interrupts: > > > maxItems: 1 > > > @@ -85,6 +91,31 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices > > > takes precedence. > > > type: boolean > > > > > > + brcm,cal-blob: > > > + $ref: /schemas/types.yaml#/definitions/uint8-array > > > + description: A per-device calibration blob for the Wi-Fi radio. This > > > + should be filled in by the bootloader from platform configuration > > > + data, if necessary, and will be uploaded to the device if present. > > > > Is this a leftover from a previous revision of the patchset? Because as > > far as I can tell, the CLM blob is (still) being loaded via firmware, > > and no additional parsing has been added for this particular OF > > property. Should it be dropped? > > It does appear to be unparsed, but I don't know whether it's needed for > the binding or not. I'll wait for the Asahi folk to review your comment > before possibly removing it. Okay, the answer is, it is still very much part of the binding, and the m1n1 boot loader populates it. This series is a subset of a larger series (remember the previous 34 or 35 patch series?), so there are things in the binding document which are not included in this series. I don't think it makes sense to break up the binding document given that it has already been reviewed several times in its current state, should we really remove this one property and throw away all that review effort. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10AE1ECAAD5 for ; Mon, 12 Sep 2022 14:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zY9nySKEz6eL8RJ7m11kNz4FLGGMA8LHZ51AjZ89sJA=; b=V1LSKGl+IEnKYb PLEQBCO5WgKQUCvPj4geTFqbd+RlOhFmTrfEgOofWME2tCllqivjnWKfuMqe/oUvej+cVdKNX1LtP NPYhZhRKS/zewx1KlqYgp182DFhlZBDJ8RItnj6GWjs5GXowerWXKNSOss1i28WhuSoxcEhYR23Jw SOU7CrW3f6cvJwx4Zyd1dJfNTcqq4bmT+TYK+EwYZ9ESkgYbrO68O+hsiM+jDferdg5b68deF3Nc5 maW52r2AiW7+1ypaMw2JtdDS8U0c/HWA/Cul/SCOyOlgbUFBi1jKfJEHO1UUcJOEHEmVtHGw/ZSDs pFAX1Z1J9576E/IsCwzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXk0B-00ASer-Hk; Mon, 12 Sep 2022 14:01:31 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXk08-00AScj-9x for linux-arm-kernel@lists.infradead.org; Mon, 12 Sep 2022 14:01:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RU+T8Uf+o61IUFzmgdPBOFc/XVJr6YEIpQ2GfXFvfZE=; b=m1KUt9sAvVB7sHf1vzTt1mT4e2 h04cE1UEKlSmAStNvek3cKsp/cksRAe7OlnfLU/KBzeKXpEl+28yw8zRK3Qmaj8SVfRnGQg0uqYdX oP/1cnH/CDHJGeuKekncuFh+Ne0WilgZHz3jXqc3uPS5Lo23ucDg5kHNtRNm8+06oHduJYOq7F2IM nGa8o9LV4IvdvHUTZZklRqmjhChimalG8qBuQ72UbUJzF3tLqWw1yz08EkiVLZ/YF7o2zd5vK8Vt/ mcDs1Gq83wt2k1yia5ma00l6ujj6VmMA411gFu3jAegFcJ65QzUFvlrEOiNT0oGfvihtoXieSBzNN ZkB8KkIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34264) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oXjzr-0001kf-60; Mon, 12 Sep 2022 15:01:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oXjzm-00089o-Fm; Mon, 12 Sep 2022 15:01:06 +0100 Date: Mon, 12 Sep 2022 15:01:06 +0100 From: "Russell King (Oracle)" To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Alyssa Rosenzweig , "asahi@lists.linux.dev" , "brcm80211-dev-list.pdl@broadcom.com" , "David S. Miller" , "devicetree@vger.kernel.org" , Eric Dumazet , Hector Martin , Jakub Kicinski , Kalle Valo , Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , Paolo Abeni , Rafa__ Mi__ecki , Rob Herring , "SHA-cyfmac-dev-list@infineon.com" , Sven Peter , van Spriel Subject: Re: [PATCH wireless-next v2 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Message-ID: References: <20220912115911.e7dlm2xugfq57mei@bang-olufsen.dk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_070128_367499_59B32A0F X-CRM114-Status: GOOD ( 36.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTIsIDIwMjIgYXQgMDE6MDQ6NThQTSArMDEwMCwgUnVzc2VsbCBLaW5nIChP cmFjbGUpIHdyb3RlOgo+IE9uIE1vbiwgU2VwIDEyLCAyMDIyIGF0IDExOjU5OjE3QU0gKzAwMDAs IEFsdmluIMWgaXByYWdhIHdyb3RlOgo+ID4gT24gTW9uLCBTZXAgMTIsIDIwMjIgYXQgMTA6NTI6 NDFBTSArMDEwMCwgUnVzc2VsbCBLaW5nIHdyb3RlOgo+ID4gPiBGcm9tOiBIZWN0b3IgTWFydGlu IDxtYXJjYW5AbWFyY2FuLnN0Pgo+ID4gPiAKPiA+ID4gVGhpcyBiaW5kaW5nIGlzIGN1cnJlbnRs eSB1c2VkIGZvciBTRElPIGRldmljZXMsIGJ1dCB0aGVzZSBjaGlwcyBhcmUKPiA+ID4gYWxzbyB1 c2VkIGFzIFBDSWUgZGV2aWNlcyBvbiBEVCBwbGF0Zm9ybXMgYW5kIG1heSBiZSByZXByZXNlbnRl ZCBpbiB0aGUKPiA+ID4gRFQuIFJlLXVzZSB0aGUgZXhpc3RpbmcgYmluZGluZyBhbmQgYWRkIGNo aXAgY29tcGF0aWJsZXMgdXNlZCBieSBBcHBsZQo+ID4gPiBUMiBhbmQgTTEgcGxhdGZvcm1zICh0 aGUgVDIgb25lcyBhcmUgbm90IGtub3duIHRvIGJlIHVzZWQgaW4gRFQKPiA+ID4gcGxhdGZvcm1z LCBidXQgd2UgbWlnaHQgYXMgd2VsbCBkb2N1bWVudCB0aGVtKS4KPiA+ID4gCj4gPiA+IFRoZW4s IGFkZCBwcm9wZXJ0aWVzIHJlcXVpcmVkIGZvciBmaXJtd2FyZSBzZWxlY3Rpb24gYW5kIGNhbGli cmF0aW9uIG9uCj4gPiA+IE0xIG1hY2hpbmVzLgo+ID4gPiAKPiA+ID4gUmV2aWV3ZWQtYnk6IExp bnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KPiA+ID4gU2lnbmVkLW9mZi1i eTogSGVjdG9yIE1hcnRpbiA8bWFyY2FuQG1hcmNhbi5zdD4KPiA+ID4gUmV2aWV3ZWQtYnk6IE1h cmsgS2V0dGVuaXMgPGtldHRlbmlzQG9wZW5ic2Qub3JnPgo+ID4gPiBSZXZpZXdlZC1ieTogUm9i IEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUnVzc2VsbCBL aW5nIChPcmFjbGUpIDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4KPiA+ID4gLS0tCj4gPiA+ ICAuLi4vbmV0L3dpcmVsZXNzL2JyY20sYmNtNDMyOS1mbWFjLnlhbWwgICAgICAgfCAzOSArKysr KysrKysrKysrKysrKy0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbmV0L3dpcmVsZXNzL2JyY20sYmNtNDMyOS1mbWFjLnlhbWwgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L3dpcmVsZXNzL2JyY20sYmNtNDMy OS1mbWFjLnlhbWwKPiA+ID4gaW5kZXggNTNiNDE1M2Q5YmZjLi5mZWMxY2M5YjlhMDggMTAwNjQ0 Cj4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvd2lyZWxl c3MvYnJjbSxiY200MzI5LWZtYWMueWFtbAo+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbmV0L3dpcmVsZXNzL2JyY20sYmNtNDMyOS1mbWFjLnlhbWwKPiA+ID4g QEAgLTQsNyArNCw3IEBACj4gPiA+ICAkaWQ6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9zY2hlbWFz L25ldC93aXJlbGVzcy9icmNtLGJjbTQzMjktZm1hYy55YW1sIwo+ID4gPiAgJHNjaGVtYTogaHR0 cDovL2RldmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3JlLnlhbWwjCj4gPiA+ICAKPiA+ID4g LXRpdGxlOiBCcm9hZGNvbSBCQ000MzI5IGZhbWlseSBmdWxsbWFjIHdpcmVsZXNzIFNESU8gZGV2 aWNlcwo+ID4gPiArdGl0bGU6IEJyb2FkY29tIEJDTTQzMjkgZmFtaWx5IGZ1bGxtYWMgd2lyZWxl c3MgU0RJTy9QQ0lFIGRldmljZXMKPiA+ID4gIAo+ID4gPiAgbWFpbnRhaW5lcnM6Cj4gPiA+ICAg IC0gQXJlbmQgdmFuIFNwcmllbCA8YXJlbmRAYnJvYWRjb20uY29tPgo+ID4gPiBAQCAtNDEsMTEg KzQxLDE3IEBAIHRpdGxlOiBCcm9hZGNvbSBCQ000MzI5IGZhbWlseSBmdWxsbWFjIHdpcmVsZXNz IFNESU8gZGV2aWNlcwo+ID4gPiAgICAgICAgICAgICAgICAtIGN5cHJlc3MsY3l3NDM3My1mbWFj Cj4gPiA+ICAgICAgICAgICAgICAgIC0gY3lwcmVzcyxjeXc0MzAxMi1mbWFjCj4gPiA+ICAgICAg ICAgICAgLSBjb25zdDogYnJjbSxiY200MzI5LWZtYWMKPiA+ID4gLSAgICAgIC0gY29uc3Q6IGJy Y20sYmNtNDMyOS1mbWFjCj4gPiA+ICsgICAgICAtIGVudW06Cj4gPiA+ICsgICAgICAgICAgLSBi cmNtLGJjbTQzMjktZm1hYwo+ID4gPiArICAgICAgICAgIC0gcGNpMTRlNCw0M2RjICAjIEJDTTQz NTUKPiA+ID4gKyAgICAgICAgICAtIHBjaTE0ZTQsNDQ2NCAgIyBCQ000MzY0Cj4gPiA+ICsgICAg ICAgICAgLSBwY2kxNGU0LDQ0ODggICMgQkNNNDM3Nwo+ID4gPiArICAgICAgICAgIC0gcGNpMTRl NCw0NDI1ICAjIEJDTTQzNzgKPiA+ID4gKyAgICAgICAgICAtIHBjaTE0ZTQsNDQzMyAgIyBCQ000 Mzg3Cj4gPiA+ICAKPiA+ID4gICAgcmVnOgo+ID4gPiAtICAgIGRlc2NyaXB0aW9uOiBTRElPIGZ1 bmN0aW9uIG51bWJlciBmb3IgdGhlIGRldmljZSwgZm9yIG1vc3QgY2FzZXMKPiA+ID4gLSAgICAg IHRoaXMgd2lsbCBiZSAxLgo+ID4gPiArICAgIGRlc2NyaXB0aW9uOiBTRElPIGZ1bmN0aW9uIG51 bWJlciBmb3IgdGhlIGRldmljZSAoZm9yIG1vc3QgY2FzZXMKPiA+ID4gKyAgICAgIHRoaXMgd2ls bCBiZSAxKSBvciBQQ0kgZGV2aWNlIGlkZW50aWZpZXIuCj4gPiA+ICAKPiA+ID4gICAgaW50ZXJy dXB0czoKPiA+ID4gICAgICBtYXhJdGVtczogMQo+ID4gPiBAQCAtODUsNiArOTEsMzEgQEAgdGl0 bGU6IEJyb2FkY29tIEJDTTQzMjkgZmFtaWx5IGZ1bGxtYWMgd2lyZWxlc3MgU0RJTyBkZXZpY2Vz Cj4gPiA+ICAgICAgICB0YWtlcyBwcmVjZWRlbmNlLgo+ID4gPiAgICAgIHR5cGU6IGJvb2xlYW4K PiA+ID4gIAo+ID4gPiArICBicmNtLGNhbC1ibG9iOgo+ID4gPiArICAgICRyZWY6IC9zY2hlbWFz L3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3VpbnQ4LWFycmF5Cj4gPiA+ICsgICAgZGVzY3JpcHRp b246IEEgcGVyLWRldmljZSBjYWxpYnJhdGlvbiBibG9iIGZvciB0aGUgV2ktRmkgcmFkaW8uIFRo aXMKPiA+ID4gKyAgICAgIHNob3VsZCBiZSBmaWxsZWQgaW4gYnkgdGhlIGJvb3Rsb2FkZXIgZnJv bSBwbGF0Zm9ybSBjb25maWd1cmF0aW9uCj4gPiA+ICsgICAgICBkYXRhLCBpZiBuZWNlc3Nhcnks IGFuZCB3aWxsIGJlIHVwbG9hZGVkIHRvIHRoZSBkZXZpY2UgaWYgcHJlc2VudC4KPiA+IAo+ID4g SXMgdGhpcyBhIGxlZnRvdmVyIGZyb20gYSBwcmV2aW91cyByZXZpc2lvbiBvZiB0aGUgcGF0Y2hz ZXQ/IEJlY2F1c2UgYXMKPiA+IGZhciBhcyBJIGNhbiB0ZWxsLCB0aGUgQ0xNIGJsb2IgaXMgKHN0 aWxsKSBiZWluZyBsb2FkZWQgdmlhIGZpcm13YXJlLAo+ID4gYW5kIG5vIGFkZGl0aW9uYWwgcGFy c2luZyBoYXMgYmVlbiBhZGRlZCBmb3IgdGhpcyBwYXJ0aWN1bGFyIE9GCj4gPiBwcm9wZXJ0eS4g U2hvdWxkIGl0IGJlIGRyb3BwZWQ/Cj4gCj4gSXQgZG9lcyBhcHBlYXIgdG8gYmUgdW5wYXJzZWQs IGJ1dCBJIGRvbid0IGtub3cgd2hldGhlciBpdCdzIG5lZWRlZCBmb3IKPiB0aGUgYmluZGluZyBv ciBub3QuIEknbGwgd2FpdCBmb3IgdGhlIEFzYWhpIGZvbGsgdG8gcmV2aWV3IHlvdXIgY29tbWVu dAo+IGJlZm9yZSBwb3NzaWJseSByZW1vdmluZyBpdC4KCk9rYXksIHRoZSBhbnN3ZXIgaXMsIGl0 IGlzIHN0aWxsIHZlcnkgbXVjaCBwYXJ0IG9mIHRoZSBiaW5kaW5nLCBhbmQKdGhlIG0xbjEgYm9v dCBsb2FkZXIgcG9wdWxhdGVzIGl0LgoKVGhpcyBzZXJpZXMgaXMgYSBzdWJzZXQgb2YgYSBsYXJn ZXIgc2VyaWVzIChyZW1lbWJlciB0aGUgcHJldmlvdXMgMzQKb3IgMzUgcGF0Y2ggc2VyaWVzPyks IHNvIHRoZXJlIGFyZSB0aGluZ3MgaW4gdGhlIGJpbmRpbmcgZG9jdW1lbnQKd2hpY2ggYXJlIG5v dCBpbmNsdWRlZCBpbiB0aGlzIHNlcmllcy4KCkkgZG9uJ3QgdGhpbmsgaXQgbWFrZXMgc2Vuc2Ug dG8gYnJlYWsgdXAgdGhlIGJpbmRpbmcgZG9jdW1lbnQgZ2l2ZW4KdGhhdCBpdCBoYXMgYWxyZWFk eSBiZWVuIHJldmlld2VkIHNldmVyYWwgdGltZXMgaW4gaXRzIGN1cnJlbnQgc3RhdGUsCnNob3Vs ZCB3ZSByZWFsbHkgcmVtb3ZlIHRoaXMgb25lIHByb3BlcnR5IGFuZCB0aHJvdyBhd2F5IGFsbCB0 aGF0CnJldmlldyBlZmZvcnQuCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5h cm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAgaXMgaGVyZSEgNDBNYnBzIGRv d24gMTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==