All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/5] tests/i915/i915_pm_dc: Add test description
Date: Mon, 12 Sep 2022 16:04:25 +0300	[thread overview]
Message-ID: <Yx8uWTr9PNP/M08v@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20220909114911.1852-2-swati2.sharma@intel.com>

On Fri, Sep 09, 2022 at 05:19:07PM +0530, Swati Sharma wrote:
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>

Commit message is missing, something to explain why moving the
description is required. With that:

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  tests/i915/i915_pm_dc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> index f664a2a2c..40811ae52 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -44,6 +44,8 @@
>  #define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
>  #define KMS_POLL_DISABLE 0
>  
> +IGT_TEST_DESCRIPTION("Tests to validate display power DC states.");
> +
>  bool kms_poll_saved_state;
>  
>  typedef struct {
> @@ -473,7 +475,6 @@ static void kms_poll_state_restore(int sig)
>  	}
>  }
>  
> -IGT_TEST_DESCRIPTION("These tests validate Display Power DC states");
>  int main(int argc, char *argv[])
>  {
>  	data_t data = {};
> -- 
> 2.25.1
> 

  reply	other threads:[~2022-09-12 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 11:49 [igt-dev] [PATCH i-g-t v6 0/5] Modify dc9 validation Swati Sharma
2022-09-09 11:49 ` [igt-dev] [PATCH i-g-t 1/5] tests/i915/i915_pm_dc: Add test description Swati Sharma
2022-09-12 13:04   ` Imre Deak [this message]
2022-09-09 11:49 ` [igt-dev] [PATCH i-g-t v3 2/5] tests/i915/i915_pm_dc: Change debugfs for reading platform info Swati Sharma
2022-09-09 11:49 ` [igt-dev] [PATCH i-g-t v4 3/5] lib/pm: Add helper functions to get runtime suspended time Swati Sharma
2022-09-09 11:49 ` [igt-dev] [PATCH i-g-t v5 4/5] tests/i915/i915_pm_dc: Modify dc9 test Swati Sharma
2022-09-12 13:23   ` Imre Deak
2022-09-09 11:49 ` [igt-dev] [PATCH i-g-t 5/5] tests/i915/i915_pm_dc: Sleep not reqd. to reset counter Swati Sharma
2022-09-12 13:23   ` Imre Deak
2022-09-09 13:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Modify dc9 validation (rev6) Patchwork
2022-09-09 16:31 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yx8uWTr9PNP/M08v@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.