From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0F85C82; Thu, 1 Sep 2022 14:57:38 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7C4BE10000D; Thu, 1 Sep 2022 14:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662044250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fTIPUvR6Kg1MdIRVJEFetX2DVyRFLn/K5hDyVlwXeq0=; b=JRf/f31Zr+iQG1WfwUbx+DyE+WxW+UtZdcYuxz9I7irSd6OrLR54AgteN8Wkj6q8jcmVNq V1pblHtO0yrZWthBdBFM47U6/NkQN9RBq3+nAmDm8XuB76orr7SrmDQ1PYgccdk5sWvYgT MrU92RDReh2z7nApwCvoL8DIG/Now8sTH7K3DDQIJlcYxOWcDu86PLniQoML84J1nY/ghW l/auGwgzvdiWGIVi1TVSMYvkwv7vq7WSP8cJsTKL5Eo9CPTftIlutaGgdp8ZbARyC+ZbWr 2R8lP3eVcnEjAZadjPnzqXlf4bWNNymNvxxuP3sUBHeO32KMiJcIqTlm6M3LPA== Date: Thu, 1 Sep 2022 16:57:25 +0200 From: Paul Kocialkowski To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Hans Verkuil , Maxime Ripard , Thomas Petazzoni , Rob Herring Subject: Re: [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port Message-ID: References: <20220826184144.605605-1-paul.kocialkowski@bootlin.com> <20220826184144.605605-3-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zak6f8vSQKBH2kPD" Content-Disposition: inline In-Reply-To: --zak6f8vSQKBH2kPD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Laurent, On Sat 27 Aug 22, 01:29, Laurent Pinchart wrote: > Hi Paul, >=20 > Thank you for the patch. Thanks for the review! > On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > >=20 > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > >=20 > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > >=20 > > Signed-off-by: Paul Kocialkowski > > Acked-by: Rob Herring > > --- > > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a3= 1-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-cs= i.yaml > > index 8551c4a711dc..54eb80e517e3 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > @@ -73,6 +73,10 @@ properties: > > $ref: /schemas/graph.yaml#/properties/port > > description: MIPI CSI-2 bridge input port > > =20 > > + port@2: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: ISP output port > > + >=20 > I'd write "Output port to the ISP" to make it clearer. >=20 > Reviewed-by: Laurent Pinchart Agreed, thanks! Paul > > anyOf: > > - required: > > - port@0 >=20 > --=20 > Regards, >=20 > Laurent Pinchart --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --zak6f8vSQKBH2kPD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmMQyFUACgkQ3cLmz3+f v9E72Qf+JUqBNPJxnYRP3CDIdAusEIcEorc/b1N0Hzcfi8xOLVzZL0/cIuaCVt/A xXngf5KFBW8h8cJJ/wflHMP7PN8e5UPpHTlVMx+EfNzkNeL7gAfHYUh6EmpmS0t1 a+sEDPevYcn36Jnnoi30Pn6rCd0n5ibFC9vKYoDkOaYrfSlGtvUw8ZljQWQwVLWq jv4mhzj8qCRJQpf7gP8DYckAA2unewY1dsqI5xgEhhgCAjCvrtwsjrYfWYieCfMH YR1ahUJbG63JgD9SKw6pwkAwGIklv2+ZQ0J40ZtzXby0vAoWUDPawchJWvvXIim8 bsOnx4MaPlqhohaAjEIaxFZ+PSBROw== =J+Ve -----END PGP SIGNATURE----- --zak6f8vSQKBH2kPD-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC966ECAAD3 for ; Thu, 1 Sep 2022 14:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WTJRJqIesJTnGiaTnDm61R4G3djkTab0KXRlmPoXyzc=; b=IvSCvtMfzfgmFcyf2H0DqXOSRA ZGrtGSwf9DfGcgwEmupVMMZkjRz+Qr/k84eK/KmxVf1kFBCDRdoJue2bFhP9NDYdspAnzC7R8/juS 7bYDA7D6YXaktQVXsRm2wxx5c46JdRbwnmR+mcNEuYIlAlCSgtyTPNJfPpbqDGbdhl1uG+fExX31q tql+Zgn26TtEJ53DF8riRxMsLxGFQvVwcqKBCWw0i2wHsBN7SxXf6AInMuNiRXaAGj9trmdRMciui 7RGdR9l2GnQ5Pie4Vapji8sSn9Cxs5MeYumvku+qJcKyW6KiTrwCIpOTqpaXmbMkZUaiStpqFfkcz N30JVYyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTldT-00CeCk-Qd; Thu, 01 Sep 2022 14:57:39 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTldP-00Ce9d-5B for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 14:57:37 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7C4BE10000D; Thu, 1 Sep 2022 14:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662044250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fTIPUvR6Kg1MdIRVJEFetX2DVyRFLn/K5hDyVlwXeq0=; b=JRf/f31Zr+iQG1WfwUbx+DyE+WxW+UtZdcYuxz9I7irSd6OrLR54AgteN8Wkj6q8jcmVNq V1pblHtO0yrZWthBdBFM47U6/NkQN9RBq3+nAmDm8XuB76orr7SrmDQ1PYgccdk5sWvYgT MrU92RDReh2z7nApwCvoL8DIG/Now8sTH7K3DDQIJlcYxOWcDu86PLniQoML84J1nY/ghW l/auGwgzvdiWGIVi1TVSMYvkwv7vq7WSP8cJsTKL5Eo9CPTftIlutaGgdp8ZbARyC+ZbWr 2R8lP3eVcnEjAZadjPnzqXlf4bWNNymNvxxuP3sUBHeO32KMiJcIqTlm6M3LPA== Date: Thu, 1 Sep 2022 16:57:25 +0200 From: Paul Kocialkowski To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Hans Verkuil , Maxime Ripard , Thomas Petazzoni , Rob Herring Subject: Re: [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port Message-ID: References: <20220826184144.605605-1-paul.kocialkowski@bootlin.com> <20220826184144.605605-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_075735_522167_7FDA69C5 X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1798968954297767795==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1798968954297767795== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zak6f8vSQKBH2kPD" Content-Disposition: inline --zak6f8vSQKBH2kPD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Laurent, On Sat 27 Aug 22, 01:29, Laurent Pinchart wrote: > Hi Paul, >=20 > Thank you for the patch. Thanks for the review! > On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > >=20 > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > >=20 > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > >=20 > > Signed-off-by: Paul Kocialkowski > > Acked-by: Rob Herring > > --- > > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a3= 1-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-cs= i.yaml > > index 8551c4a711dc..54eb80e517e3 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > @@ -73,6 +73,10 @@ properties: > > $ref: /schemas/graph.yaml#/properties/port > > description: MIPI CSI-2 bridge input port > > =20 > > + port@2: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: ISP output port > > + >=20 > I'd write "Output port to the ISP" to make it clearer. >=20 > Reviewed-by: Laurent Pinchart Agreed, thanks! Paul > > anyOf: > > - required: > > - port@0 >=20 > --=20 > Regards, >=20 > Laurent Pinchart --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --zak6f8vSQKBH2kPD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmMQyFUACgkQ3cLmz3+f v9E72Qf+JUqBNPJxnYRP3CDIdAusEIcEorc/b1N0Hzcfi8xOLVzZL0/cIuaCVt/A xXngf5KFBW8h8cJJ/wflHMP7PN8e5UPpHTlVMx+EfNzkNeL7gAfHYUh6EmpmS0t1 a+sEDPevYcn36Jnnoi30Pn6rCd0n5ibFC9vKYoDkOaYrfSlGtvUw8ZljQWQwVLWq jv4mhzj8qCRJQpf7gP8DYckAA2unewY1dsqI5xgEhhgCAjCvrtwsjrYfWYieCfMH YR1ahUJbG63JgD9SKw6pwkAwGIklv2+ZQ0J40ZtzXby0vAoWUDPawchJWvvXIim8 bsOnx4MaPlqhohaAjEIaxFZ+PSBROw== =J+Ve -----END PGP SIGNATURE----- --zak6f8vSQKBH2kPD-- --===============1798968954297767795== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1798968954297767795==--