All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tty: serial: introduce transmit helper generators
Date: Fri, 2 Sep 2022 07:23:40 +0200	[thread overview]
Message-ID: <YxGTXK452NwcQEGC@kroah.com> (raw)
In-Reply-To: <e122fe60-484b-fd50-d166-4a21e08d4775@kernel.org>

On Fri, Sep 02, 2022 at 07:16:58AM +0200, Jiri Slaby wrote:
> On 01. 09. 22, 14:25, Greg KH wrote:
> > Much nicer, but:
> > 
> > > +#define __DEFINE_UART_PORT_TX_HELPER(name, port, ch, tx_ready, put_char,  \
> > > +		tx_done, for_test, for_post, ...)			  \
> > 
> > Do you really need "port" and "ch" as part of this macro?  You always
> > set that to the same thing in your patches, so is it really needed?
> 
> Not really, just to make obvious that those are the names that can be used
> in tx_ready, put_char... I can remove it, if you prefer, of course.

I'd recommend just removing it as it's a hard macro to read as-is.  That
would make it a bit more simple as then you are just passing in the name
and the callback functions, which makes a bit more sense to me.

thanks,

greg k-h

  reply	other threads:[~2022-09-02  5:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 11:06 [PATCH v2 0/3] tty: TX helpers Jiri Slaby
2022-09-01 11:06 ` Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 1/3] tty: serial: introduce transmit helper generators Jiri Slaby
2022-09-01 12:25   ` Greg KH
2022-09-02  5:16     ` Jiri Slaby
2022-09-02  5:23       ` Greg KH [this message]
2022-09-02  8:02         ` Jiri Slaby
2022-09-02 10:22   ` Ilpo Järvinen
2022-09-02 10:24     ` Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 2/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER() Jiri Slaby
2022-09-02 14:21   ` Ilpo Järvinen
2022-09-06 10:50     ` Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 3/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED() Jiri Slaby
2022-09-01 11:06   ` Jiri Slaby
2022-09-02 14:56   ` Ilpo Järvinen
2022-09-02 14:56     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxGTXK452NwcQEGC@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.