From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B161ECAAA1 for ; Sat, 3 Sep 2022 00:17:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB3E910E954; Sat, 3 Sep 2022 00:17:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D5DB10E949 for ; Sat, 3 Sep 2022 00:17:37 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 783186DD; Sat, 3 Sep 2022 02:17:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662164255; bh=P3z29BkLY8pp5QffYlk19e0Qtl1KILoEFtI0UY7fAdE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twNQ42Hfd5MMCl4KY7fIFFwxw0HHAfRqast+K+Knhgy+4bEi/yEFixxuxSiBYSv4R 1/bM0VD4qsGjr33GceoM8BlM+XWHK3xGjg6vSEYY73NJ6mTndodg/i5r2REHTzrT4q 512WrT37Dvz1+H0VwARREeIgavTQiCiuZ/dLxNQs= Date: Sat, 3 Sep 2022 03:17:23 +0300 From: Laurent Pinchart To: Chris Morgan Subject: Re: [PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033 Message-ID: References: <20220902153906.31000-1-macroalpha82@gmail.com> <20220902153906.31000-2-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220902153906.31000-2-macroalpha82@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: krzysztof.kozlowski+dt@linaro.org, jonas@kwiboo.se, airlied@linux.ie, robert.foss@linaro.org, narmstrong@baylibre.com, Chris Morgan , dri-devel@lists.freedesktop.org, lkundrak@v3.sk, andrzej.hajda@intel.com, robh+dt@kernel.org, jernej.skrabec@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Chris, Thank you for the patch. On Fri, Sep 02, 2022 at 10:39:05AM -0500, Chris Morgan wrote: > From: Chris Morgan > > Update dt-binding documentation to add support for setting byteswap of > chrontel ch7033. > > New property name of chrontel,byteswap added to set the byteswap order. > This property is optional. > > Signed-off-by: Chris Morgan > Reviewed-by: Robert Foss > --- > .../bindings/display/bridge/chrontel,ch7033.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml > index bb6289c7d375..984b90893583 100644 > --- a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml > @@ -14,6 +14,19 @@ properties: > compatible: > const: chrontel,ch7033 > > + chrontel,byteswap: > + $ref: /schemas/types.yaml#/definitions/uint8 > + enum: > + - 0 # BYTE_SWAP_RGB > + - 1 # BYTE_SWAP_RBG > + - 2 # BYTE_SWAP_GRB > + - 3 # BYTE_SWAP_GBR > + - 4 # BYTE_SWAP_BRG > + - 5 # BYTE_SWAP_BGR > + description: | > + Set the byteswap value of the bridge. This is optional and if not > + set value of BYTE_SWAP_BGR is used. I don't think this belongs to the device tree. The source of data connected to the CH7033 input could use different formats. This shouldn't be hardcoded, but queried at runtime, using the input and output media bus formats infrastructure that the DRM bridge framework includes. > + > reg: > maxItems: 1 > description: I2C address of the device -- Regards, Laurent Pinchart