From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF72BC6FA82 for ; Sat, 3 Sep 2022 06:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232350AbiICGdg (ORCPT ); Sat, 3 Sep 2022 02:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231520AbiICGde (ORCPT ); Sat, 3 Sep 2022 02:33:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFCFB7779 for ; Fri, 2 Sep 2022 23:33:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C24F60B2F for ; Sat, 3 Sep 2022 06:33:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D22C2C433D6; Sat, 3 Sep 2022 06:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662186812; bh=FLClP/CWYVB7U+G72MvxNuGbFWXAOpLmjXm5ZoyA6vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZjHw+0/MjXvHwOTouWtGvy6gmAjwb5e8II4gKD8hDH9egGOQ/u5GSdGCxUyrcsBnL IfAE4LPvPLaoHXWB708NdPUVmcL/BzcKVVDudtMFOrSOKwtJ9vp7gcJDS3ey13Rx2p e+V/goiZZfJtAKgx8f+td7Bo1Z1bBIauRMwW0p2A= Date: Sat, 3 Sep 2022 08:33:50 +0200 From: Greg KH To: Li Zhong Cc: Linux Kernel Mailing List , rafael@kernel.org Subject: Re: [PATCH v1] drivers/base/auxiliary: check return value of strrchr() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2022 at 11:25:31PM -0700, Li Zhong wrote: > From: Li Zhong > > The return value of strrchr() could be NULL, which will cause invalid > offset in (int)(p - name). So we check it here. > > Signed-off-by: Li Zhong > --- > drivers/base/auxiliary.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > index 8c5e65930617..7ac23be47e1f 100644 > --- a/drivers/base/auxiliary.c > +++ b/drivers/base/auxiliary.c > @@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, > struct kobj_uevent_env *env) > > name = dev_name(dev); > p = strrchr(name, '.'); > - > + if (!p) > + return -EINVAL; > return add_uevent_var(env, "MODALIAS=%s%.*s", AUXILIARY_MODULE_PREFIX, > (int)(p - name), name); > } > -- > 2.25.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot