* [PATCH] fpga: prevent integer overflow in dfl_feature_ioctl_set_irq()
@ 2022-09-01 5:18 Dan Carpenter
2022-09-03 17:52 ` Xu Yilun
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-09-01 5:18 UTC (permalink / raw)
To: Wu Hao, Xu Yilun
Cc: Tom Rix, Moritz Fischer, Luwei Kang, Marcelo Tosatti, linux-fpga,
kernel-janitors
The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
systems leading to memory corruption. Use array_size() to fix that.
Fixes: 322b598be4d9 ("fpga: dfl: introduce interrupt trigger setting API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/fpga/dfl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
index 5498bc337f8b..b9aae85ba930 100644
--- a/drivers/fpga/dfl.c
+++ b/drivers/fpga/dfl.c
@@ -1866,7 +1866,7 @@ long dfl_feature_ioctl_set_irq(struct platform_device *pdev,
return -EINVAL;
fds = memdup_user((void __user *)(arg + sizeof(hdr)),
- hdr.count * sizeof(s32));
+ array_size(hdr.count, sizeof(s32)));
if (IS_ERR(fds))
return PTR_ERR(fds);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fpga: prevent integer overflow in dfl_feature_ioctl_set_irq()
2022-09-01 5:18 [PATCH] fpga: prevent integer overflow in dfl_feature_ioctl_set_irq() Dan Carpenter
@ 2022-09-03 17:52 ` Xu Yilun
0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2022-09-03 17:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Wu Hao, Tom Rix, Moritz Fischer, Luwei Kang, Marcelo Tosatti,
linux-fpga, kernel-janitors
On 2022-09-01 at 08:18:45 +0300, Dan Carpenter wrote:
> The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
> systems leading to memory corruption. Use array_size() to fix that.
>
> Fixes: 322b598be4d9 ("fpga: dfl: introduce interrupt trigger setting API")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to fpga for-next.
Thanks
Yilun
> ---
> drivers/fpga/dfl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index 5498bc337f8b..b9aae85ba930 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -1866,7 +1866,7 @@ long dfl_feature_ioctl_set_irq(struct platform_device *pdev,
> return -EINVAL;
>
> fds = memdup_user((void __user *)(arg + sizeof(hdr)),
> - hdr.count * sizeof(s32));
> + array_size(hdr.count, sizeof(s32)));
> if (IS_ERR(fds))
> return PTR_ERR(fds);
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-03 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 5:18 [PATCH] fpga: prevent integer overflow in dfl_feature_ioctl_set_irq() Dan Carpenter
2022-09-03 17:52 ` Xu Yilun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.