From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D353C54EE9 for ; Wed, 7 Sep 2022 17:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbiIGRyJ (ORCPT ); Wed, 7 Sep 2022 13:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbiIGRyI (ORCPT ); Wed, 7 Sep 2022 13:54:08 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E5AADCC0 for ; Wed, 7 Sep 2022 10:54:07 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id a10so11036058qkl.13 for ; Wed, 07 Sep 2022 10:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=crsgd12kREDdn4Z5CkQitLdcfYNnDp5ExCJttsFTe6k=; b=2ErPJwCX+rMbrZSatsDnWhtUSmQvlTSASo3PEsIFBrcyQXZIKBcdGGc568+XposyoI 7ZK6Aig77VkmVF2YVzQNKb2OT2BVp77cp0KsjohYGgPYm5nW+vEabEGe5eyd6zT3jcDo 8zsmxtqjymARBDYTjcRFcN9jXyqZy22NK58/S5U7ILgxxuua80nPNutDIO2bYcB9MFGL 1Au00coPsYik4JTafK8FKi2fixLupS3+TdFZmp+dfs+bi8u1BrgTYouG4+gMogzt+Ckw EsDaxqBZaVmQU1tt9VMmkYohE/DWKBoTtezqu0SgHG5J9OGGdajXyfycG1/d2R01J4yr GoCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=crsgd12kREDdn4Z5CkQitLdcfYNnDp5ExCJttsFTe6k=; b=u2xxajo0BttpJbxzrKwADhy88ywbrYye+yZMyAwLJFfsciKG67lRABFJlE8139S6Ud XzUZH0l3XxRgdMZ7yq9lWt/Hl+LizqptSh/X5NIWQHLafJBbCwpBLveGfBwW6vcsRBv4 RyjNG6OqP8wCrWzyL+HbJGoHOWAkCHSouOMR3JVl70LQXMaC0yeN9TJQL4lYbXC1JORp zCjWGdpdQa4ABRVYFeiU2QOAzsjjV3WrMOfbTvNxpCoFGB3ROPaYLgmgCZMOQAWZQWAE ixraPcm/jBGS55CNzuZrhp0emOJHYq9rl6B5Z809tNWekQmAnOSCOCAL0RZegK+/RjE/ Kwtg== X-Gm-Message-State: ACgBeo2fwEh/e/3QYWLE5hBaHoUKgOPn8rJLkg3X86EejoiKV8BR79Km 9ofu0v6Eg8ikOpwwDgMs7aie1w== X-Google-Smtp-Source: AA6agR4TctpuYni4248jRQkhzrm1mMLjp3gL4Iz3UzzJvaigtRN3Bu7t2yYY+5JZ1peZFLqxKsq//g== X-Received: by 2002:a05:620a:2453:b0:6c5:8569:771e with SMTP id h19-20020a05620a245300b006c58569771emr3419894qkn.45.1662573246392; Wed, 07 Sep 2022 10:54:06 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id n15-20020a05620a294f00b006b942f4ffe3sm15723871qkp.18.2022.09.07.10.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 10:54:05 -0700 (PDT) Date: Wed, 7 Sep 2022 13:54:04 -0400 From: Josef Bacik To: Christoph Hellwig Cc: Chris Mason , David Sterba , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Qu Wenruo , Jens Axboe , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 03/17] btrfs: move repair_io_failure to volumes.c Message-ID: References: <20220901074216.1849941-1-hch@lst.de> <20220901074216.1849941-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901074216.1849941-4-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Sep 01, 2022 at 10:42:02AM +0300, Christoph Hellwig wrote: > repair_io_failure ties directly into all the glory low-level details of > mapping a bio with a logic address to the actual physical location. > Move it right below btrfs_submit_bio to keep all the related logic > together. > > Also move btrfs_repair_eb_io_failure to its caller in disk-io.c now that > repair_io_failure is available in a header. > > Signed-off-by: Christoph Hellwig Reviewed-by: Josef Bacik Thanks, Josef