From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: George Cherian <gcherian@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
David Daney <david.daney@cavium.com>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] crypto: cavium - prevent integer overflow loading firmware
Date: Thu, 8 Sep 2022 17:42:54 +0800 [thread overview]
Message-ID: <Yxm5HrtXBiz6gKtv@gondor.apana.org.au> (raw)
In-Reply-To: <YxDQpc9IINUuUhQr@kili>
On Thu, Sep 01, 2022 at 06:32:53PM +0300, Dan Carpenter wrote:
>
> @@ -263,7 +264,13 @@ static int cpt_ucode_load_fw(struct cpt_device *cpt, const u8 *fw, bool is_ae)
> ucode = (struct ucode_header *)fw_entry->data;
> mcode = &cpt->mcode[cpt->next_mc_idx];
> memcpy(mcode->version, (u8 *)fw_entry->data, CPT_UCODE_VERSION_SZ);
> - mcode->code_size = ntohl(ucode->code_length) * 2;
> +
> + code_length = ntohl(ucode->code_length);
> + if (code_length >= INT_MAX / 2) {
> + ret = -EINVAL;
> + goto fw_release;
> + }
> + mcode->code_size = code_length;
Where did the "* 2" go?
BTW, what is the threat model here? If the firmware metadata can't
be trusted, shouldn't we be capping the firmware size at a level
a lot lower than INT_MAX?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-08 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 15:32 [PATCH] crypto: cavium - prevent integer overflow loading firmware Dan Carpenter
2022-09-08 9:42 ` Herbert Xu [this message]
2022-09-15 13:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxm5HrtXBiz6gKtv@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=gcherian@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.