From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EC0C6FA82 for ; Fri, 9 Sep 2022 14:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbiIIO5s (ORCPT ); Fri, 9 Sep 2022 10:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbiIIO5p (ORCPT ); Fri, 9 Sep 2022 10:57:45 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2890B138646 for ; Fri, 9 Sep 2022 07:57:44 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id j6-20020a17090a694600b00200bba67dadso1817922pjm.5 for ; Fri, 09 Sep 2022 07:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=sJne0n/dItmJ8FdGRvyu4m07+jsgg1m7nAPE19ef1wY=; b=AHVdvIw1kNaGDusehlOEfHFjz5kJt2wmTST21GNKFhy400uzrzuUxd6pE+wQa+rBUJ jBWLvdg1b7VC1J8IrpyKNtOmv+KfbZC3H8ciFHskMxGBXwRS169LRwqtHth8X2Oertt0 ZodcXJ5CWhpbtZAYjdQj67F5xrjuQ7kkTk3loCXMOChsTRU7XJwqqcySB3IDP6WF7x06 4dJqbyEgn/W6mcXPkvdsqYM8o7kDtIVAotp6QLcnu+y0fnTkVi5Df72ah6QuDNJ4D98w g7fjrNZhRJkg6+HJVbMvXA0RXVdGUNzccPiPwb0cLMxtYSAqyyFlojg6Cm3QpGkyDsYS uY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=sJne0n/dItmJ8FdGRvyu4m07+jsgg1m7nAPE19ef1wY=; b=qpmJQw17rqqTRy3k0p1TGMCBpg4Z84wSNTOaNm9zE4SIL5FqPcRsKZbFZkfUSKSY06 dXBIyES/GB4ZF7uRm3jJg4aq7MqJBX1rP1pWI7wW+pADq0hvJ8VHoNImzYtI7w7I2Mtw TMZfvNMBmv4weh3qMp8wtLh0fQVchlQ4E7Uh6BYb0igwIqhsQzSQZdL/zBPIk/tXa9mG 95uWa6l3tU0efqFwOntKgU3EZUSGh2gn7ABWBfDuX0/F/4hPhgHnfoxu/tnXEy2ncCet 98yj8ErkiZ9KffU6DFsLS+WupvWEqoXjk+zdYJ1+wyj2JWKTU4udbfkPChJuL6ksNcWJ mSkQ== X-Gm-Message-State: ACgBeo3RMY8882ebQJpShlnQDR7b8oPFkLm/Dno9zpvV15uI5TxkVgHJ do6uKUB2QfaWYmG9+JHyhkVuwA== X-Google-Smtp-Source: AA6agR4ptQYvFRKAt8ikaON84I1JqNPp2elrnTXBuPEH1pav0TaYUexSj4GIwV+e2snvobL+D9V40A== X-Received: by 2002:a17:90b:4d0d:b0:1fb:a86d:e752 with SMTP id mw13-20020a17090b4d0d00b001fba86de752mr10065280pjb.120.1662735462930; Fri, 09 Sep 2022 07:57:42 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i127-20020a625485000000b00540ffb28da0sm667281pfb.91.2022.09.09.07.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 07:57:42 -0700 (PDT) Date: Fri, 9 Sep 2022 14:57:39 +0000 From: Sean Christopherson To: Liam Ni Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, pbonzini@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com Subject: Re: [PATCH v2] KVM:x86: Clean up ModR/M "reg" initialization in reg op decoding Message-ID: References: <20220908141210.1375828-1-zhiguangni01@zhaoxin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022, Liam Ni wrote: > On Thu, 8 Sept 2022 at 23:50, Sean Christopherson wrote: > > > > On Thu, Sep 08, 2022, Liam Ni wrote: > > > From: Liam Ni > > > > > > Refactor decode_register_operand() to get the ModR/M register if and > > > only if the instruction uses a ModR/M encoding to make it more obvious > > > how the register operand is retrieved. > > > > > > Signed-off-by: Liam Ni > > > --- > > > > Pushed to branch `for_paolo/6.1` at: > > > > https://github.com/sean-jc/linux.git > > > > with the below nit sqaushed. Unless you hear otherwise, it will make its way to > > kvm/queue "soon". > > > > Note, the commit IDs are not guaranteed to be stable. > > > > > arch/x86/kvm/emulate.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > > > index f092c54d1a2f..879b52af763a 100644 > > > --- a/arch/x86/kvm/emulate.c > > > +++ b/arch/x86/kvm/emulate.c > > > @@ -1137,9 +1137,11 @@ static int em_fnstsw(struct x86_emulate_ctxt *ctxt) > > > static void decode_register_operand(struct x86_emulate_ctxt *ctxt, > > > struct operand *op) > > > { > > > - unsigned reg = ctxt->modrm_reg; > > > + unsigned int reg; > > > > > > - if (!(ctxt->d & ModRM)) > > > + if ((ctxt->d & ModRM)) > > > > Only need one set of parentheses. > > Sorry， Should I prepare a new patch? Nope, all taken care of. Thanks!