All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, libcamera-devel@lists.libcamera.org
Subject: Re: RFC: Arducam 64 MP (Hawkeye)
Date: Fri, 23 Sep 2022 10:03:19 +0000	[thread overview]
Message-ID: <Yy2EZ4JwG01UKLhX@paasikivi.fi.intel.com> (raw)
In-Reply-To: <166392656967.56880.6892202016312600929@Monstersaurus>

Hi Kieran,

On Fri, Sep 23, 2022 at 10:49:29AM +0100, Kieran Bingham wrote:
> Hi Sakari, Laurent,
> 
> Last night I hooked up the Arducam 64 MP Hawkeye camera [0], to an RPi4,
> and added the camera helper for the RaspberryPi IPA to libcamera, and
> was able to use the camera directly with dtoverlay=arducam_64mp in the
> Raspberry Pi /boot/config.txt using the latest release from Raspberry
> Pi.
> 
> Raspberry Pi have already added the driver for this camera [1] to their
> tree, and I have been given the tuning files from Arducam.
> 
> This has allowed me to capture an image with pretty good response to
> changing lighting conditions, and colours. [2] ... The AF isn't yet
> enabled, so that shot is out of focus a little. (That's for later).
> 
> Arducam do not wish to name the sensor used in the module, and have
> called it the 'arducam_64mp'. But attempting to upstreaming this with
> that name worries me.
> 
> Furthermore, we would like to maintain libcamera as supporting cameras
> that have 'upstream' drivers (or drivers that are on their way
> upstream), so I'm keen to identify how we can upstream the drivers to
> create a better experience for users who are currently finding that they
> need to run a fork of libcamera to operate the module.
> 
> So ultimately - my open question is ... Is it acceptable to have camera
> drivers that are named by their 'module/integration' rather than their
> sensor?

A lot of users (especially the existing ones) depend on the entity name
currently. I don't think we could change it. For new ones I guess that
would be possible.

Alternatively this could be a string control I think. That could be added
to existing drivers as well.

-- 
Kind regards,

Sakari Ailus

       reply	other threads:[~2022-09-23 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166392656967.56880.6892202016312600929@Monstersaurus>
2022-09-23 10:03 ` Sakari Ailus [this message]
2022-09-23 13:42   ` RFC: Arducam 64 MP (Hawkeye) Laurent Pinchart
2022-09-23 20:46     ` [libcamera-devel] " Dave Stevenson
2022-09-26  9:09       ` Kieran Bingham
2022-09-26 12:19     ` Kieran Bingham
2022-09-26 15:20       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yy2EZ4JwG01UKLhX@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=libcamera-devel@lists.libcamera.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.