From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FDB7C54EE9 for ; Tue, 13 Sep 2022 15:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yrLx3Kp24rclge4DY1UJHPMClIAKIAX2pOqueWkpWYk=; b=WDs6b0X+ciP/UO Bpb4juaXWYDsxjAM4Ej415Jt27Lvz3MlMAqLod33BRPabb6xRbYlNNipSDVqcPfqmXc56w5Hq5ib4 T0gzw5trz+qgjpkj7SIpzZdx/3kdxA/eL4FCl2CNc5ETQtr9zYnpZfQmwy3Lc/XIacjOXVZrLyZnU ImRrLJejm0nYdhKIQeFC5GiqZind7uBlojf7JrJMRXPV7xOQudLd9YrbLs7N4MzDwrIVeWnI/9AHY LY31gIS+8ULYLi8bt4yG+CyhURZTK1nHuqU3im2efPru/E7eZz0XO+HBNckMxLGigDON2sI3B41pW CnBRzrRMQfZANgY97rew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY7nN-00CT5y-JS; Tue, 13 Sep 2022 15:25:53 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY7dL-00CJ9a-QK for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 15:15:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8162F614A1; Tue, 13 Sep 2022 15:15:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95C16C433D6; Tue, 13 Sep 2022 15:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663082129; bh=9574kaSGiUpQ1RKeeeAf7bmjgJV7cpo3A99ptlG2Ccw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVQSXgc1SwLvIiJiCD5KSewwiyO4s7/WwES4cFEGdhdMky9qaTLL60W9Vc26N/h9v GHbMU5y75SAmzHJCbiS6FfBkGlbLICQIbmzIBpQnkFzfEhthi68ASmLBPuHJZPbvIu d1usMpJZcffYdQgkkQJrJlMVzwiEhdTNP+i3JP0s= Date: Tue, 13 Sep 2022 17:15:54 +0200 From: Greg KH To: Olof Johansson Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Saravana Kannan , Linux ARM Mailing List , Shawn Guo , Li Yang Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_081531_981627_C80F8B38 X-CRM114-Status: GOOD ( 30.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > Hi, > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > Saravana Kannan (11): > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > driver core: Add wait_for_init_devices_probe helper function > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > driver core: Set fw_devlink.strict=1 by default > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > driver core: Delete driver_deferred_probe_check_state() > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > the machine I do maintainer work on). It stops PCIe from probing, but > > without a single message indicating why. > > > > The reason seems to be that the iommu-maps property doesn't get > > patched up by my (older) u-boot, and thus isn't a valid reference. > > System works fine without IOMMU, which is how I've ran it for a couple > > of years. > > > > It's also extremely hard to diagnose out of the box because there are > > *no error messages*. And there were no warnings leading up to this > > strict enforcement. > > > > This "feature" seems to have been done backwards. The checks should > > have been running (and not skipped due to the "optional" flag), but > > also not causing errors, just warnings. That would have given users a > > chance to know that this is something that needs to be fixed. > > > > And when you flip the switch, at least report what failed so that > > people don't need to spend a whole night bisecting kernels, please. > > > > Greg, mind reverting just the last one? If I hit this, I presume > > others would too. > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > fw_devlink.strict=1 by default", 71066545b48e42. Is this still an issue in -rc5? A number of patches in the above series was just reverted and hopefully should have resolved the issue you are seeing. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2685DECAAD8 for ; Tue, 13 Sep 2022 17:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbiIMRMG (ORCPT ); Tue, 13 Sep 2022 13:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbiIMRLh (ORCPT ); Tue, 13 Sep 2022 13:11:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A3CE719AD for ; Tue, 13 Sep 2022 09:00:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43CE6B80F6F for ; Tue, 13 Sep 2022 15:15:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95C16C433D6; Tue, 13 Sep 2022 15:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663082129; bh=9574kaSGiUpQ1RKeeeAf7bmjgJV7cpo3A99ptlG2Ccw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVQSXgc1SwLvIiJiCD5KSewwiyO4s7/WwES4cFEGdhdMky9qaTLL60W9Vc26N/h9v GHbMU5y75SAmzHJCbiS6FfBkGlbLICQIbmzIBpQnkFzfEhthi68ASmLBPuHJZPbvIu d1usMpJZcffYdQgkkQJrJlMVzwiEhdTNP+i3JP0s= Date: Tue, 13 Sep 2022 17:15:54 +0200 From: Greg KH To: Olof Johansson Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Saravana Kannan , Linux ARM Mailing List , Shawn Guo , Li Yang Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > Hi, > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > Saravana Kannan (11): > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > driver core: Add wait_for_init_devices_probe helper function > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > driver core: Set fw_devlink.strict=1 by default > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > driver core: Delete driver_deferred_probe_check_state() > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > the machine I do maintainer work on). It stops PCIe from probing, but > > without a single message indicating why. > > > > The reason seems to be that the iommu-maps property doesn't get > > patched up by my (older) u-boot, and thus isn't a valid reference. > > System works fine without IOMMU, which is how I've ran it for a couple > > of years. > > > > It's also extremely hard to diagnose out of the box because there are > > *no error messages*. And there were no warnings leading up to this > > strict enforcement. > > > > This "feature" seems to have been done backwards. The checks should > > have been running (and not skipped due to the "optional" flag), but > > also not causing errors, just warnings. That would have given users a > > chance to know that this is something that needs to be fixed. > > > > And when you flip the switch, at least report what failed so that > > people don't need to spend a whole night bisecting kernels, please. > > > > Greg, mind reverting just the last one? If I hit this, I presume > > others would too. > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > fw_devlink.strict=1 by default", 71066545b48e42. Is this still an issue in -rc5? A number of patches in the above series was just reverted and hopefully should have resolved the issue you are seeing. thanks, greg k-h