From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3739EECAAD3 for ; Wed, 14 Sep 2022 15:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rPg7uLt6LNt0l2vAYAt34zPvtBVBY5f8bhfzNXgsEJ4=; b=r9P0OzWTrQPzks GMtbZzvdzMs4ggVZE7fTzrRHe4uSobepw1WR0x+bDvAfchD4H5bIbb2ITI8Vxk+1ZxCplxk9lbQS1 snTpF6cwczu6zo+ZamrrEVh/rNRDL1A+3ziZVHNUURIbEZ5yCZTrZAI9KPG+1jJ5dqdm9gF1me0eb GmwDFHlcnC9ygXeKUCSg9sW1WzSgBtNuhZ9+Mc4vLX0o6FFFz2XBNfezCMrqeLGCdFrFeYhBA56U0 iVxNtvjN13uevoiFxM5w04me9m7oTVgzCC2q6XBqXXSrWHsfjC1vCRWWRZlxRPgwtZ2RmcfxqscI/ N6oCINQVF3KTMDXguTCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUSm-0048hW-OU; Wed, 14 Sep 2022 15:38:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUSj-0048SJ-GK for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 15:38:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gOLBlb9Twt2TVyi5QU0OEVORWi4d1OG8YQSlE6qjmQI=; b=CNSOrwQV8vwpuT7NrFT64kb16a 84RpgkIOOH6vzLgiPVCttzaggrt7uDhdBHsZsSAIxqXyr8ONlD+ppRrBRZM9/t6owAuczFx017TbW JwlHTWJOU8dtSaTvBVQ8XI+43bvv+EP4qocVXdfkuKGmgY353v1GK68IOfy1mdJ93dxLeuGBIt5Ed 6OO/MhlV8oVx7QeipfGSkMGVoRSuP2ApbHHcYD0Vg2N37+G9euMcfNPBDdNKcawcxYVkxPgIY8OmT UiRm1QmfVzwlXgEQZeVokbab1Ss8GPe7gCNgwNC4pUIcxU5reS1sjRjL+F8LHA1T2HW9qNnIVdblj D6o8Gy8Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34320) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYUSW-0004Y6-Ol; Wed, 14 Sep 2022 16:37:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYUSS-0001kz-Vo; Wed, 14 Sep 2022 16:37:48 +0100 Date: Wed, 14 Sep 2022 16:37:48 +0100 From: "Russell King (Oracle)" To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, krzysztof.kozlowski+dt@linaro.org, vladimir.oltean@nxp.com, grygorii.strashko@ti.com, vigneshr@ti.com, nsekhar@ti.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com Subject: Re: [PATCH 2/8] net: ethernet: ti: am65-cpsw: Add support for SERDES configuration Message-ID: References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-3-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220914095053.189851-3-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_083805_563736_870738D4 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 14, 2022 at 03:20:47PM +0530, Siddharth Vadapalli wrote: > @@ -1427,6 +1471,9 @@ static void am65_cpsw_nuss_mac_link_down(struct phylink_config *config, unsigned > struct net_device *ndev = port->ndev; > int tmo; > > + /* disable phy */ > + am65_cpsw_disable_phy(port->slave.ifphy); > + This seems really strange. If you have a serdes interface which presumably supports SGMII, 1000base-X etc, then link status is sent across the serdes interface. If you power down the serdes, then you can't receive the link status, and so mac_link_up() won't be called. Are you really sure you want to be enabling and disabling the PHY in mac_link_down()/mac_link_up() ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14F7C6FA82 for ; Wed, 14 Sep 2022 15:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbiINPk0 (ORCPT ); Wed, 14 Sep 2022 11:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbiINPkC (ORCPT ); Wed, 14 Sep 2022 11:40:02 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D8066AA3E; Wed, 14 Sep 2022 08:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gOLBlb9Twt2TVyi5QU0OEVORWi4d1OG8YQSlE6qjmQI=; b=CNSOrwQV8vwpuT7NrFT64kb16a 84RpgkIOOH6vzLgiPVCttzaggrt7uDhdBHsZsSAIxqXyr8ONlD+ppRrBRZM9/t6owAuczFx017TbW JwlHTWJOU8dtSaTvBVQ8XI+43bvv+EP4qocVXdfkuKGmgY353v1GK68IOfy1mdJ93dxLeuGBIt5Ed 6OO/MhlV8oVx7QeipfGSkMGVoRSuP2ApbHHcYD0Vg2N37+G9euMcfNPBDdNKcawcxYVkxPgIY8OmT UiRm1QmfVzwlXgEQZeVokbab1Ss8GPe7gCNgwNC4pUIcxU5reS1sjRjL+F8LHA1T2HW9qNnIVdblj D6o8Gy8Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34320) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYUSW-0004Y6-Ol; Wed, 14 Sep 2022 16:37:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYUSS-0001kz-Vo; Wed, 14 Sep 2022 16:37:48 +0100 Date: Wed, 14 Sep 2022 16:37:48 +0100 From: "Russell King (Oracle)" To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, krzysztof.kozlowski+dt@linaro.org, vladimir.oltean@nxp.com, grygorii.strashko@ti.com, vigneshr@ti.com, nsekhar@ti.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com Subject: Re: [PATCH 2/8] net: ethernet: ti: am65-cpsw: Add support for SERDES configuration Message-ID: References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-3-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220914095053.189851-3-s-vadapalli@ti.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2022 at 03:20:47PM +0530, Siddharth Vadapalli wrote: > @@ -1427,6 +1471,9 @@ static void am65_cpsw_nuss_mac_link_down(struct phylink_config *config, unsigned > struct net_device *ndev = port->ndev; > int tmo; > > + /* disable phy */ > + am65_cpsw_disable_phy(port->slave.ifphy); > + This seems really strange. If you have a serdes interface which presumably supports SGMII, 1000base-X etc, then link status is sent across the serdes interface. If you power down the serdes, then you can't receive the link status, and so mac_link_up() won't be called. Are you really sure you want to be enabling and disabling the PHY in mac_link_down()/mac_link_up() ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!