From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BECAECAAD3 for ; Wed, 14 Sep 2022 14:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbiINOBV (ORCPT ); Wed, 14 Sep 2022 10:01:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229925AbiINOAn (ORCPT ); Wed, 14 Sep 2022 10:00:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E21792FD for ; Wed, 14 Sep 2022 07:00:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F13A961DB3 for ; Wed, 14 Sep 2022 14:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEAF0C433C1; Wed, 14 Sep 2022 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663164013; bh=qYbGgDOkCLxv6FtLLV2PwvqOXvHPgUhdwYIvPpAFNMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHlc/jP12AJdEOQz42vbJrc6gfIouH/FFi+vXxtPuQuJC1Rqz7IDq3hu0YzuX5Giz xuEeNpobKeQh+44ssH+QRGGi8ffWXrsVxMc7g0OV1aNzzOloNzFb9c/ZjJBgnDESpv rpJz6Tm4XG0MpA0XIwUlzfBYumBVYNOnAeoUmgbk= Date: Wed, 14 Sep 2022 16:00:37 +0200 From: Greg KH To: Saravana Kannan , Olof Johansson Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Linux ARM Mailing List , Shawn Guo , Li Yang Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 09:28:27AM -0700, Olof Johansson wrote: > On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > > > Hi, > > > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > > > Saravana Kannan (11): > > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > > driver core: Add wait_for_init_devices_probe helper function > > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > > driver core: Set fw_devlink.strict=1 by default > > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > > driver core: Delete driver_deferred_probe_check_state() > > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > > without a single message indicating why. > > > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > > System works fine without IOMMU, which is how I've ran it for a couple > > > > of years. > > > > > > > > It's also extremely hard to diagnose out of the box because there are > > > > *no error messages*. And there were no warnings leading up to this > > > > strict enforcement. > > > > > > > > This "feature" seems to have been done backwards. The checks should > > > > have been running (and not skipped due to the "optional" flag), but > > > > also not causing errors, just warnings. That would have given users a > > > > chance to know that this is something that needs to be fixed. > > > > > > > > And when you flip the switch, at least report what failed so that > > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > > others would too. > > > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > > fw_devlink.strict=1 by default", 71066545b48e42. > > > > Is this still an issue in -rc5? A number of patches in the above series > > was just reverted and hopefully should have resolved the issue you are > > seeing. > > Unfortunately, I discovered this regression with -rc5 in the first > place, so it's still there. Ick, ok, Saravana, any thoughts? I know you're at the conference this week with me, maybe you can give Olof a hint as to what to look for here? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F34A2C6FA8A for ; Wed, 14 Sep 2022 14:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f6iEF7fGTSvNTPkN4k9ANpij/t4Cdd3lz7DZf8dR0t0=; b=DrCx3FrO3JnVxN nHx0IeF3B5Kb0XQud33q8EzoTfVmnTftbzDkGeOJYFf4FcavPHbOKW/F7RmvVSBINdog98fAmxQhD L5RJa1wAca3DCfsnUf45kq/fUkHkb19og0SYJTsR9H53Y7ZlmXCbdZu8vCwZ5E6E+4xCggeAzjnUd LaVugXDrTTI6uRJ9RPoFSqe3XYcr5x76R0P1Bel2m9m+hTh6fYRdtgfdPqV4j1gdgXdd7bmR/h51R 81sGNS4GQo0ToPjoi6C/w5+B42UgpeTxmz0Ji1wAufb77t11fy6SNtEMjfsJscSB5hkKwz5r+J7AU VR3jP+bed6Xxlp4AaItA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYSw6-001Tjp-3F; Wed, 14 Sep 2022 14:00:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYSw3-001TfW-3M for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 14:00:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F8E561DB6; Wed, 14 Sep 2022 14:00:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEAF0C433C1; Wed, 14 Sep 2022 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663164013; bh=qYbGgDOkCLxv6FtLLV2PwvqOXvHPgUhdwYIvPpAFNMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHlc/jP12AJdEOQz42vbJrc6gfIouH/FFi+vXxtPuQuJC1Rqz7IDq3hu0YzuX5Giz xuEeNpobKeQh+44ssH+QRGGi8ffWXrsVxMc7g0OV1aNzzOloNzFb9c/ZjJBgnDESpv rpJz6Tm4XG0MpA0XIwUlzfBYumBVYNOnAeoUmgbk= Date: Wed, 14 Sep 2022 16:00:37 +0200 From: Greg KH To: Saravana Kannan , Olof Johansson Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Linux ARM Mailing List , Shawn Guo , Li Yang Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_070015_243528_EEB3F781 X-CRM114-Status: GOOD ( 35.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 09:28:27AM -0700, Olof Johansson wrote: > On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > > > Hi, > > > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > > > Saravana Kannan (11): > > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > > driver core: Add wait_for_init_devices_probe helper function > > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > > driver core: Set fw_devlink.strict=1 by default > > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > > driver core: Delete driver_deferred_probe_check_state() > > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > > without a single message indicating why. > > > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > > System works fine without IOMMU, which is how I've ran it for a couple > > > > of years. > > > > > > > > It's also extremely hard to diagnose out of the box because there are > > > > *no error messages*. And there were no warnings leading up to this > > > > strict enforcement. > > > > > > > > This "feature" seems to have been done backwards. The checks should > > > > have been running (and not skipped due to the "optional" flag), but > > > > also not causing errors, just warnings. That would have given users a > > > > chance to know that this is something that needs to be fixed. > > > > > > > > And when you flip the switch, at least report what failed so that > > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > > others would too. > > > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > > fw_devlink.strict=1 by default", 71066545b48e42. > > > > Is this still an issue in -rc5? A number of patches in the above series > > was just reverted and hopefully should have resolved the issue you are > > seeing. > > Unfortunately, I discovered this regression with -rc5 in the first > place, so it's still there. Ick, ok, Saravana, any thoughts? I know you're at the conference this week with me, maybe you can give Olof a hint as to what to look for here? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel