From: Sam Ravnborg <sam@ravnborg.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness
Date: Sat, 17 Sep 2022 23:20:54 +0200 [thread overview]
Message-ID: <YyY6Ng8hSxerHiIA@ravnborg.org> (raw)
In-Reply-To: <a3ab15e8-b4a1-171d-a5cd-0ae1ed06998e@redhat.com>
Hi Hans,
On Sat, Sep 17, 2022 at 11:00:55PM +0200, Hans de Goede wrote:
> Hi,
>
> On 9/17/22 22:46, Sam Ravnborg wrote:
> > On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote:
> >> Use backlight_get_brightness() instead of directly referencing
> >> bd->props.brightness. This will take backlight_is_blank() into account,
> >> properly setting brightness to 0 when screen-blanking has been requested
> >> through the backlight sysfs interface.
> >>
> >> Suggested-by: Sam Ravnborg <sam@ravnborg.org>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Thank you.
>
> I have just send out a v3 with your ack added and fixing the
> 2 unused variables when CONFIG_BACKLIGHT is not set spotted
> by the lkp test robot.
>
> I was sort of hoping that you could review / ack the entire
> series ?
OK, I may take a closer look tomorrow then (as time permits - needs to
prepare for a business trip too).
I have not looked at gma500 code that much so I hope Patrick
takes a look too.
Sam
next prev parent reply other threads:[~2022-09-17 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 14:03 [PATCH v2 0/5] drm/gma500: Backlight handling changes Hans de Goede
2022-09-17 14:03 ` [PATCH v2 1/5] drm/gma500: Refactor backlight support Hans de Goede
2022-09-17 17:35 ` kernel test robot
2022-09-17 20:47 ` Hans de Goede
2022-09-17 20:47 ` Hans de Goede
2022-09-17 14:03 ` [PATCH v2 2/5] drm/gma500: Change registered backlight device type to raw/native Hans de Goede
2022-09-17 14:03 ` [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness Hans de Goede
2022-09-17 20:46 ` Sam Ravnborg
2022-09-17 21:00 ` Hans de Goede
2022-09-17 21:20 ` Sam Ravnborg [this message]
2022-09-17 14:03 ` [PATCH v2 4/5] drm/gma500: Don't register backlight when another backlight should be used Hans de Goede
2022-09-17 14:03 ` [PATCH v2 5/5] drm/gma500: Call acpi_video_register_backlight() Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyY6Ng8hSxerHiIA@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.