From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF25CECAAA1 for ; Sat, 17 Sep 2022 20:46:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1032910E138; Sat, 17 Sep 2022 20:46:27 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C6DF10E138 for ; Sat, 17 Sep 2022 20:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=YUp7eOYRj7NNW41VZhjSbkhr2mfQPbNKb5+BVn74pSo=; b=FbgIDpYxwfyc/oNilwfZYfFvj/C6qYpVuF+d/9B2t6NvJx2oPvewMp9O4msL/LiI2hEMXqc2/1RU4 8D2OUaPX6do7yPCbVzL9iwB8qoE2YoC2SaO8Au+4L9qHZh7umM/ySXLPOu48+Nasq6xjtX1cD2Vl3S jyX4bh6T3Pe1qE5zomPykNDf7K+UpqYrkpTfiY7bGfcOKXLIFJgKxKLf6z6Enlx4PzjCJw7LXFlpuK xcApqwH1CT27OMV6kSK0DhRGdwgI8MWL784sEgKI2GkjfQ4MLfs9dT4rynHmjcE31Jl23KIblx1Nmx 8JPl3dkAo89B5+aWvuchy+ckKWYNhmQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=YUp7eOYRj7NNW41VZhjSbkhr2mfQPbNKb5+BVn74pSo=; b=/gwclmJg16KfLOxu4X35XsZEcygNNRZeMAeQL8kfBkMMMkFYPde5NHwwXj2vb4pj/zE4vK8iuzihl HiibttFAA== X-HalOne-Cookie: 8d9fcdec142a8f04df2db102c52d7c9564c171a2 X-HalOne-ID: c7798d2e-36c9-11ed-be8b-d0431ea8bb03 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id c7798d2e-36c9-11ed-be8b-d0431ea8bb03; Sat, 17 Sep 2022 20:46:19 +0000 (UTC) Date: Sat, 17 Sep 2022 22:46:18 +0200 From: Sam Ravnborg To: Hans de Goede Subject: Re: [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness Message-ID: References: <20220917140352.526507-1-hdegoede@redhat.com> <20220917140352.526507-4-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917140352.526507-4-hdegoede@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote: > Use backlight_get_brightness() instead of directly referencing > bd->props.brightness. This will take backlight_is_blank() into account, > properly setting brightness to 0 when screen-blanking has been requested > through the backlight sysfs interface. > > Suggested-by: Sam Ravnborg > Signed-off-by: Hans de Goede Acked-by: Sam Ravnborg > --- > Changes in v2 of the patch-set: > - New patch in v2 of the patch-set > --- > drivers/gpu/drm/gma500/backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/backlight.c b/drivers/gpu/drm/gma500/backlight.c > index d113c5810ca5..9be28dc0bdd1 100644 > --- a/drivers/gpu/drm/gma500/backlight.c > +++ b/drivers/gpu/drm/gma500/backlight.c > @@ -52,7 +52,7 @@ static int gma_backlight_get_brightness(struct backlight_device *bd) > static int gma_backlight_update_status(struct backlight_device *bd) > { > struct drm_device *dev = bl_get_data(bd); > - int level = bd->props.brightness; > + int level = backlight_get_brightness(bd); > > /* Percentage 1-100% being valid */ > if (level < 1) > -- > 2.37.3