From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769EBC6FA90 for ; Mon, 19 Sep 2022 14:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbiISOjM (ORCPT ); Mon, 19 Sep 2022 10:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbiISOii (ORCPT ); Mon, 19 Sep 2022 10:38:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC4A132ED7; Mon, 19 Sep 2022 07:38:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79ADCB81BB2; Mon, 19 Sep 2022 14:38:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD2BC433D6; Mon, 19 Sep 2022 14:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663598314; bh=I4slow66o1do4iHY4dVCquBrne7P15Xe7fjcN3YrGBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKuXED41MDSvmM15Rn9NgzU2+swVKRyMmL2IwqJfg3HuySZMFL6btcmNg4tWhTloC mjl5cFkVSwKGZJN61+LXlUJEk3zbYN/ARUnrSm22pX9Jc7bD9XwOQDDGFNeRMhvQUK nfJfPZ21INqfHy/PKEduY14ia8VsPiZjS9d2WSUyssoSvvzb3mI33l0c9J2rKdskR+ dpSZnoSbD/6gzVTSardEtgP7t7mlaT6TBPpnggXyjxm+bqph80SJu5TfInRQfKksI+ i7ZRwecMwidsFWZxRFYIYhdIvCvMqNuI05OZY919Z/5LfnayFM4YAP0HsTvSJE+rer 42SotnGhh/cyg== Date: Mon, 19 Sep 2022 15:38:29 +0100 From: Mark Brown To: Vincent Whitchurch Cc: krzysztof.kozlowski@linaro.org, andi@etezian.org, kernel@axis.com, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA Message-ID: References: <20220916113951.228398-1-vincent.whitchurch@axis.com> <20220916113951.228398-5-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dO9gKB7zQfnK2ZIl" Content-Disposition: inline In-Reply-To: <20220916113951.228398-5-vincent.whitchurch@axis.com> X-Cookie: One FISHWICH coming up!! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dO9gKB7zQfnK2ZIl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 16, 2022 at 01:39:51PM +0200, Vincent Whitchurch wrote: > The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum > value is 65535. Asking the driver to transfer a larger size currently > leads to the DMA transfer timing out. Fix this by splitting the > transfer as needed. The driver should just set max_transfer_size and let the core handle this. --dO9gKB7zQfnK2ZIl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMofuQACgkQJNaLcl1U h9CkLQf/dxD3O0Krb1u4seN5Eu0HeDDdvPbLKbpo9s9ygOXcc45TifgEIA3uqLGB kyWLzK5AI4bPBscL9r4sdp8XslqhLe2Nmfpfl4t2O+QpGCYJ9J3A9SL5flkOkBOy 7Zrj4U+TZf2aLvwF1+L/4VcbhKT37ATxLFxv3iA2tcvSac6RL8wdjcWIlR/U2Lfh viR3ypqDIIoEr1oHS2LQZZ+1lBE/PEUGq2OOJUMfba2BdCDs7G4JOQFZSRy6CNzm yXjkmYz6/vQxTCwmmL+DENFDDZEuDk1EY8adBkxv38kpEsP7cQrfYyXVxAk3SoFH eigz7ih5MSbIAwKeVapM/mW1VLCyoQ== =wTYf -----END PGP SIGNATURE----- --dO9gKB7zQfnK2ZIl-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20417C54EE9 for ; Mon, 19 Sep 2022 14:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y3praj8+vZcHYOVfdfut06XqJutaL/eexB570zYP0RY=; b=u7skGsXa3DFGz2Eqg9WBeMymkf f+nNkeNQ46iOkazfj08oC7v94p0WAduaKvXDk/7JNHGoTE9cGNOIGcyeOFMu9TJUvvqBL/6p8aCMe il6QQczlOyVJ4bCXu9fjSmd63SdDNcC0ATHfNyND6BS9IHiXHccIiR11rtKqdvN2GcD0SSAxLUUD1 +y+8ON5//Tr496s1lAQ7w8R/dpwHQWKjxn19PRL7zdYTTK71JFqKKWbAx/GkVu0Qk1DkPCFlDnOGd YHmpo4OD2uEkup6teh7ig3aAjoXP7DpDEwZFDTqmeERsM+SahUlzTmDKKgUs0dxmbZ+HSfkeRDN4O BxXdarVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaHux-00C8Py-U6; Mon, 19 Sep 2022 14:38:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaHut-00C8O6-1Z for linux-arm-kernel@lists.infradead.org; Mon, 19 Sep 2022 14:38:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 984A761D5A; Mon, 19 Sep 2022 14:38:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD2BC433D6; Mon, 19 Sep 2022 14:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663598314; bh=I4slow66o1do4iHY4dVCquBrne7P15Xe7fjcN3YrGBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKuXED41MDSvmM15Rn9NgzU2+swVKRyMmL2IwqJfg3HuySZMFL6btcmNg4tWhTloC mjl5cFkVSwKGZJN61+LXlUJEk3zbYN/ARUnrSm22pX9Jc7bD9XwOQDDGFNeRMhvQUK nfJfPZ21INqfHy/PKEduY14ia8VsPiZjS9d2WSUyssoSvvzb3mI33l0c9J2rKdskR+ dpSZnoSbD/6gzVTSardEtgP7t7mlaT6TBPpnggXyjxm+bqph80SJu5TfInRQfKksI+ i7ZRwecMwidsFWZxRFYIYhdIvCvMqNuI05OZY919Z/5LfnayFM4YAP0HsTvSJE+rer 42SotnGhh/cyg== Date: Mon, 19 Sep 2022 15:38:29 +0100 From: Mark Brown To: Vincent Whitchurch Cc: krzysztof.kozlowski@linaro.org, andi@etezian.org, kernel@axis.com, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA Message-ID: References: <20220916113951.228398-1-vincent.whitchurch@axis.com> <20220916113951.228398-5-vincent.whitchurch@axis.com> MIME-Version: 1.0 In-Reply-To: <20220916113951.228398-5-vincent.whitchurch@axis.com> X-Cookie: One FISHWICH coming up!! X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_073835_156483_D9A29DFF X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6177300732005284336==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6177300732005284336== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dO9gKB7zQfnK2ZIl" Content-Disposition: inline --dO9gKB7zQfnK2ZIl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 16, 2022 at 01:39:51PM +0200, Vincent Whitchurch wrote: > The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum > value is 65535. Asking the driver to transfer a larger size currently > leads to the DMA transfer timing out. Fix this by splitting the > transfer as needed. The driver should just set max_transfer_size and let the core handle this. --dO9gKB7zQfnK2ZIl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMofuQACgkQJNaLcl1U h9CkLQf/dxD3O0Krb1u4seN5Eu0HeDDdvPbLKbpo9s9ygOXcc45TifgEIA3uqLGB kyWLzK5AI4bPBscL9r4sdp8XslqhLe2Nmfpfl4t2O+QpGCYJ9J3A9SL5flkOkBOy 7Zrj4U+TZf2aLvwF1+L/4VcbhKT37ATxLFxv3iA2tcvSac6RL8wdjcWIlR/U2Lfh viR3ypqDIIoEr1oHS2LQZZ+1lBE/PEUGq2OOJUMfba2BdCDs7G4JOQFZSRy6CNzm yXjkmYz6/vQxTCwmmL+DENFDDZEuDk1EY8adBkxv38kpEsP7cQrfYyXVxAk3SoFH eigz7ih5MSbIAwKeVapM/mW1VLCyoQ== =wTYf -----END PGP SIGNATURE----- --dO9gKB7zQfnK2ZIl-- --===============6177300732005284336== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6177300732005284336==--