From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D47D5C54EE9 for ; Mon, 19 Sep 2022 14:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbiISO22 (ORCPT ); Mon, 19 Sep 2022 10:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbiISO2Y (ORCPT ); Mon, 19 Sep 2022 10:28:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F018B2656C for ; Mon, 19 Sep 2022 07:28:23 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 307EA9BA; Mon, 19 Sep 2022 16:28:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663597702; bh=fmHcc+CPAWqmG5o3iUo7sLYZMY/QaQ5lUhNj3gQ+Aec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C/b4WSW+6joBqqFcFqDKlrKo5dzviJedlb75HQMcd4EuVX0TyeaxhYfMngeuXebyg Le6cGakiuMZEhMYQoWLhdT1edjETrzqokpaTplAAZ69lVH/ammYCEPP0EbZx7Oiodh fYv4sXnjDWL7TZehNzOxKq4jzvfPanjT71dIOuq4= Date: Mon, 19 Sep 2022 17:28:09 +0300 From: Laurent Pinchart To: Yang Yingliang Cc: linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, pavel@ucw.cz, sakari.ailus@linux.intel.com, sean@mess.org Subject: Re: [PATCH -next 06/13] media: platform: exynos4-is: Switch to use dev_err_probe() helper Message-ID: References: <20220915150324.688062-1-yangyingliang@huawei.com> <20220915150324.688062-7-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220915150324.688062-7-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Yang, Thank you for the patch. On Thu, Sep 15, 2022 at 11:03:17PM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replace with dev_err_probe() > which will check if error code is -EPROBE_DEFER. > > Signed-off-by: Yang Yingliang > --- > drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c > index 52b43ea04030..b7977d8da8e5 100644 > --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c > +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c > @@ -1473,9 +1473,7 @@ static int fimc_md_probe(struct platform_device *pdev) > > pinctrl = devm_pinctrl_get(dev); > if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - if (ret != EPROBE_DEFER) > - dev_err(dev, "Failed to get pinctrl: %d\n", ret); > + dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); You need to set ret here. > goto err_clk; > } > -- Regards, Laurent Pinchart