From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2384ECAAD3 for ; Mon, 19 Sep 2022 10:48:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96D7F10E5FF; Mon, 19 Sep 2022 10:48:04 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F01D10E5FF for ; Mon, 19 Sep 2022 10:48:02 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 901AF9BA; Mon, 19 Sep 2022 12:48:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663584480; bh=xH0dFiynDBJvh38igkGQg8mcP/tEn+0QLkv2GwKrsOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GupHLLKhCmbowLKu/2rLAgH7lrPdvGzpo35NxtGV9CdLZPskAShPnBT+xorPQQlyt Szd0tRsLRRn6/P1/QlzxwhOCBeS5bVAHkIDvpnM4zDdiO/OdyKXsNPkjNiI3kg40pG e04YRB1vTZt4eRVIeZza44+kUH+Q4xd4SRDc+rqE= Date: Mon, 19 Sep 2022 13:47:47 +0300 From: Laurent Pinchart To: Robert Foss Subject: Re: [PATCH v2 2/2] Revert "drm/bridge: chrontel-ch7033: Add byteswap order setting" Message-ID: References: <20220919102009.150503-1-robert.foss@linaro.org> <20220919102009.150503-3-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220919102009.150503-3-robert.foss@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, andrzej.hajda@intel.com, jonas@kwiboo.se, airlied@linux.ie, narmstrong@baylibre.com, Chris Morgan , dianders@chromium.org, jernej.skrabec@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, Thank you for the patch. On Mon, Sep 19, 2022 at 12:20:09PM +0200, Robert Foss wrote: > Revert this patch since it depends on devicetree functionality that > previously has been reverted in the below commit. > > commit e798ba3374a1 ("Revert "dt-bindings: Add byteswap order to chrontel ch7033"") > > This reverts commit ce9564cfc9aea65e68eb343c599317633bc2321a. > > Fixes: 8c9c40ec8344 ("Revert "drm/bridge: ti-sn65dsi86: Implement bridge connector operations for DP"") I'm not sure this Fixes tag is meaningful here. Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Robert Foss > --- > drivers/gpu/drm/bridge/chrontel-ch7033.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c > index c5719908ce2d..ba060277c3fd 100644 > --- a/drivers/gpu/drm/bridge/chrontel-ch7033.c > +++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c > @@ -68,7 +68,6 @@ enum { > BYTE_SWAP_GBR = 3, > BYTE_SWAP_BRG = 4, > BYTE_SWAP_BGR = 5, > - BYTE_SWAP_MAX = 6, > }; > > /* Page 0, Register 0x19 */ > @@ -356,8 +355,6 @@ static void ch7033_bridge_mode_set(struct drm_bridge *bridge, > int hsynclen = mode->hsync_end - mode->hsync_start; > int vbporch = mode->vsync_start - mode->vdisplay; > int vsynclen = mode->vsync_end - mode->vsync_start; > - u8 byte_swap; > - int ret; > > /* > * Page 4 > @@ -401,16 +398,8 @@ static void ch7033_bridge_mode_set(struct drm_bridge *bridge, > regmap_write(priv->regmap, 0x15, vbporch); > regmap_write(priv->regmap, 0x16, vsynclen); > > - /* Input color swap. Byte order is optional and will default to > - * BYTE_SWAP_BGR to preserve backwards compatibility with existing > - * driver. > - */ > - ret = of_property_read_u8(priv->bridge.of_node, "chrontel,byteswap", > - &byte_swap); > - if (!ret && byte_swap < BYTE_SWAP_MAX) > - regmap_update_bits(priv->regmap, 0x18, SWAP, byte_swap); > - else > - regmap_update_bits(priv->regmap, 0x18, SWAP, BYTE_SWAP_BGR); > + /* Input color swap. */ > + regmap_update_bits(priv->regmap, 0x18, SWAP, BYTE_SWAP_BGR); > > /* Input clock and sync polarity. */ > regmap_update_bits(priv->regmap, 0x19, 0x1, mode->clock >> 16); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 772C8C54EE9 for ; Mon, 19 Sep 2022 10:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbiISKxa (ORCPT ); Mon, 19 Sep 2022 06:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbiISKxK (ORCPT ); Mon, 19 Sep 2022 06:53:10 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3495A1EC5D; Mon, 19 Sep 2022 03:48:03 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 901AF9BA; Mon, 19 Sep 2022 12:48:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663584480; bh=xH0dFiynDBJvh38igkGQg8mcP/tEn+0QLkv2GwKrsOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GupHLLKhCmbowLKu/2rLAgH7lrPdvGzpo35NxtGV9CdLZPskAShPnBT+xorPQQlyt Szd0tRsLRRn6/P1/QlzxwhOCBeS5bVAHkIDvpnM4zDdiO/OdyKXsNPkjNiI3kg40pG e04YRB1vTZt4eRVIeZza44+kUH+Q4xd4SRDc+rqE= Date: Mon, 19 Sep 2022 13:47:47 +0300 From: Laurent Pinchart To: Robert Foss Cc: andrzej.hajda@intel.com, narmstrong@baylibre.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chris Morgan , devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/2] Revert "drm/bridge: chrontel-ch7033: Add byteswap order setting" Message-ID: References: <20220919102009.150503-1-robert.foss@linaro.org> <20220919102009.150503-3-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220919102009.150503-3-robert.foss@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the patch. On Mon, Sep 19, 2022 at 12:20:09PM +0200, Robert Foss wrote: > Revert this patch since it depends on devicetree functionality that > previously has been reverted in the below commit. > > commit e798ba3374a1 ("Revert "dt-bindings: Add byteswap order to chrontel ch7033"") > > This reverts commit ce9564cfc9aea65e68eb343c599317633bc2321a. > > Fixes: 8c9c40ec8344 ("Revert "drm/bridge: ti-sn65dsi86: Implement bridge connector operations for DP"") I'm not sure this Fixes tag is meaningful here. Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Robert Foss > --- > drivers/gpu/drm/bridge/chrontel-ch7033.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c > index c5719908ce2d..ba060277c3fd 100644 > --- a/drivers/gpu/drm/bridge/chrontel-ch7033.c > +++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c > @@ -68,7 +68,6 @@ enum { > BYTE_SWAP_GBR = 3, > BYTE_SWAP_BRG = 4, > BYTE_SWAP_BGR = 5, > - BYTE_SWAP_MAX = 6, > }; > > /* Page 0, Register 0x19 */ > @@ -356,8 +355,6 @@ static void ch7033_bridge_mode_set(struct drm_bridge *bridge, > int hsynclen = mode->hsync_end - mode->hsync_start; > int vbporch = mode->vsync_start - mode->vdisplay; > int vsynclen = mode->vsync_end - mode->vsync_start; > - u8 byte_swap; > - int ret; > > /* > * Page 4 > @@ -401,16 +398,8 @@ static void ch7033_bridge_mode_set(struct drm_bridge *bridge, > regmap_write(priv->regmap, 0x15, vbporch); > regmap_write(priv->regmap, 0x16, vsynclen); > > - /* Input color swap. Byte order is optional and will default to > - * BYTE_SWAP_BGR to preserve backwards compatibility with existing > - * driver. > - */ > - ret = of_property_read_u8(priv->bridge.of_node, "chrontel,byteswap", > - &byte_swap); > - if (!ret && byte_swap < BYTE_SWAP_MAX) > - regmap_update_bits(priv->regmap, 0x18, SWAP, byte_swap); > - else > - regmap_update_bits(priv->regmap, 0x18, SWAP, BYTE_SWAP_BGR); > + /* Input color swap. */ > + regmap_update_bits(priv->regmap, 0x18, SWAP, BYTE_SWAP_BGR); > > /* Input clock and sync polarity. */ > regmap_update_bits(priv->regmap, 0x19, 0x1, mode->clock >> 16); -- Regards, Laurent Pinchart