From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96DEECAAD8 for ; Tue, 20 Sep 2022 05:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbiITFGW (ORCPT ); Tue, 20 Sep 2022 01:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbiITFGT (ORCPT ); Tue, 20 Sep 2022 01:06:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAEDE46D81 for ; Mon, 19 Sep 2022 22:06:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E6DC620AB for ; Tue, 20 Sep 2022 05:06:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469D4C433D6; Tue, 20 Sep 2022 05:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663650377; bh=xJpBWFasHV//GhCiAso/TJ5mgUV87MnaPyMLvDak5tM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rWmJkEMd2nP0KT/3w0/b2W/pYT9FK31nXFj/aYyGym5PGxOuKSEjUHMIJp9kmwSyi PXsxJ9UbLCxUJ8lroIMjswaYx4aUFn9oDQHfsyMeKrm+Lx5ylfU0xHjAJFLvo7Vk2M hvwliWEu7XPDrIeMDgiOxP7alwV3pep1nCtZ0wLQbwsTglP8//Xcj9j5W4P9MTsrXq hS6qC93wj2onYDr7tm+Yuh3xV+MxszpUGh1cXxkOGKzbSmoH73lgMLrZszHU1cBDxh 4l85PXhkhVIA/y334HiwSMP7KIFkahnWU7oYDKruK1jk39TCmzUqX1xF29OPhoq2pT Cepm/I+shuxjg== Date: Tue, 20 Sep 2022 10:36:14 +0530 From: Vinod Koul To: Richard Fitzgerald Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] soundwire: cadence: Write to correct address for each FIFO chunk Message-ID: References: <20220917123517.229153-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917123517.229153-1-rf@opensource.cirrus.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-09-22, 13:35, Richard Fitzgerald wrote: > _cdns_xfer_msg() must add the fragment offset to msg->addr to get the > base target address of each FIFO chunk. Otherwise every chunk will > be written to the first 32 register addresses. Applied, thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25BEBECAAD8 for ; Tue, 20 Sep 2022 05:07:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 47E17827; Tue, 20 Sep 2022 07:06:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 47E17827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1663650434; bh=xJpBWFasHV//GhCiAso/TJ5mgUV87MnaPyMLvDak5tM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RlM7+LB5SS+mOGjC3+q8bjVucnDEYnHkchii6IcUrgLyUvlC58DymEHvp+t7MBTGv qh2nvAbZUMBsKJqvHTqv1g9ILbx+2rzUFdUFbDtCKSmw7lwc16kR2yW5a4Jx/ktfdR 1NbfGiny5ICMaQDCZ9GZgcWjySyEMaDkhWGUvuj8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EC73BF80155; Tue, 20 Sep 2022 07:06:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7AF16F80171; Tue, 20 Sep 2022 07:06:22 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CB5DCF800C9 for ; Tue, 20 Sep 2022 07:06:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CB5DCF800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rWmJkEMd" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1ED86B811AE; Tue, 20 Sep 2022 05:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469D4C433D6; Tue, 20 Sep 2022 05:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663650377; bh=xJpBWFasHV//GhCiAso/TJ5mgUV87MnaPyMLvDak5tM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rWmJkEMd2nP0KT/3w0/b2W/pYT9FK31nXFj/aYyGym5PGxOuKSEjUHMIJp9kmwSyi PXsxJ9UbLCxUJ8lroIMjswaYx4aUFn9oDQHfsyMeKrm+Lx5ylfU0xHjAJFLvo7Vk2M hvwliWEu7XPDrIeMDgiOxP7alwV3pep1nCtZ0wLQbwsTglP8//Xcj9j5W4P9MTsrXq hS6qC93wj2onYDr7tm+Yuh3xV+MxszpUGh1cXxkOGKzbSmoH73lgMLrZszHU1cBDxh 4l85PXhkhVIA/y334HiwSMP7KIFkahnWU7oYDKruK1jk39TCmzUqX1xF29OPhoq2pT Cepm/I+shuxjg== Date: Tue, 20 Sep 2022 10:36:14 +0530 From: Vinod Koul To: Richard Fitzgerald Subject: Re: [PATCH] soundwire: cadence: Write to correct address for each FIFO chunk Message-ID: References: <20220917123517.229153-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917123517.229153-1-rf@opensource.cirrus.com> Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 17-09-22, 13:35, Richard Fitzgerald wrote: > _cdns_xfer_msg() must add the fragment offset to msg->addr to get the > base target address of each FIFO chunk. Otherwise every chunk will > be written to the first 32 register addresses. Applied, thanks -- ~Vinod