From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D407DC6FA82 for ; Tue, 20 Sep 2022 07:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229490AbiITH2P (ORCPT ); Tue, 20 Sep 2022 03:28:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiITH2O (ORCPT ); Tue, 20 Sep 2022 03:28:14 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C4E2108D for ; Tue, 20 Sep 2022 00:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lVy1sbKWY8zwbL5O7wDbJAjwxBvzi1Hjx2AKofExrCs=; b=uea5TIdcjoS2OZMpObMTIEMtBU F3Cs5F2v41whiVc8iUA8l2oGb3WJnFfQ5YN5f787Atqh7Rd3zwGkf9DU0UtYsk+ogceV3BgC8h71J 5L9CFgKt94e0MbDOjFNjnOJIXfPdALjcFOgM3vHVodMsDyCbLouPFl5ku1UC70xN736Elx9D+/WPr tRfT+hV47ZyoiDfztFRrNFRk8NecmN9WW/b1UgorknqrmXAPzn3rqc8pZhKyADtbrHMqEmH6IUKqY 95d2oAqlKxRVqVpoy7UmynDD5gm/xDIdJqTf9cONesTaOAetZn7ZefLX/3hvk1QTum8v63fHfsJ1r PGTZF+uQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaXfq-001M6r-Ux; Tue, 20 Sep 2022 07:28:06 +0000 Date: Tue, 20 Sep 2022 00:28:06 -0700 From: Christoph Hellwig To: Mikulas Patocka Cc: Jens Axboe , Zdenek Kabelac , linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 1/4] brd: make brd_insert_page return bool Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Sep 16, 2022 at 04:59:19AM -0400, Mikulas Patocka wrote: > brd_insert_page returns a pointer to struct page, however the pointer is > never used (it is only compared against NULL), so to clean-up the code, we > make it return bool. Looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C94FC54EE9 for ; Tue, 20 Sep 2022 08:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663663972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3Qo5e7dFSf5nou4lyNO8zjBYC40ujPWbK/Y/XJzS0/c=; b=AoVvwXFWwzXaoPxkJOjosSJnbPuo9Hvs6+e1j1P7XQnCom2aFq0xAiX6+vEKgO81D9kT4o DpspW8EExmBDZL6JplXfADCdW7dtpbIBnZSWkYw5ubCsYCWocjBImWQXawVOakcNhhhGLk mfoXiweKFvDNaZOdPqQTK9d6JhaS9aM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-1ENSLlh2Ma2s3Kiy8Ovzpw-1; Tue, 20 Sep 2022 04:52:49 -0400 X-MC-Unique: 1ENSLlh2Ma2s3Kiy8Ovzpw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49BC880C8C4; Tue, 20 Sep 2022 08:52:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58DD82166B26; Tue, 20 Sep 2022 08:52:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 27E5519465A3; Tue, 20 Sep 2022 08:52:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6235719465A0 for ; Tue, 20 Sep 2022 08:52:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4E5FE1121315; Tue, 20 Sep 2022 08:52:43 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47A451121314 for ; Tue, 20 Sep 2022 08:52:43 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26821101E148 for ; Tue, 20 Sep 2022 08:52:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-4cHB7L0gOB-IjSrZjhufyA-1; Tue, 20 Sep 2022 04:52:41 -0400 X-MC-Unique: 4cHB7L0gOB-IjSrZjhufyA-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaXfq-001M6r-Ux; Tue, 20 Sep 2022 07:28:06 +0000 Date: Tue, 20 Sep 2022 00:28:06 -0700 From: Christoph Hellwig To: Mikulas Patocka Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Subject: Re: [dm-devel] [PATCH 1/4] brd: make brd_insert_page return bool X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-block@vger.kernel.org, dm-devel@redhat.com, Zdenek Kabelac Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 16, 2022 at 04:59:19AM -0400, Mikulas Patocka wrote: > brd_insert_page returns a pointer to struct page, however the pointer is > never used (it is only compared against NULL), so to clean-up the code, we > make it return bool. Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel