From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE39C6FA82 for ; Tue, 20 Sep 2022 16:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiITQ6W (ORCPT ); Tue, 20 Sep 2022 12:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiITQ6U (ORCPT ); Tue, 20 Sep 2022 12:58:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C056286D8 for ; Tue, 20 Sep 2022 09:58:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB0BC61489 for ; Tue, 20 Sep 2022 16:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0860C433C1; Tue, 20 Sep 2022 16:58:16 +0000 (UTC) Date: Tue, 20 Sep 2022 17:58:13 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kbuild-all@lists.01.org, Cornelia Huck , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220810193033.1090251-4-pcc@google.com> <202208111500.62e0Bl2l-lkp@intel.com> <878rmfkzbu.wl-maz@kernel.org> <871qs6kntl.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qs6kntl.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 20, 2022 at 05:33:42PM +0100, Marc Zyngier wrote: > On Tue, 20 Sep 2022 16:39:47 +0100, > Catalin Marinas wrote: > > On Mon, Sep 19, 2022 at 07:12:53PM +0100, Marc Zyngier wrote: > > > On Mon, 05 Sep 2022 18:01:55 +0100, > > > Catalin Marinas wrote: > > > > Peter, please let me know if you want to pick this series up together > > > > with your other KVM patches. Otherwise I can post it separately, it's > > > > worth merging it on its own as it clarifies the page flag vs tag setting > > > > ordering. > > > > > > I'm looking at queuing this, but I'm confused by this comment. Do I > > > need to pick this as part of the series? Or is this an independent > > > thing (my hunch is that it is actually required not to break other > > > architectures...). > > > > This series series (at least the first patches) won't apply cleanly on > > top of 6.0-rc1 and, of course, we shouldn't break other architectures. I > > can repost the whole series but I don't have the setup to test the > > MAP_SHARED KVM option (unless Peter plans to post it soon). > > I don't feel brave enough to take a series affecting all architectures It shouldn't affect the others, the only change is that PG_arch_2 is now only defined for arm64 but no other architecture is using it. The problem with loongarch is that it doesn't have enough spare bits in page->flags and even without any patches I think it's broken with the right value for NR_CPUS. > so late in the game, and the whole thing had very little arm64 > exposure. The latest QEMU doesn't seem to work anymore, so I don't > have any MTE-capable emulation (and using the FVP remotely is a pain > in the proverbial neck). > > I'll come back to this after the merge window, should Peter decide to > respin the series. It makes sense. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0FBC54EE9 for ; Tue, 20 Sep 2022 16:58:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DC0874B20F; Tue, 20 Sep 2022 12:58:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bMXfQ+vPmyPY; Tue, 20 Sep 2022 12:58:24 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9694C4B2A5; Tue, 20 Sep 2022 12:58:24 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 20FC14B15C for ; Tue, 20 Sep 2022 12:58:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PXRgzQVi5Sg6 for ; Tue, 20 Sep 2022 12:58:21 -0400 (EDT) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D8CF44B0F4 for ; Tue, 20 Sep 2022 12:58:21 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86CF5B82B57; Tue, 20 Sep 2022 16:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0860C433C1; Tue, 20 Sep 2022 16:58:16 +0000 (UTC) Date: Tue, 20 Sep 2022 17:58:13 +0100 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220810193033.1090251-4-pcc@google.com> <202208111500.62e0Bl2l-lkp@intel.com> <878rmfkzbu.wl-maz@kernel.org> <871qs6kntl.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qs6kntl.wl-maz@kernel.org> Cc: kbuild-all@lists.01.org, kernel test robot , kvm@vger.kernel.org, Will Deacon , Cornelia Huck , Steven Price , Evgenii Stepanov , Vincenzo Frascino , Peter Collingbourne , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Sep 20, 2022 at 05:33:42PM +0100, Marc Zyngier wrote: > On Tue, 20 Sep 2022 16:39:47 +0100, > Catalin Marinas wrote: > > On Mon, Sep 19, 2022 at 07:12:53PM +0100, Marc Zyngier wrote: > > > On Mon, 05 Sep 2022 18:01:55 +0100, > > > Catalin Marinas wrote: > > > > Peter, please let me know if you want to pick this series up together > > > > with your other KVM patches. Otherwise I can post it separately, it's > > > > worth merging it on its own as it clarifies the page flag vs tag setting > > > > ordering. > > > > > > I'm looking at queuing this, but I'm confused by this comment. Do I > > > need to pick this as part of the series? Or is this an independent > > > thing (my hunch is that it is actually required not to break other > > > architectures...). > > > > This series series (at least the first patches) won't apply cleanly on > > top of 6.0-rc1 and, of course, we shouldn't break other architectures. I > > can repost the whole series but I don't have the setup to test the > > MAP_SHARED KVM option (unless Peter plans to post it soon). > > I don't feel brave enough to take a series affecting all architectures It shouldn't affect the others, the only change is that PG_arch_2 is now only defined for arm64 but no other architecture is using it. The problem with loongarch is that it doesn't have enough spare bits in page->flags and even without any patches I think it's broken with the right value for NR_CPUS. > so late in the game, and the whole thing had very little arm64 > exposure. The latest QEMU doesn't seem to work anymore, so I don't > have any MTE-capable emulation (and using the FVP remotely is a pain > in the proverbial neck). > > I'll come back to this after the merge window, should Peter decide to > respin the series. It makes sense. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41FB9C6FA82 for ; Tue, 20 Sep 2022 16:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tKIL8HLHvI8Dc1hH9kIh1Zikf4Gsrg8EASDF9EeGcqA=; b=Lf5bH1y2HRj+EJ zgQIAA0pXAiwqB0To6TjtxeL63yZTbyTRqu770NLzcPQoL6r5VVJtNYwIULKqDCOHWC/lwJouxC2Q ylGcBdo01ArzmvDnrkvQxnlxOPHxTIXVQYNHzou5EvttkxamXWHVHUmG4JX11yLxK95L7jXDw0jiL 6b5C6yccOPUj4gpF2AJwz/toScHYeI+RebAAY3NbmpZ8BvtNE0kfhzX7WAt7dg3NsOgbI8tXoUTV3 J6gdvzjUzAMo8EsfHyGgbcFxbeMmpUDIll3mra4zU8z939e6B/6cJUxD5ucfyggXYIea4Dp0FToet QXr1Q7gLfFWWZt+meLkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oagZl-005Hc4-Ac; Tue, 20 Sep 2022 16:58:25 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oagZh-005Hai-UW for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 16:58:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86CF5B82B57; Tue, 20 Sep 2022 16:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0860C433C1; Tue, 20 Sep 2022 16:58:16 +0000 (UTC) Date: Tue, 20 Sep 2022 17:58:13 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kbuild-all@lists.01.org, Cornelia Huck , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220810193033.1090251-4-pcc@google.com> <202208111500.62e0Bl2l-lkp@intel.com> <878rmfkzbu.wl-maz@kernel.org> <871qs6kntl.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qs6kntl.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_095822_147066_18A04380 X-CRM114-Status: GOOD ( 28.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 20, 2022 at 05:33:42PM +0100, Marc Zyngier wrote: > On Tue, 20 Sep 2022 16:39:47 +0100, > Catalin Marinas wrote: > > On Mon, Sep 19, 2022 at 07:12:53PM +0100, Marc Zyngier wrote: > > > On Mon, 05 Sep 2022 18:01:55 +0100, > > > Catalin Marinas wrote: > > > > Peter, please let me know if you want to pick this series up together > > > > with your other KVM patches. Otherwise I can post it separately, it's > > > > worth merging it on its own as it clarifies the page flag vs tag setting > > > > ordering. > > > > > > I'm looking at queuing this, but I'm confused by this comment. Do I > > > need to pick this as part of the series? Or is this an independent > > > thing (my hunch is that it is actually required not to break other > > > architectures...). > > > > This series series (at least the first patches) won't apply cleanly on > > top of 6.0-rc1 and, of course, we shouldn't break other architectures. I > > can repost the whole series but I don't have the setup to test the > > MAP_SHARED KVM option (unless Peter plans to post it soon). > > I don't feel brave enough to take a series affecting all architectures It shouldn't affect the others, the only change is that PG_arch_2 is now only defined for arm64 but no other architecture is using it. The problem with loongarch is that it doesn't have enough spare bits in page->flags and even without any patches I think it's broken with the right value for NR_CPUS. > so late in the game, and the whole thing had very little arm64 > exposure. The latest QEMU doesn't seem to work anymore, so I don't > have any MTE-capable emulation (and using the FVP remotely is a pain > in the proverbial neck). > > I'll come back to this after the merge window, should Peter decide to > respin the series. It makes sense. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0303892526415703020==" MIME-Version: 1.0 From: Catalin Marinas To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag Date: Tue, 20 Sep 2022 17:58:13 +0100 Message-ID: In-Reply-To: <871qs6kntl.wl-maz@kernel.org> List-Id: --===============0303892526415703020== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Sep 20, 2022 at 05:33:42PM +0100, Marc Zyngier wrote: > On Tue, 20 Sep 2022 16:39:47 +0100, > Catalin Marinas wrote: > > On Mon, Sep 19, 2022 at 07:12:53PM +0100, Marc Zyngier wrote: > > > On Mon, 05 Sep 2022 18:01:55 +0100, > > > Catalin Marinas wrote: > > > > Peter, please let me know if you want to pick this series up togeth= er > > > > with your other KVM patches. Otherwise I can post it separately, it= 's > > > > worth merging it on its own as it clarifies the page flag vs tag se= tting > > > > ordering. > > > = > > > I'm looking at queuing this, but I'm confused by this comment. Do I > > > need to pick this as part of the series? Or is this an independent > > > thing (my hunch is that it is actually required not to break other > > > architectures...). > > = > > This series series (at least the first patches) won't apply cleanly on > > top of 6.0-rc1 and, of course, we shouldn't break other architectures. I > > can repost the whole series but I don't have the setup to test the > > MAP_SHARED KVM option (unless Peter plans to post it soon). > = > I don't feel brave enough to take a series affecting all architectures It shouldn't affect the others, the only change is that PG_arch_2 is now only defined for arm64 but no other architecture is using it. The problem with loongarch is that it doesn't have enough spare bits in page->flags and even without any patches I think it's broken with the right value for NR_CPUS. > so late in the game, and the whole thing had very little arm64 > exposure. The latest QEMU doesn't seem to work anymore, so I don't > have any MTE-capable emulation (and using the FVP remotely is a pain > in the proverbial neck). > = > I'll come back to this after the merge window, should Peter decide to > respin the series. It makes sense. -- = Catalin --===============0303892526415703020==--