Where do I put my new driver?

Where do I put my new driver?

[Alec Matthews]

I've created a new device driver that is responsible for controlling a
GPIO expander. This driver contains gpio_chip code, pinmux/pinconf,
code, pwm, and irq handlers. 

I'm not certain what I should name this driver. `pinctrl-*`, `gpio-*`,
or something else? 

I'm also not sure where this driver belongs in the source tree. Should
it exist in drivers/gpio, drivers/pinctrl, or drivers/pwm?

I have developed this driver out of tree, now I am trying to move it in
tree so I can begin the patch process. I appreciate any insight that
this list may have on where it belongs.


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Where do I put my new driver?

[jim.cromie]

On Mon, Aug 8, 2022 at 12:21 PM Alec Matthews <me@alecmatthews.dev> wrote:
>
> I've created a new device driver that is responsible for controlling a
> GPIO expander. This driver contains gpio_chip code, pinmux/pinconf,
> code, pwm, and irq handlers.
>
> I'm not certain what I should name this driver. `pinctrl-*`, `gpio-*`,
> or something else?
>

that suggests that you have several different drivers.
each under their own tree to get the same "place"
as the ones already there, that build cleanly,
use the subsystem support, and work.

> I'm also not sure where this driver belongs in the source tree. Should
> it exist in drivers/gpio, drivers/pinctrl, or drivers/pwm?
>
> I have developed this driver out of tree, now I am trying to move it in
> tree so I can begin the patch process. I appreciate any insight that
> this list may have on where it belongs.
>

the path of least resistance might be to just put it in staging.
Once its there and building, thats a milestone.
then when it "works" there, thats clearly another.
then maybe break it up into several ko's if feedback says.

>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Where do I put my new driver?

[Greg KH]

On Wed, Sep 21, 2022 at 04:26:29PM -0600, jim.cromie@gmail.com wrote:
> the path of least resistance might be to just put it in staging.

drivers/staging/ is not a dumping ground for drivers under active
development.  Just take the time and get it merged properly in the first
place, it's always faster and simpler that way.

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies