From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C49C4332F for ; Thu, 6 Oct 2022 06:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbiJFG15 (ORCPT ); Thu, 6 Oct 2022 02:27:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiJFG14 (ORCPT ); Thu, 6 Oct 2022 02:27:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC75868B4; Wed, 5 Oct 2022 23:27:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 20840B81FFD; Thu, 6 Oct 2022 06:27:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB6B6C433D6; Thu, 6 Oct 2022 06:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665037672; bh=QIfdJBiRQKsa5RhMHnupg9fLel0B7FyX4apbBxJ5XBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hudoBHGF6wYBmTOvztFyGW3iset3ApQrpYXpMj2zXngnJytXZ0QHDgwo/hLa9PIf6 mYq/VIh0wL5xAUsxkAnS6YaxfgnsM+vzOJMSe8SE9iLvJxwk8/pu94QCWlpmcPhSsM EyJ4H4qeVGEIucKwNIHBNSuLfgTxO7YVbljKskG0= Date: Thu, 6 Oct 2022 08:28:32 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 13/14] gunyah: rsc_mgr: Add auxiliary devices for console Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-14-quic_eberman@quicinc.com> <1db27cda-356e-bae2-3c6a-b7916123a269@quicinc.com> <31a4de54-9fbe-8487-903d-28528a1b42d3@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31a4de54-9fbe-8487-903d-28528a1b42d3@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Oct 05, 2022 at 02:47:46PM -0700, Elliot Berman wrote: > > > On 10/4/2022 11:21 PM, Greg Kroah-Hartman wrote: > > On Tue, Oct 04, 2022 at 04:49:27PM -0700, Elliot Berman wrote: > > > On 9/30/2022 5:19 AM, Greg Kroah-Hartman wrote: > > > > On Wed, Sep 28, 2022 at 12:56:32PM -0700, Elliot Berman wrote: > > > > > Gunyah resource manager exposes a concrete functionalities which > > > > > complicate a single resource manager driver. > > > > > > > > I am sorry, but I do not understand this sentance. What is so > > > > complicated about individual devices being created? Where are they > > > > created? What bus? > > > > > > There's no complexity here with using individual devices, that's why I > > > wanted to create secondary (auxiliary devices). > > > > > > IOW -- "I have a platform device that does a lot of different things. Split > > > up the different functionalities of that device into sub devices using the > > > auxiliary bus." > > > > Why not just have multiple platform devices? You control them, don't > > make it more complex than it should be. > > > > And why are these platform devices at all? > > > > As you say: > > > > > A key requirement for utilizing the auxiliary bus is that there is no > > > dependency on a physical bus, device, register accesses or regmap support. > > > These individual devices split from the core cannot live on the platform bus > > > as they are not physical devices that are controlled by DT/ACPI. > > > > These are not in the DT. So just make your own bus for them instead of > > using a platform device. Don't abuse a platform device please. > > > > I'll avoid creating platform devices. Are there any concerns with creating > auxiliary device under the platform device? Yes, don't do it if you do not have to, auxiliary devices are there only if you have no other choice. Just make 2 real devices on your own virtual bus please. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 256F1C433FE for ; Thu, 6 Oct 2022 06:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vaRuNTpSIikIYYS6zlHll14pUTpxkL9tn/FUu/YI0E0=; b=SJRRDho+88rsre VWMst6aGOZiK3M+r4hsnrWLCV7rJLYvUyzRg7SzsgGoBOw9ecGDPCP0QAgBN1XkLTxIuRFsuKxjIK qTL6BpjSuOohtbZ9jz3PxraynphABxMP1uo/lxz/O26zY6d1U5eFCNmmCTnZwKPFy/58BtHx9CGG1 6SLUTPq+5FzdX9yW1m4A8lu7+JAnZqwPRWhsJwdmb1AwZZFKnSkjraSNkZv4SxeHcCcnqMrJz1uaO OD8b2tmTeOeZ/H7ujIv/3bCQj94Q8uCaNyDtBYsOTaLnJYt7vKmJe0K6WJaRTy6nvQX6zdYmyN8xH xQENdOBORHe4Bi3sTlIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogKRB-000Ajo-Gk; Thu, 06 Oct 2022 06:32:55 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogKMN-0009B7-UW for linux-arm-kernel@lists.infradead.org; Thu, 06 Oct 2022 06:27:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 02047B81FF1; Thu, 6 Oct 2022 06:27:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB6B6C433D6; Thu, 6 Oct 2022 06:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665037672; bh=QIfdJBiRQKsa5RhMHnupg9fLel0B7FyX4apbBxJ5XBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hudoBHGF6wYBmTOvztFyGW3iset3ApQrpYXpMj2zXngnJytXZ0QHDgwo/hLa9PIf6 mYq/VIh0wL5xAUsxkAnS6YaxfgnsM+vzOJMSe8SE9iLvJxwk8/pu94QCWlpmcPhSsM EyJ4H4qeVGEIucKwNIHBNSuLfgTxO7YVbljKskG0= Date: Thu, 6 Oct 2022 08:28:32 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 13/14] gunyah: rsc_mgr: Add auxiliary devices for console Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-14-quic_eberman@quicinc.com> <1db27cda-356e-bae2-3c6a-b7916123a269@quicinc.com> <31a4de54-9fbe-8487-903d-28528a1b42d3@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <31a4de54-9fbe-8487-903d-28528a1b42d3@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221005_232756_301621_C8F04016 X-CRM114-Status: GOOD ( 29.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 05, 2022 at 02:47:46PM -0700, Elliot Berman wrote: > > > On 10/4/2022 11:21 PM, Greg Kroah-Hartman wrote: > > On Tue, Oct 04, 2022 at 04:49:27PM -0700, Elliot Berman wrote: > > > On 9/30/2022 5:19 AM, Greg Kroah-Hartman wrote: > > > > On Wed, Sep 28, 2022 at 12:56:32PM -0700, Elliot Berman wrote: > > > > > Gunyah resource manager exposes a concrete functionalities which > > > > > complicate a single resource manager driver. > > > > > > > > I am sorry, but I do not understand this sentance. What is so > > > > complicated about individual devices being created? Where are they > > > > created? What bus? > > > > > > There's no complexity here with using individual devices, that's why I > > > wanted to create secondary (auxiliary devices). > > > > > > IOW -- "I have a platform device that does a lot of different things. Split > > > up the different functionalities of that device into sub devices using the > > > auxiliary bus." > > > > Why not just have multiple platform devices? You control them, don't > > make it more complex than it should be. > > > > And why are these platform devices at all? > > > > As you say: > > > > > A key requirement for utilizing the auxiliary bus is that there is no > > > dependency on a physical bus, device, register accesses or regmap support. > > > These individual devices split from the core cannot live on the platform bus > > > as they are not physical devices that are controlled by DT/ACPI. > > > > These are not in the DT. So just make your own bus for them instead of > > using a platform device. Don't abuse a platform device please. > > > > I'll avoid creating platform devices. Are there any concerns with creating > auxiliary device under the platform device? Yes, don't do it if you do not have to, auxiliary devices are there only if you have no other choice. Just make 2 real devices on your own virtual bus please. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel