From: Conor Dooley <conor@kernel.org>
To: Qinglin Pan <panqinglin2020@iscas.ac.cn>
Cc: Andrew Jones <ajones@ventanamicro.com>,
palmer@dabbelt.com, linux-riscv@lists.infradead.org,
jeff@riscv.org, xuyinan@ict.ac.cn
Subject: Re: [PATCH v6 1/4] riscv: mm: modify pte format for Svnapot
Date: Thu, 6 Oct 2022 20:47:29 +0100 [thread overview]
Message-ID: <Yz8w0dozxbyz311O@spud> (raw)
In-Reply-To: <071c426e-16be-2720-41c4-cede59e2d82b@iscas.ac.cn>
On Wed, Oct 05, 2022 at 10:46:36PM +0800, Qinglin Pan wrote:
> On 10/5/22 10:17 PM, Andrew Jones wrote:
> > On Wed, Oct 05, 2022 at 07:29:23PM +0800, panqinglin2020@iscas.ac.cn wrote:
> > > From: Qinglin Pan <panqinglin2020@iscas.ac.cn>
> > > diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h
> > > index dc42375c2357..1cd0ffbfbdaa 100644
> > > --- a/arch/riscv/include/asm/pgtable-64.h
> > > +++ b/arch/riscv/include/asm/pgtable-64.h
> > > @@ -74,6 +74,19 @@ typedef struct {
> > > */
> > > #define _PAGE_PFN_MASK GENMASK(53, 10)
> > > +/*
> > > + * [63] Svnapot definitions:
> > > + * 0 Svnapot disabled
> > > + * 1 Svnapot enabled
> > > + */
> > > +#define _PAGE_NAPOT_SHIFT 63
> > > +#define _PAGE_NAPOT BIT(_PAGE_NAPOT_SHIFT)
> > > +#define NAPOT_CONT64KB_ORDER 4UL
> > > +#define NAPOT_CONT64KB_SHIFT (NAPOT_CONT64KB_ORDER + PAGE_SHIFT)
> > > +#define NAPOT_CONT64KB_SIZE BIT(NAPOT_CONT64KB_SHIFT)
> > > +#define NAPOT_CONT64KB_MASK (NAPOT_CONT64KB_SIZE - 1UL)
> > > +#define NAPOT_64KB_PTE_NUM BIT(NAPOT_CONT64KB_ORDER)
> >
> > I still wonder if we shouldn't future-proof a bit with something like
> >
> > /*
> > * Only 64KB (order 4) napot ptes supported.
> > */
> > #define napot_cont_order(pte) 4
> >
> > #define napot_cont_shift(order) ((order) + PAGE_SHIFT)
> > #define napot_cont_size(order) BIT(napot_cont_shift(order))
> > #define napot_cont_mask(order) BIT(napot_cont_size(order) - 1)
> > #define napot_pte_num(order) BIT(order)
>
> Maybe we can declare legal napot order in a enum, and use the enum with
> these macros you have mentioned above. I will try to do this in the v8
> patchset.
I'm in a bit of a "keep it simple" camp for these things, I had to run
through this last time to make sure to myself that it made sense. I
think Drew's version is easier to follow despite (or due to?) the
"future-proofing". Whatever you do, a comment wouldn't go amiss I think.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-10-06 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 11:29 [PATCH v6 0/4] riscv, mm: detect svnapot cpu support at runtime panqinglin2020
2022-10-05 11:29 ` [PATCH v6 1/4] riscv: mm: modify pte format for Svnapot panqinglin2020
2022-10-05 14:17 ` Andrew Jones
2022-10-05 14:46 ` Qinglin Pan
2022-10-06 19:47 ` Conor Dooley [this message]
2022-10-05 11:29 ` [PATCH v6 2/4] riscv: mm: support Svnapot in physical page linear-mapping panqinglin2020
2022-10-05 11:29 ` [PATCH v6 3/4] riscv: mm: support Svnapot in hugetlb page panqinglin2020
2022-10-05 11:29 ` [PATCH v6 4/4] riscv: mm: support Svnapot in huge vmap panqinglin2020
2022-10-05 13:29 ` [PATCH v6 0/4] riscv, mm: detect svnapot cpu support at runtime Andrew Jones
2022-10-06 19:37 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz8w0dozxbyz311O@spud \
--to=conor@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=jeff@riscv.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=panqinglin2020@iscas.ac.cn \
--cc=xuyinan@ict.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.