From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 354AFC32771 for ; Mon, 26 Sep 2022 13:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p8g8zEYcrUnGrcz0KPMNn0kpW7MiCvK+BDRRWGM48Ns=; b=20uC/LLkDGRtj6 GnB0+BuctwXby2gif8K7mNVzbw+bub6Y25sU7pD7qgwvMl1QfAzRNP2dyxAl3uN1wCespd48ujfOr Q5OEpirCUZNAixwgmkDg9BepFtI2ekhjVW5kAGza00Zohoba39uzXyFb48mx1UcRPxCwFldSw9w9C h9qDndMsPKEp7tkpzYJhYRCmyVW00keMjwldI7xlaq/K1XBOgst3O8iv8TPgzY7Yz9TTqBsIfNNwI E6ncl+7YruyfrC2NpE1P/iN8yU6v3X4yBhvoqCvs65fn8dCfjhtuZh543jDY4tWgVY0vvS68WbKxq ZEzEwRf1uEJahIcCyxlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocoNf-0059Mh-L2; Mon, 26 Sep 2022 13:42:43 +0000 Received: from smtp2.axis.com ([195.60.68.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocoNc-0059B1-BX for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 13:42:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1664199760; x=1695735760; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=z+SSPGyOZfEIh3tj+j1JJaoE55e3O7nhgeSNDbNps14=; b=OO6uXgOFMIHRwZMYHV98hMUtfBppZjS9q/OyuibOlv7zT6/MJwVI3+i/ XevNSBiZW0J1TQtvpoUCkkYi5rMbTaOMYxo6tjtEc5BFxgeAH+d6sFjEy o5XUjNHL8nxdzAaVQv6N/Gg9Nk+l6xEsmJ/trDJlBdvJzmkmeGC7K7Evd pM10bQCZAT3NpPc6dEiOGan7vWaQrdrr4jHd7XzzbmDzLfC+C9IiQEmUs /7jHyTgAxAqWxGsHmn+XlRrDAO36Ppo/A1cAEOB/rd/Ink5G0CqP+WIWv qoWW4mxqDNHABfXYZ38zJPn7KNYf+TZnD5IC8BWPuTbVtdzhUoucsfJpw A==; Date: Mon, 26 Sep 2022 15:42:30 +0200 From: Vincent Whitchurch To: Mark Brown CC: , , , , , , , Subject: Re: [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA Message-ID: References: <20220916113951.228398-1-vincent.whitchurch@axis.com> <20220916113951.228398-5-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_064240_882568_5E95FC56 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 19, 2022 at 03:38:29PM +0100, Mark Brown wrote: > On Fri, Sep 16, 2022 at 01:39:51PM +0200, Vincent Whitchurch wrote: > > The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum > > value is 65535. Asking the driver to transfer a larger size currently > > leads to the DMA transfer timing out. Fix this by splitting the > > transfer as needed. > > The driver should just set max_transfer_size and let the core > handle this. Hmm, AFAICS, the core doesn't actually do anything with max_transfer_size? It's only used from spi-mem and a handful of other clients via spi_max_transfer_size(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA735C07E9D for ; Mon, 26 Sep 2022 15:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235715AbiIZPKC (ORCPT ); Mon, 26 Sep 2022 11:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235661AbiIZPJY (ORCPT ); Mon, 26 Sep 2022 11:09:24 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077A752FD2; Mon, 26 Sep 2022 06:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1664199754; x=1695735754; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=z+SSPGyOZfEIh3tj+j1JJaoE55e3O7nhgeSNDbNps14=; b=OkdZNGA2/oB1hw2MdbaGHBmbpfLQMfiUyrWEN4GbzXnDCVfbYgghoL6X fN9wpT4eKK3LmY5vOFj+foCdwRkG9EXnNc6aBbP4Zyt47R1bnjP2lVqnV XN1qJpEubpjoVDrQuydluXzANv65pEMwaNQ/E3HT4CHlTmuQhv9ETgtDz QgmU86p8sU9WqXz7mBidoGxAtaNk/FLtNSRxrOCHoLjlwFx07gKfo7zem D8+PQnbxRYTT293XcLU+UGxu5tT3SvpTewy9SGUm+KFtNujDczHAOcpeN Qq9rKFjFDF26iHxmZEdEpDKd1EZP50bSWq5nWxKdKSHKP7N/IeBLEU1fO w==; Date: Mon, 26 Sep 2022 15:42:30 +0200 From: Vincent Whitchurch To: Mark Brown CC: , , , , , , , Subject: Re: [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA Message-ID: References: <20220916113951.228398-1-vincent.whitchurch@axis.com> <20220916113951.228398-5-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 03:38:29PM +0100, Mark Brown wrote: > On Fri, Sep 16, 2022 at 01:39:51PM +0200, Vincent Whitchurch wrote: > > The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum > > value is 65535. Asking the driver to transfer a larger size currently > > leads to the DMA transfer timing out. Fix this by splitting the > > transfer as needed. > > The driver should just set max_transfer_size and let the core > handle this. Hmm, AFAICS, the core doesn't actually do anything with max_transfer_size? It's only used from spi-mem and a handful of other clients via spi_max_transfer_size().